added IssueTest and IssueServlet to serve as a simple way of reproducing bugs

Author: erosb

tests/src/test/java/org/everit/json/schema/IssueServlet.java

@@ -0,0 +1,72 @@
+/*
+ * Copyright (C) 2011 Everit Kft. (http://www.everit.org)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.everit.json.schema;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.util.Arrays;
+import java.util.Objects;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public class IssueServlet extends HttpServlet {
+  private static final long serialVersionUID = -951266179406031349L;
+
+  private final File documentRoot;
+
+  public IssueServlet(final File documentRoot) {
+    this.documentRoot = Objects.requireNonNull(documentRoot, "documentRoot cannot be null");
+  }
+
+  @Override
+  protected void doGet(final HttpServletRequest req, final HttpServletResponse resp)
+      throws ServletException, IOException {
+    File content = fileByPath(req.getPathInfo());
+    resp.setContentType("application/json");
+    try (
+        BufferedReader bis = new BufferedReader(
+            new InputStreamReader(new FileInputStream(content)));) {
+      String line;
+      while ((line = bis.readLine()) != null) {
+        resp.getWriter().write(line);
+      }
+    }
+  }
+
+  private File fileByPath(final String pathInfo) {
+    File rval = documentRoot;
+    if (pathInfo != null && !pathInfo.equals("/") && !pathInfo.isEmpty()) {
+      String[] segments = pathInfo.trim().split("/");
+      for (String fileName : segments) {
+        if (fileName.isEmpty()) {
+          continue;
+        }
+        rval = Arrays.stream(rval.listFiles())
+            .filter(file -> file.getName().equals(fileName))
+            .findFirst()
+            .orElseThrow(() -> new RuntimeException("file [" + pathInfo + "] not found"));
+      }
+    }
+    return rval;
+  }
+
+}

tests/src/test/java/org/everit/json/schema/IssueTest.java

@@ -0,0 +1,142 @@
+/*
+ * Copyright (C) 2011 Everit Kft. (http://www.everit.org)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.everit.json.schema;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.servlet.ServletHandler;
+import org.eclipse.jetty.servlet.ServletHolder;
+import org.everit.json.schema.loader.SchemaLoader;
+import org.json.JSONException;
+import org.json.JSONObject;
+import org.json.JSONTokener;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
+
+@RunWith(Parameterized.class)
+public class IssueTest {
+
+  @Parameters
+  public static List<Object[]> params() {
+    List<Object[]> rval = new ArrayList<>();
+    try {
+      File issuesDir = new File(
+          IssueTest.class.getResource("/org/everit/json/schema/issues").toURI());
+      for (File issue : issuesDir.listFiles()) {
+        rval.add(new Object[] { issue });
+      }
+    } catch (URISyntaxException e) {
+      throw new RuntimeException(e);
+    }
+    return rval;
+  }
+
+  private final File issueDir;
+
+  private Server server;
+
+  public IssueTest(final File issueDir) {
+    this.issueDir = Objects.requireNonNull(issueDir, "issueDir cannot be null");
+  }
+
+  private Optional<File> fileByName(final String fileName) {
+    return Arrays.stream(issueDir.listFiles())
+        .filter(file -> file.getName().equals(fileName))
+        .findFirst();
+  }
+
+  private void initJetty(final File documentRoot) {
+    server = new Server(1234);
+    ServletHandler handler = new ServletHandler();
+    server.setHandler(handler);
+    handler.addServletWithMapping(new ServletHolder(new IssueServlet(documentRoot)), "/*");
+    try {
+      server.start();
+    } catch (Exception e) {
+      throw new RuntimeException(e);
+    }
+  }
+
+  private Schema loadSchema() {
+    Optional<File> schemaFile = fileByName("schema.json");
+    try {
+      if (schemaFile.isPresent()) {
+        JSONObject schemaObj = new JSONObject(
+            new JSONTokener(new FileInputStream(schemaFile.get())));
+        return SchemaLoader.load(schemaObj);
+      }
+      throw new RuntimeException(issueDir.getCanonicalPath() + "/schema.json is not found");
+    } catch (IOException e) {
+      throw new UncheckedIOException(e);
+    }
+  }
+
+  private void stopJetty() {
+    if (server != null) {
+      try {
+        server.stop();
+      } catch (Exception e) {
+        throw new RuntimeException(e);
+      }
+    }
+    server = null;
+  }
+
+  @Test
+  public void test() {
+    fileByName("remotes").ifPresent(this::initJetty);
+    Schema schema = loadSchema();
+    fileByName("subject-valid.json").ifPresent(file -> validate(file, schema, true));
+    fileByName("subject-invalid.json").ifPresent(file -> validate(file, schema, false));
+    stopJetty();
+  }
+
+  private void validate(final File file, final Schema schema, final boolean shouldBeValid) {
+    ValidationException thrown = null;
+    try {
+      JSONObject subject = new JSONObject(new JSONTokener(new FileInputStream(file)));
+      try {
+        schema.validate(subject);
+      } catch (ValidationException e) {
+        thrown = e;
+      }
+    } catch (JSONException e) {
+      throw new RuntimeException("failed to parse subject json file", e);
+    } catch (FileNotFoundException e) {
+      throw new UncheckedIOException(e);
+    }
+    if (shouldBeValid && thrown != null) {
+      Assert.fail("validation failed with: " + thrown);
+    }
+    if (!shouldBeValid && thrown == null) {
+      Assert.fail("did not throw ValidationException for invalid subject");
+    }
+  }
+}

tests/src/test/resources/org/everit/json/schema/draft4/yaala-child.json

@@ -0,0 +1,11 @@
+{
+  	"id":"http://localhost:1234/yaala/_schemas/child#",
+  	"allOf":[ 
+    	{ "$ref":"parent" },
+    	{
+    		"required":[ "s" ],
+    		"type":"object",
+    		"properties":{ "s":{ "type":"string" } }
+    	}
+  	]
+}

tests/src/test/resources/org/everit/json/schema/draft4/remotes/yaala/_schemas/parent renamed to tests/src/test/resources/org/everit/json/schema/issues/issue17/remotes/yaala/_schemas/parent

@@ -0,0 +1,4 @@
+{
+	"n":"1",
+	"s": "test"
+}

tests/src/test/resources/org/everit/json/schema/issues/issue17/schema.json

@@ -0,0 +1,4 @@
+{
+	"n":1,
+	"s": "test"
+}