PR - Remove unused constructor & make schemaVisitorListener final

Author: afranzi

core/src/main/java/org/everit/json/schema/ValidatingVisitor.java

@@ -33,7 +33,7 @@ private static boolean isNull(Object obj) {
 
     protected Object subject;
 
-    private SchemaVisitorListener schemaVisitorListener;
+    private final SchemaVisitorListener schemaVisitorListener;
 
     private ValidationFailureReporter failureReporter;
 
@@ -58,10 +58,6 @@ void visit(Schema schema) {
         this.schemaVisitorListener = schemaVisitorListener;
     }
 
-    ValidatingVisitor(Object subject, ValidationFailureReporter failureReporter, ReadWriteValidator readWriteValidator) {
-        this(subject, failureReporter, readWriteValidator, null);
-    }
-
     @Override
     void visitNumberSchema(NumberSchema numberSchema) {
         numberSchema.accept(new NumberSchemaValidatingVisitor(subject, this));

core/src/test/java/org/everit/json/schema/ValidatingVisitorTest.java

@@ -31,49 +31,49 @@ public void before() {
 
     @Test
     public void passesTypeCheck_otherType_noRequires() {
-        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, false, null));
         verifyZeroInteractions(reporter);
     }
 
     @Test
     public void passesTypeCheck_otherType_requires() {
-        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, true, null));
         verify(reporter).failure(JSONObject.class, "string");
     }
 
     @Test
     public void passesTypeCheck_otherType_nullPermitted_nullObject() {
-        ValidatingVisitor subject = new ValidatingVisitor(JSONObject.NULL, reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor(JSONObject.NULL, reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, true, Boolean.TRUE));
         verifyZeroInteractions(reporter);
     }
 
     @Test
     public void passesTypeCheck_otherType_nullPermitted_nullReference() {
-        ValidatingVisitor subject = new ValidatingVisitor(null, reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor(null, reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, true, Boolean.TRUE));
         verifyZeroInteractions(reporter);
     }
 
     @Test
     public void passesTypeCheck_nullPermitted_nonNullValue() {
-        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, true, Boolean.TRUE));
         verify(reporter).failure(JSONObject.class, "string");
     }
 
     @Test
     public void passesTypeCheck_requiresType_nullableIsNull() {
-        ValidatingVisitor subject = new ValidatingVisitor(null, reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor(null, reporter, null, null);
         assertFalse(subject.passesTypeCheck(JSONObject.class, true, null));
         verify(reporter).failure(JSONObject.class, null);
     }
 
     @Test
     public void passesTypeCheck_sameType() {
-        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null);
+        ValidatingVisitor subject = new ValidatingVisitor("string", reporter, null, null);
         assertTrue(subject.passesTypeCheck(String.class, true, Boolean.TRUE));
         verifyZeroInteractions(reporter);
     }
@@ -105,13 +105,13 @@ public Object[] notPermittedTypes() {
     @Test
     @Parameters(method = "permittedTypes")
     public void permittedTypeSuccess(Object subject) {
-        new ValidatingVisitor(subject, reporter, ReadWriteValidator.NONE);
+        new ValidatingVisitor(subject, reporter, ReadWriteValidator.NONE, null);
     }
 
     @Test(expected = IllegalArgumentException.class)
     @Parameters(method = "notPermittedTypes")
     public void notPermittedTypeFailure(Object subject) {
-        new ValidatingVisitor(subject, reporter, ReadWriteValidator.NONE);
+        new ValidatingVisitor(subject, reporter, ReadWriteValidator.NONE, null);
     }
 
 }