fixing #152

 * mostly taking the code from #153
 * also adding testing infrastructure for using custom format validators
 * (unrelated) properly overriding `FormatValidator#formatName()` in `RegexFormatValidator`

Author: erosb

core/src/main/java/org/everit/json/schema/internal/RegexFormatValidator.java

@@ -17,4 +17,7 @@ public class RegexFormatValidator implements FormatValidator {
         return Optional.empty();
     }
 
+    @Override public String formatName() {
+        return "regex";
+    }
 }

core/src/main/java/org/everit/json/schema/loader/LoadingState.java

@@ -11,6 +11,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -74,7 +75,7 @@ static URI extractChildId(URI parentScopeId, Object childJson, String idKeyword)
     SchemaLoader.SchemaLoaderBuilder initChildLoader() {
         SchemaLoader.SchemaLoaderBuilder rval = SchemaLoader.builder()
                 .httpClient(this.config.httpClient)
-                .formatValidators(this.config.formatValidators)
+                .formatValidators(new HashMap<>(this.config.formatValidators))
                 .resolutionScope(id)
                 .schemaJson(schemaJson)
                 .rootSchemaJson(rootSchemaJson)

core/src/main/java/org/everit/json/schema/loader/SchemaLoader.java

@@ -67,7 +67,7 @@ public static class SchemaLoaderBuilder {
 
         List<String> pointerToCurrentObj = emptyList();
 
-        Map<String, FormatValidator> formatValidators;
+        Map<String, FormatValidator> formatValidators = new HashMap<>();
 
         SpecificationVersion specVersion;
 
@@ -122,7 +122,8 @@ public SchemaLoaderBuilder draftV7Support() {
 
         private void setSpecVersion(SpecificationVersion specVersion) {
             this.specVersion = specVersion;
-            this.formatValidators = new HashMap<>(specVersion.defaultFormatValidators());
+            specVersion.defaultFormatValidators().forEach(this::addFormatValidator);
+            //            this.formatValidators = new HashMap<>(specVersion.defaultFormatValidators());
         }
 
         public SchemaLoader build() {

tests/src/test/java/org/everit/json/schema/EvenCharNumValidator.java

@@ -0,0 +1,20 @@
+package org.everit.json.schema;
+
+import java.util.Optional;
+
+public class EvenCharNumValidator implements FormatValidator {
+
+    @Override
+    public Optional<String> validate(final String subject) {
+        if (subject.length() % 2 == 0) {
+            return Optional.empty();
+        } else {
+            return Optional.of(String.format("the length of srtring [%s] is odd", subject));
+        }
+    }
+
+    @Override
+    public String formatName() {
+        return "evenlength";
+    }
+}

tests/src/test/java/org/everit/json/schema/IssueTest.java

@@ -7,10 +7,12 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.UncheckedIOException;
+import java.lang.reflect.Constructor;
 import java.net.URISyntaxException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 
 import org.everit.json.schema.loader.SchemaLoader;
@@ -82,14 +84,37 @@ private Schema loadSchema() {
         try {
             if (schemaFile.isPresent()) {
                 JSONObject schemaObj = fileAsJson(schemaFile.get());
-                return SchemaLoader.load(schemaObj);
+                SchemaLoader.SchemaLoaderBuilder loaderBuilder = SchemaLoader.builder().schemaJson(schemaObj);
+                setupCustomFormatValidators(loaderBuilder);
+                return loaderBuilder.build().load().build();
             }
             throw new RuntimeException(issueDir.getCanonicalPath() + "/schema.json is not found");
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         }
     }
 
+    private void setupCustomFormatValidators(SchemaLoader.SchemaLoaderBuilder loaderBuilder) {
+        fileByName("validator-config.json").map(IssueTest::fileAsJson)
+                .filter(json -> json.has("customFormats"))
+                .map(json -> json.getJSONObject("customFormats"))
+                .ifPresent(customFormatsJson -> customFormatsJson.toMap()
+                        .entrySet()
+                        .forEach(entry -> loaderBuilder
+                                .addFormatValidator(entry.getKey(), this.createFormatValidator(entry))));
+    }
+
+    private FormatValidator createFormatValidator(Map.Entry<String, Object> entry) {
+        String formatClassName = (String) entry.getValue();
+        try {
+            Class<? extends FormatValidator> formatClass = (Class<? extends FormatValidator>) Class.forName(formatClassName);
+            Constructor<? extends FormatValidator> ctor = formatClass.getConstructor();
+            return ctor.newInstance();
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     private void stopJetty() {
         if (servletSupport != null) {
             servletSupport.stop();
@@ -100,16 +125,19 @@ private void stopJetty() {
     public void test() {
         Assume.assumeFalse("issue dir starts with 'x' - ignoring", issueDir.getName().startsWith("x"));
         fileByName("remotes").ifPresent(this::initJetty);
-        Schema schema = loadSchema();
-        fileByName("subject-valid.json").ifPresent(file -> validate(file, schema, true));
-        fileByName("subject-invalid.json").ifPresent(file -> validate(file, schema, false));
-        stopJetty();
+        try {
+            Schema schema = loadSchema();
+            fileByName("subject-valid.json").ifPresent(file -> validate(file, schema, true));
+            fileByName("subject-invalid.json").ifPresent(file -> validate(file, schema, false));
+        } finally {
+            stopJetty();
+        }
     }
 
     private Validator createValidator() {
         Validator.ValidatorBuilder builder = Validator.builder();
         fileByName("validator-config.json").map(file -> fileAsJson(file))
-                .map(json -> json.getBoolean("failEarly"))
+                .map(json -> json.optBoolean("failEarly"))
                 .filter(bool -> Boolean.TRUE.equals(bool))
                 .ifPresent(t -> builder.failEarly());
         return builder.build();

tests/src/test/resources/org/everit/json/schema/issues/issue152/remotes/customformat-schema.json

@@ -0,0 +1,15 @@
+{
+    "$schema": "http://json-schema.org/draft-06/schema#",
+    "properties": {
+        "id": {
+            "format": "evenlength",
+            "maxLength": 10,
+            "minLength": 3,
+            "type": "string"
+        }
+    },
+    "required": [
+        "id"
+    ],
+    "type": "object"
+}

tests/src/test/resources/org/everit/json/schema/issues/issue152/schema.json

@@ -0,0 +1,4 @@
+{
+    "$ref": "http://localhost:1234/customformat-schema.json",
+    "$schema": "http://json-schema.org/draft-06/schema#"
+}

tests/src/test/resources/org/everit/json/schema/issues/issue152/subject-invalid.json

@@ -0,0 +1,3 @@
+{
+    "id": "everitorg"
+}

tests/src/test/resources/org/everit/json/schema/issues/issue152/validator-config.json

@@ -0,0 +1,5 @@
+{
+  "customFormats": {
+    "evenlength": "org.everit.json.schema.EvenCharNumValidator"
+  }
+}