adding hashCode/equals tests to event classes

Author: erosb

core/pom.xml

@@ -191,7 +191,7 @@
         <dependency>
             <groupId>nl.jqno.equalsverifier</groupId>
             <artifactId>equalsverifier</artifactId>
-            <version>2.3.1</version>
+            <version>3.0.3</version>
             <scope>test</scope>
         </dependency>
         <dependency>

core/src/main/java/org/everit/json/schema/event/CombinedSchemaMatchEvent.java

@@ -19,4 +19,8 @@ public CombinedSchemaMatchEvent(CombinedSchema schema, Schema subSchema,
     @Override public boolean equals(Object o) {
         return o instanceof CombinedSchemaMatchEvent && super.equals(o);
     }
+
+    @Override boolean canEqual(Object o) {
+        return o instanceof CombinedSchemaMatchEvent;
+    }
 }

core/src/main/java/org/everit/json/schema/event/CombinedSchemaMismatchEvent.java

@@ -42,4 +42,8 @@ public CombinedSchemaMismatchEvent(CombinedSchema schema, Schema subSchema, Obje
     @Override public int hashCode() {
         return Objects.hash(super.hashCode(), failure);
     }
+
+    @Override boolean canEqual(Object o) {
+        return o instanceof CombinedSchemaMismatchEvent;
+    }
 }

core/src/main/java/org/everit/json/schema/event/ConditionalSchemaMatchEvent.java

@@ -15,7 +15,10 @@ public ConditionalSchemaMatchEvent(ConditionalSchema schema, Object instance, Ke
     }
 
     @Override public boolean equals(Object o) {
-        return o instanceof ConditionalSchemaMatchEvent && super.equals(o);
+        return canEqual(o) && super.equals(o);
     }
 
+    @Override boolean canEqual(Object o) {
+        return o instanceof ConditionalSchemaMatchEvent;
+    }
 }

core/src/main/java/org/everit/json/schema/event/ConditionalSchemaMismatchEvent.java

@@ -28,14 +28,18 @@ public ConditionalSchemaMismatchEvent(ConditionalSchema schema, Object instance,
     @Override public boolean equals(Object o) {
         if (this == o)
             return true;
-        if (!(o instanceof ConditionalSchemaMismatchEvent))
+        if (!canEqual(o))
             return false;
         if (!super.equals(o))
             return false;
         ConditionalSchemaMismatchEvent that = (ConditionalSchemaMismatchEvent) o;
         return failure.equals(that.failure);
     }
 
+    @Override boolean canEqual(Object o) {
+        return o instanceof ConditionalSchemaMismatchEvent;
+    }
+
     @Override public int hashCode() {
         return Objects.hash(super.hashCode(), failure);
     }

core/src/main/java/org/everit/json/schema/event/SchemaReferencedEvent.java

@@ -27,8 +27,9 @@ public Schema getReferredSchema() {
     @Override public boolean equals(Object o) {
         if (this == o)
             return true;
-        if (!(o instanceof SchemaReferencedEvent))
+        if (!canEqual(o)) {
             return false;
+        }
         if (!super.equals(o))
             return false;
         SchemaReferencedEvent that = (SchemaReferencedEvent) o;
@@ -38,4 +39,8 @@ public Schema getReferredSchema() {
     @Override public int hashCode() {
         return Objects.hash(super.hashCode(), referredSchema);
     }
+
+    @Override boolean canEqual(Object o) {
+        return o instanceof SchemaReferencedEvent;
+    }
 }

core/src/main/java/org/everit/json/schema/event/ValidationEvent.java

@@ -23,13 +23,22 @@ public S getSchema() {
     @Override public boolean equals(Object o) {
         if (this == o)
             return true;
-        if (o == null || getClass() != o.getClass())
+        if (o == null)
+            return false;
+        if (!canEqual(o))
             return false;
         ValidationEvent<?> that = (ValidationEvent<?>) o;
+        if (!that.canEqual(this)) {
+            return false;
+        }
         return schema.equals(that.schema) &&
                 instance.equals(that.instance);
     }
 
+    boolean canEqual(Object o) {
+        return o instanceof ValidationEvent;
+    }
+
     @Override public int hashCode() {
         return Objects.hash(schema, instance);
     }

core/src/test/java/org/everit/json/schema/event/CombinedSchemaMatchEventTest.java

@@ -0,0 +1,19 @@
+package org.everit.json.schema.event;
+
+import org.junit.Test;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
+public class CombinedSchemaMatchEventTest {
+
+    @Test
+    public void equalsVerifier() {
+        EqualsVerifier.forClass(CombinedSchemaMatchEvent.class)
+                .withNonnullFields("subSchema", "schema", "instance")
+                .withRedefinedSuperclass()
+                .suppress(Warning.STRICT_INHERITANCE)
+                .verify();
+    }
+
+}

core/src/test/java/org/everit/json/schema/event/CombinedSchemaMismatchEventTest.java

@@ -0,0 +1,25 @@
+package org.everit.json.schema.event;
+
+import org.everit.json.schema.FalseSchema;
+import org.everit.json.schema.TrueSchema;
+import org.everit.json.schema.ValidationException;
+import org.junit.Test;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
+public class CombinedSchemaMismatchEventTest {
+
+    @Test
+    public void equalsVerifier() {
+        ValidationException exc1 = new ValidationException(TrueSchema.INSTANCE, "message", "keyword", "#/location");
+        ValidationException exc2 = new ValidationException(FalseSchema.INSTANCE, "message", "keyword", "#/loca/tion");
+        EqualsVerifier.forClass(CombinedSchemaMismatchEvent.class)
+                .withNonnullFields("subSchema", "schema", "instance", "failure")
+                .withRedefinedSuperclass()
+                .withPrefabValues(ValidationException.class, exc1, exc2)
+                .suppress(Warning.STRICT_INHERITANCE)
+                .verify();
+    }
+
+}

core/src/test/java/org/everit/json/schema/event/ConditionalSchemaMatchEventTest.java

@@ -0,0 +1,19 @@
+package org.everit.json.schema.event;
+
+import org.junit.Test;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
+public class ConditionalSchemaMatchEventTest {
+
+    @Test
+    public void equalsVerifier() {
+        EqualsVerifier.forClass(ConditionalSchemaMatchEvent.class)
+                .withNonnullFields("keyword", "schema", "instance")
+                .withRedefinedSuperclass()
+                .suppress(Warning.STRICT_INHERITANCE)
+                .verify();
+    }
+
+}