adding hashCode() and equals() to Regexp implementations

Author: erosb

core/src/main/java/org/everit/json/schema/regexp/JavaUtilRegexpFactory.java

@@ -1,5 +1,6 @@
 package org.everit.json.schema.regexp;
 
+import java.util.Objects;
 import java.util.Optional;
 import java.util.regex.Pattern;
 
@@ -20,6 +21,18 @@ class JavaUtilRegexp extends AbstractRegexp {
         }
     }
 
+    @Override public boolean equals(Object o) {
+        if (this == o)
+            return true;
+        if (!(o instanceof JavaUtilRegexp))
+            return false;
+        JavaUtilRegexp that = (JavaUtilRegexp) o;
+        return Objects.equals(pattern, that.pattern);
+    }
+
+    @Override public int hashCode() {
+        return Objects.hash(pattern);
+    }
 }
 
 public class JavaUtilRegexpFactory implements RegexpFactory {

core/src/main/java/org/everit/json/schema/regexp/RE2JRegexpFactory.java

@@ -1,12 +1,13 @@
 package org.everit.json.schema.regexp;
 
+import java.util.Objects;
 import java.util.Optional;
 
 import com.google.re2j.Pattern;
 
 class RE2JRegexp extends AbstractRegexp {
 
-    private Pattern pattern;
+    private final Pattern pattern;
 
     RE2JRegexp(String pattern) {
         super(pattern);
@@ -21,6 +22,18 @@ class RE2JRegexp extends AbstractRegexp {
         }
     }
 
+    @Override public boolean equals(Object o) {
+        if (this == o)
+            return true;
+        if (!(o instanceof RE2JRegexp))
+            return false;
+        RE2JRegexp that = (RE2JRegexp) o;
+        return Objects.equals(pattern, that.pattern);
+    }
+
+    @Override public int hashCode() {
+        return Objects.hash(pattern);
+    }
 }
 
 public class RE2JRegexpFactory implements RegexpFactory {

core/src/test/java/org/everit/json/schema/regexp/JavaUtilRegexpTest.java

@@ -7,6 +7,11 @@
 
 import org.junit.Test;
 
+import java.util.regex.Pattern;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
 public class JavaUtilRegexpTest {
 
     static final String PATTERN = "^aa.*b$";
@@ -30,4 +35,13 @@ public void asString() {
         assertEquals(PATTERN, createHandler().toString());
     }
 
+    @Test
+    public void equalsVerifier() {
+        EqualsVerifier.forClass(JavaUtilRegexp.class)
+            .withPrefabValues(Pattern.class, Pattern.compile("red"), Pattern.compile("black"))
+            .withIgnoredFields("asString")
+            .suppress(Warning.STRICT_INHERITANCE)
+            .verify();
+    }
+
 }

core/src/test/java/org/everit/json/schema/regexp/RE2JRegexpTest.java

@@ -7,6 +7,11 @@
 
 import org.junit.Test;
 
+import com.google.re2j.Pattern;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
+
 public class RE2JRegexpTest {
 
     static final String PATTERN = "^aa.*b$";
@@ -30,4 +35,13 @@ public void asString() {
         assertEquals(PATTERN, createHandler().toString());
     }
 
+    @Test
+    public void equalsVerifier() {
+        EqualsVerifier.forClass(RE2JRegexp.class)
+            .withPrefabValues(Pattern.class, Pattern.compile("red"), Pattern.compile("black"))
+            .withIgnoredFields("asString")
+            .suppress(Warning.STRICT_INHERITANCE)
+            .verify();
+    }
+
 }