Ruff E402: imports must be at top of file

evertlammerts · evertlammerts · commit 00888157e7a4 · 2025-09-11T12:33:34.000+02:00
diff --git a/duckdb/__init__.py b/duckdb/__init__.py
@@ -1,4 +1,4 @@
-# ruff: noqa: D104, F401
+# ruff: noqa: D104, F401, E402
 from importlib.metadata import version
 
 from _duckdb import __version__ as duckdb_version
diff --git a/scripts/generate_import_cache_cpp.py b/scripts/generate_import_cache_cpp.py
@@ -1,7 +1,7 @@
 import os
+import json
 
 script_dir = os.path.dirname(__file__)
-import json
 
 # Load existing JSON data from a file if it exists
 json_data = {}
diff --git a/scripts/generate_import_cache_json.py b/scripts/generate_import_cache_json.py
@@ -1,9 +1,9 @@
 import os
-
-script_dir = os.path.dirname(__file__)
 import json
 from typing import Union
 
+script_dir = os.path.dirname(__file__)
+
 lines: list[str] = [file for file in open(f"{script_dir}/imports.py").read().split("\n") if file != ""]
 
 
diff --git a/scripts/imports.py b/scripts/imports.py
@@ -1,3 +1,4 @@
+# ruff: noqa: E402
 import pyarrow
 import pyarrow.dataset
 
diff --git a/tests/fast/api/test_native_tz.py b/tests/fast/api/test_native_tz.py
@@ -4,10 +4,10 @@
 import pytest
 
 import duckdb
+from packaging.version import Version
 
 pd = pytest.importorskip("pandas")
 pa = pytest.importorskip("pyarrow")
-from packaging.version import Version
 
 filename = os.path.join(os.path.dirname(os.path.realpath(__file__)), "..", "data", "tz.parquet")
 
diff --git a/tests/fast/arrow/test_14344.py b/tests/fast/arrow/test_14344.py
@@ -1,7 +1,7 @@
 import pytest
+import hashlib
 
 pa = pytest.importorskip("pyarrow")
-import hashlib
 
 
 def test_14344(duckdb_cursor):
diff --git a/tests/fast/arrow/test_9443.py b/tests/fast/arrow/test_9443.py
@@ -1,11 +1,10 @@
 import pytest
 
-pq = pytest.importorskip("pyarrow.parquet")
-pa = pytest.importorskip("pyarrow")
-
 from datetime import time
 from pathlib import PurePosixPath
 
+pq = pytest.importorskip("pyarrow.parquet")
+pa = pytest.importorskip("pyarrow")
 
 class Test9443:
     def test_9443(self, tmp_path, duckdb_cursor):
diff --git a/tests/fast/arrow/test_buffer_size_option.py b/tests/fast/arrow/test_buffer_size_option.py
@@ -2,9 +2,9 @@
 
 import duckdb
 
-pa = pytest.importorskip("pyarrow")
 from duckdb.typing import VARCHAR
 
+pa = pytest.importorskip("pyarrow")
 
 class TestArrowBufferSize:
     def test_arrow_buffer_size(self):
diff --git a/tests/fast/arrow/test_dictionary_arrow.py b/tests/fast/arrow/test_dictionary_arrow.py
@@ -1,11 +1,11 @@
 import pytest
+import datetime
 
 pa = pytest.importorskip("pyarrow")
 pq = pytest.importorskip("pyarrow.parquet")
 ds = pytest.importorskip("pyarrow.dataset")
 np = pytest.importorskip("numpy")
 pd = pytest.importorskip("pandas")
-import datetime
 
 Timestamp = pd.Timestamp
 
diff --git a/tests/fast/arrow/test_polars.py b/tests/fast/arrow/test_polars.py
@@ -8,7 +8,7 @@
 arrow = pytest.importorskip("pyarrow")
 pl_testing = pytest.importorskip("polars.testing")
 
-from duckdb.polars_io import _predicate_to_expression
+from duckdb.polars_io import _predicate_to_expression  # noqa: E402
 
 
 def valid_filter(filter):
diff --git a/tests/fast/pandas/test_copy_on_write.py b/tests/fast/pandas/test_copy_on_write.py
@@ -1,10 +1,10 @@
+import datetime
 import pytest
 
 import duckdb
 
 # https://pandas.pydata.org/docs/dev/user_guide/copy_on_write.html
 pandas = pytest.importorskip("pandas", "1.5", reason="copy_on_write does not exist in earlier versions")
-import datetime
 
 
 # Make sure the variable get's properly reset even in case of error
diff --git a/tests/fast/pandas/test_fetch_nested.py b/tests/fast/pandas/test_fetch_nested.py
@@ -1,9 +1,8 @@
 import pytest
-
+import numpy as np
 import duckdb
 
 pd = pytest.importorskip("pandas")
-import numpy as np
 
 
 def compare_results(con, query, expected):
diff --git a/tests/fast/pandas/test_pandas_arrow.py b/tests/fast/pandas/test_pandas_arrow.py
@@ -3,11 +3,12 @@
 import pytest
 from conftest import pandas_supports_arrow_backend
 
+import numpy as np
 import duckdb
 
 pd = pytest.importorskip("pandas", "2.0.0")
-import numpy as np
-from pandas.api.types import is_integer_dtype
+
+from pandas.api.types import is_integer_dtype  # noqa: E402
 
 
 @pytest.mark.skipif(not pandas_supports_arrow_backend(), reason="pandas does not support the 'pyarrow' backend")
diff --git a/tests/fast/spark/test_spark_to_csv.py b/tests/fast/spark/test_spark_to_csv.py
@@ -1,8 +1,14 @@
 import os
+import csv
+import datetime
 
 import pytest
 
-_ = pytest.importorskip("duckdb.experimental.spark")
+from conftest import ArrowPandas, NumpyPandas, getTimeSeriesData
+
+from duckdb import InvalidInputException, read_csv
+
+
 
 from spark_namespace import USE_ACTUAL_SPARK
 
@@ -14,13 +20,8 @@
         allow_module_level=True,
     )
 
-import csv
-import datetime
-
-from conftest import ArrowPandas, NumpyPandas, getTimeSeriesData
-from spark_namespace import USE_ACTUAL_SPARK
+pytest.importorskip("duckdb.experimental.spark")
 
-from duckdb import InvalidInputException, read_csv
 
 
 @pytest.fixture
diff --git a/tests/fast/test_pypi_cleanup.py b/tests/fast/test_pypi_cleanup.py
@@ -13,7 +13,7 @@
 
 duckdb_packaging = pytest.importorskip("duckdb_packaging")
 
-from duckdb_packaging.pypi_cleanup import (
+from duckdb_packaging.pypi_cleanup import (  # noqa: E402
     AuthenticationError,
     CsrfParser,
     PyPICleanup,
diff --git a/tests/fast/test_versioning.py b/tests/fast/test_versioning.py
@@ -9,15 +9,15 @@
 
 duckdb_packaging = pytest.importorskip("duckdb_packaging")
 
-from duckdb_packaging._versioning import (
+from duckdb_packaging._versioning import (  # noqa: E402
     format_version,
     get_current_version,
     get_git_describe,
     git_tag_to_pep440,
     parse_version,
     pep440_to_git_tag,
 )
-from duckdb_packaging.setuptools_scm_version import _bump_version, forced_version_from_env, version_scheme
+from duckdb_packaging.setuptools_scm_version import _bump_version, forced_version_from_env, version_scheme  # noqa: E402
 
 
 class TestVersionParsing(unittest.TestCase):
diff --git a/tests/fast/udf/test_null_filtering.py b/tests/fast/udf/test_null_filtering.py
@@ -1,9 +1,6 @@
 import pytest
 
 import duckdb
-
-pd = pytest.importorskip("pandas")
-pa = pytest.importorskip("pyarrow", "18.0.0")
 import datetime
 import uuid
 from typing import Any, NamedTuple
@@ -29,6 +26,10 @@
     VARCHAR,
 )
 
+pd = pytest.importorskip("pandas")
+pa = pytest.importorskip("pyarrow", "18.0.0")
+
+
 
 class Candidate(NamedTuple):
     type: duckdb.typing.DuckDBPyType
diff --git a/tests/fast/udf/test_remove_function.py b/tests/fast/udf/test_remove_function.py
@@ -1,12 +1,11 @@
 import pytest
 
 import duckdb
+from duckdb.typing import BIGINT, VARCHAR
 
 pd = pytest.importorskip("pandas")
 pa = pytest.importorskip("pyarrow")
 
-from duckdb.typing import BIGINT, VARCHAR
-
 
 class TestRemoveFunction:
     def test_not_created(self):
diff --git a/tests/fast/udf/test_scalar.py b/tests/fast/udf/test_scalar.py
@@ -2,8 +2,6 @@
 
 import duckdb
 
-pd = pytest.importorskip("pandas")
-pa = pytest.importorskip("pyarrow", "18.0.0")
 import cmath
 import datetime
 import uuid
@@ -34,6 +32,9 @@
     VARCHAR,
 )
 
+pd = pytest.importorskip("pandas")
+pa = pytest.importorskip("pyarrow", "18.0.0")
+
 
 def make_annotated_function(type):
     # Create a function that returns its input
diff --git a/tests/fast/udf/test_scalar_arrow.py b/tests/fast/udf/test_scalar_arrow.py
@@ -1,12 +1,11 @@
 import pytest
 
 import duckdb
+from duckdb.typing import BIGINT, INTEGER, VARCHAR
 
 pd = pytest.importorskip("pandas")
 pa = pytest.importorskip("pyarrow")
 
-from duckdb.typing import BIGINT, INTEGER, VARCHAR
-
 
 class TestPyArrowUDF:
     def test_basic_use(self):

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# ruff: noqa: D104, F401`
	`1`	`+# ruff: noqa: D104, F401, E402`
`2`	`2`	`from importlib.metadata import version`
`3`	`3`
`4`	`4`	`from _duckdb import __version__ as duckdb_version`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+# ruff: noqa: E402`
`1`	`2`	`import pyarrow`
`2`	`3`	`import pyarrow.dataset`
`3`	`4`