Ruff PT012: pytest.raises contextmanagers should only have a single statement

Author: evertlammerts

tests/conftest.py

@@ -274,35 +274,3 @@ def timestamps(duckdb_cursor):
     cursor.execute("INSERT INTO timestamps VALUES ('1992-10-03 18:34:45'), ('2010-01-01 00:00:01'), (NULL)")
     yield
     cursor.execute("drop table timestamps")
-
-
-@pytest.fixture
-def duckdb_cursor_autocommit(request, tmp_path):
-    test_dbfarm = tmp_path.resolve().as_posix()
-
-    def finalizer() -> None:
-        duckdb.shutdown()
-        if tmp_path.is_dir():
-            shutil.rmtree(test_dbfarm)
-
-    request.addfinalizer(finalizer)
-
-    connection = duckdb.connect(test_dbfarm)
-    connection.set_autocommit(True)
-    cursor = connection.cursor()
-    return (cursor, connection, test_dbfarm)
-
-
-@pytest.fixture
-def initialize_duckdb(request, tmp_path):
-    test_dbfarm = tmp_path.resolve().as_posix()
-
-    def finalizer() -> None:
-        duckdb.shutdown()
-        if tmp_path.is_dir():
-            shutil.rmtree(test_dbfarm)
-
-    request.addfinalizer(finalizer)
-
-    duckdb.connect(test_dbfarm)
-    return test_dbfarm

tests/extensions/test_extensions_loading.py

@@ -27,14 +27,14 @@ def test_install_non_existent_extension():
     with pytest.raises(duckdb.IOException) as exc:
         conn.install_extension("non-existent")
 
-        if not isinstance(exc, duckdb.HTTPException):
-            pytest.skip(reason="This test does not throw an HTTPException, only an IOException")
-        value = exc.value
-
-        assert value.status_code == 404
-        assert value.reason == "Not Found"
-        assert "Example Domain" in value.body
-        assert "Content-Length" in value.headers
+    if not isinstance(exc, duckdb.HTTPException):
+        pytest.skip(reason="This test does not throw an HTTPException, only an IOException")
+    value = exc.value
+
+    assert value.status_code == 404
+    assert value.reason == "Not Found"
+    assert "Example Domain" in value.body
+    assert "Content-Length" in value.headers
 
 
 def test_install_misuse_errors(duckdb_cursor):

tests/fast/api/test_connection_close.py

@@ -27,11 +27,11 @@ def test_connection_close(self, duckdb_cursor):
         check_exception(lambda: cursor.execute("select * from a"))
 
     def test_open_and_exit(self):
-        with pytest.raises(TypeError), duckdb.connect() as connection:
-            connection.execute("select 42")
-            # This exception does not get swallowed by __exit__
+        with pytest.raises(TypeError), duckdb.connect():
+            # This exception does not get swallowed by DuckDBPyConnection's __exit__
             raise TypeError()
 
+
     def test_reopen_connection(self, duckdb_cursor):
         with tempfile.NamedTemporaryFile(delete=False) as tmp:
             db = tmp.name

tests/fast/api/test_read_csv.py

@@ -491,15 +491,14 @@ def test_read_csv_names(self, tmp_path):
         assert rel.columns == ["a", "b", "c", "four"]
 
         with pytest.raises(duckdb.InvalidInputException, match="read_csv only accepts 'names' as a list of strings"):
-            rel = con.read_csv(file, names=True)
+            con.read_csv(file, names=True)
 
         with pytest.raises(duckdb.InvalidInputException, match="not possible to detect the CSV Header"):
-            rel = con.read_csv(file, names=["a", "b", "c", "d", "e"])
+            con.read_csv(file, names=["a", "b", "c", "d", "e"])
 
         # Duplicates are not okay
         with pytest.raises(duckdb.BinderException, match="names must have unique values"):
-            rel = con.read_csv(file, names=["a", "b", "a", "b"])
-            assert rel.columns == ["a", "b", "a", "b"]
+            con.read_csv(file, names=["a", "b", "a", "b"])
 
     def test_read_csv_names_mixed_with_dtypes(self, tmp_path):
         file = tmp_path / "file.csv"
@@ -565,8 +564,7 @@ def test_read_csv_empty_list(self):
         with pytest.raises(
             duckdb.InvalidInputException, match="Please provide a non-empty list of paths or file-like objects"
         ):
-            rel = con.read_csv(files)
-            rel.fetchall()
+            con.read_csv(files)
 
     def test_read_auto_detect(self, tmp_path):
         file1 = tmp_path / "file1.csv"
@@ -587,8 +585,7 @@ def test_read_csv_list_invalid_path(self, tmp_path):
 
         files = [str(file1), "not_valid_path", str(file3)]
         with pytest.raises(duckdb.IOException, match='No files found that match the pattern "not_valid_path"'):
-            rel = con.read_csv(files)
-            rel.fetchall()
+            con.read_csv(files)
 
     @pytest.mark.parametrize(
         "options",
@@ -672,15 +669,16 @@ def test_strict_mode(self, tmp_path):
         file1.write_text("one|two|three|four\n1|2|3|4\n1|2|3|4|5\n1|2|3|4\n")
 
         con = duckdb.connect()
+        rel = con.read_csv(
+            str(file1),
+            header=True,
+            delimiter="|",
+            columns={"a": "INTEGER", "b": "INTEGER", "c": "INTEGER", "d": "INTEGER"},
+            auto_detect=False,
+        )
         with pytest.raises(duckdb.InvalidInputException, match="CSV Error on Line"):
-            rel = con.read_csv(
-                str(file1),
-                header=True,
-                delimiter="|",
-                columns={"a": "INTEGER", "b": "INTEGER", "c": "INTEGER", "d": "INTEGER"},
-                auto_detect=False,
-            )
             rel.fetchall()
+
         rel = con.read_csv(
             str(file1),
             header=True,
@@ -734,8 +732,8 @@ def test_files_to_sniff_option(self, tmp_path):
 
         file_path = tmp_path / "file*.csv"
         con = duckdb.connect()
+        rel = con.read_csv(file_path, files_to_sniff=1)
         with pytest.raises(duckdb.ConversionException, match="Conversion Error"):
-            rel = con.read_csv(file_path, files_to_sniff=1)
             rel.fetchall()
         rel = con.read_csv(file_path, files_to_sniff=-1)
         assert rel.fetchall() == [("2025-05-12", "baz"), ("bar", "baz")]

tests/fast/api/test_streaming_result.py

@@ -18,10 +18,7 @@ def test_fetch_one(self, duckdb_cursor):
             "SELECT CASE WHEN i < 10000 THEN i ELSE concat('hello', i::VARCHAR)::INT END FROM range(100000) t(i)"
         )
         with pytest.raises(duckdb.ConversionException):
-            while True:
-                tpl = res.fetchone()
-                if tpl is None:
-                    break
+            res.fetchone()
 
     def test_fetch_many(self, duckdb_cursor):
         # fetch many
@@ -37,10 +34,7 @@ def test_fetch_many(self, duckdb_cursor):
             "SELECT CASE WHEN i < 10000 THEN i ELSE concat('hello', i::VARCHAR)::INT END FROM range(100000) t(i)"
         )
         with pytest.raises(duckdb.ConversionException):
-            while True:
-                tpl = res.fetchmany(10)
-                if tpl is None:
-                    break
+            res.fetchmany(10)
 
     def test_record_batch_reader(self, duckdb_cursor):
         pytest.importorskip("pyarrow")

tests/fast/api/test_with_propagating_exceptions.py

@@ -7,12 +7,8 @@ class TestWithPropagatingExceptions:
     def test_with(self):
         # Should propagate exception raised in the 'with duckdb.connect() ..'
         with pytest.raises(duckdb.ParserException, match="syntax error at or near *"), duckdb.connect() as con:
-            print("before")
             con.execute("invalid")
-            print("after")
 
         # Does not raise an exception
         with duckdb.connect() as con:
-            print("before")
             con.execute("select 1")
-            print("after")

tests/fast/arrow/test_arrow_fetch_recordbatch.py

@@ -252,9 +252,7 @@ def test_record_batch_query_error(self):
         duckdb_cursor.execute("CREATE table t as select 'foo' as a;")
         with pytest.raises(duckdb.ConversionException, match="Conversion Error"):
             # 'execute' materializes the result, causing the error directly
-            query = duckdb_cursor.execute("SELECT cast(a as double) FROM t")
-            record_batch_reader = query.fetch_record_batch(1024)
-            record_batch_reader.read_next_batch()
+            duckdb_cursor.execute("SELECT cast(a as double) FROM t")
 
     def test_many_list_batches(self):
         conn = duckdb.connect()

tests/fast/arrow/test_arrow_types.py

@@ -43,6 +43,3 @@ def test_invalid_union(self, duckdb_cursor):
             match="Attempted to convert a UNION with no fields to DuckDB which is not supported",
         ):
             duckdb_cursor.register("invalid_union", arrow_table)
-
-            res = duckdb_cursor.sql("select * from invalid_union").fetchall()
-            print(res)

tests/fast/arrow/test_timestamp_timezone.py

@@ -33,8 +33,8 @@ def test_timestamp_timezone_overflow(self, duckdb_cursor):
         precisions = ["s", "ms"]
         current_time = 9223372036854775807
         for precision in precisions:
+            arrow_table = generate_table(current_time, precision, "UTC")
             with pytest.raises(duckdb.ConversionException, match="Could not convert"):
-                arrow_table = generate_table(current_time, precision, "UTC")
                 duckdb.from_arrow(arrow_table).execute().fetchall()
 
     def test_timestamp_tz_to_arrow(self, duckdb_cursor):

tests/fast/pandas/test_df_object_resolution.py

@@ -418,7 +418,6 @@ def test_structs_of_different_sizes(self, pandas, duckdb_cursor):
             ),
         ):
             res = duckdb_cursor.execute("select $1", [malformed_struct])
-            print(res)
 
     @pytest.mark.parametrize("pandas", [NumpyPandas(), ArrowPandas()])
     def test_struct_key_conversion(self, pandas, duckdb_cursor):