xfail adbc tests on windows

Author: evertlammerts

pyproject.toml

@@ -225,7 +225,7 @@ stubdeps = [ # dependencies used for typehints in the stubs
     "pyarrow",
 ]
 test = [ # dependencies used for running tests
-    "adbc-driver-manager<1.8.0",
+    "adbc-driver-manager",
     "pytest",
     "pytest-reraise",
     "pytest-timeout",

tests/fast/adbc/test_adbc.py

@@ -1,4 +1,5 @@
 import datetime
+import sys
 from pathlib import Path
 
 import adbc_driver_manager.dbapi
@@ -8,6 +9,7 @@
 
 import adbc_driver_duckdb.dbapi
 
+xfail = pytest.mark.xfail
 driver_path = adbc_driver_duckdb.driver_path()
 
 
@@ -27,6 +29,7 @@ def example_table():
     )
 
 
+@xfail(sys.platform == "win32", reason="adbc-driver-manager.adbc_get_info() returns an empty dict on windows")
 def test_connection_get_info(duck_conn):
     assert duck_conn.adbc_get_info() != {}
 
@@ -39,6 +42,9 @@ def test_connection_get_table_types(duck_conn):
     assert duck_conn.adbc_get_table_types() == ["BASE TABLE"]
 
 
+@xfail(
+    sys.platform == "win32", reason="adbc-driver-manager.adbc_get_objects() returns an invalid schema dict on windows"
+)
 def test_connection_get_objects(duck_conn):
     with duck_conn.cursor() as cursor:
         cursor.execute("CREATE TABLE getobjects (ints BIGINT PRIMARY KEY)")
@@ -60,6 +66,9 @@ def test_connection_get_objects(duck_conn):
     assert depth_all.schema == depth_catalogs.schema
 
 
+@xfail(
+    sys.platform == "win32", reason="adbc-driver-manager.adbc_get_objects() returns an invalid schema dict on windows"
+)
 def test_connection_get_objects_filters(duck_conn):
     with duck_conn.cursor() as cursor:
         cursor.execute("CREATE TABLE getobjects (ints BIGINT PRIMARY KEY)")
@@ -198,6 +207,7 @@ def test_statement_query(duck_conn):
         assert cursor.fetch_arrow_table().to_pylist() == [{"foo": 1}]
 
 
+@xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
 def test_insertion(duck_conn):
     table = example_table()
     reader = table.to_reader()
@@ -224,6 +234,7 @@ def test_insertion(duck_conn):
         assert cursor.fetch_arrow_table().to_pydict() == {"count_star()": [8]}
 
 
+@xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
 def test_read(duck_conn):
     with duck_conn.cursor() as cursor:
         filename = Path(__file__).parent / ".." / "data" / "category.csv"

tests/fast/adbc/test_statement_bind.py

@@ -1,9 +1,13 @@
+import sys
+
 import adbc_driver_manager
 import pyarrow as pa
 import pytest
 
 import adbc_driver_duckdb.dbapi
 
+xfail = pytest.mark.xfail
+
 
 def _import(handle):
     """Helper to import a C Data Interface handle."""
@@ -72,6 +76,7 @@ def test_bind_single_row(self):
             result_values = result.chunk(0)
             assert result_values == expected_result
 
+    @xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
     def test_multiple_parameters(self):
         int_data = pa.array([5])
         varchar_data = pa.array(["not a short string"])
@@ -163,6 +168,7 @@ def test_too_many_parameters(self):
             ):
                 statement.execute_query()
 
+    @xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
     def test_not_enough_parameters(self):
         data = pa.record_batch(
             [["not a short string"]],