Making tests pass

Author: evertlammerts

tests/conftest.py

@@ -3,7 +3,7 @@
 import warnings
 from importlib import import_module
 from pathlib import Path
-from typing import Any
+from typing import Any, Union
 
 import pytest
 
@@ -188,7 +188,7 @@ def __getattr__(self, name: str) -> Any:  # noqa: ANN401
 
 @pytest.fixture
 def require():
-    def _require(extension_name, db_name="") -> duckdb.DuckDBPyConnection | None:
+    def _require(extension_name, db_name="") -> Union[duckdb.DuckDBPyConnection, None]:
         # Paths to search for extensions
 
         build = Path(__file__).parent.parent / "build"

tests/fast/api/test_connection_close.py

@@ -17,7 +17,7 @@ def check_exception(f):
 
 class TestConnectionClose:
     def test_connection_close(self, duckdb_cursor):
-        with tempfile.NamedTemporaryFile(delete=False) as tmp:
+        with tempfile.NamedTemporaryFile() as tmp:
             db = tmp.name
         con = duckdb.connect(db)
         cursor = con.cursor()
@@ -32,7 +32,7 @@ def test_open_and_exit(self):
             raise TypeError()
 
     def test_reopen_connection(self, duckdb_cursor):
-        with tempfile.NamedTemporaryFile(delete=False) as tmp:
+        with tempfile.NamedTemporaryFile() as tmp:
             db = tmp.name
         con = duckdb.connect(db)
         cursor = con.cursor()

tests/fast/api/test_dbapi11.py

@@ -16,7 +16,7 @@ def check_exception(f):
 
 class TestReadOnly:
     def test_readonly(self, duckdb_cursor):
-        with tempfile.NamedTemporaryFile(delete=False) as tmp:
+        with tempfile.NamedTemporaryFile() as tmp:
             db = tmp.name
 
         # this is forbidden

tests/fast/arrow/test_12384.py

@@ -9,7 +9,7 @@
 
 def test_10795():
     arrow_filename = Path(__file__).parent / "data" / "arrow_table"
-    with pa.memory_map(arrow_filename, "r") as source:
+    with pa.memory_map(str(arrow_filename), "r") as source:
         reader = pa.ipc.RecordBatchFileReader(source)
         taxi_fhvhv_arrow = reader.read_all()
         con = duckdb.connect(database=":memory:")

tests/fast/arrow/test_unregister.py

@@ -6,19 +6,11 @@
 
 import duckdb
 
-try:
-    import pyarrow
-    import pyarrow.parquet
-
-    can_run = True
-except Exception:
-    can_run = False
-
+pyarrow = pytest.importorskip("pyarrow")
+pytest.importorskip("pyarrow.parquet")
 
 class TestArrowUnregister:
     def test_arrow_unregister1(self, duckdb_cursor):
-        if not can_run:
-            return
         parquet_filename = str(Path(__file__).parent / "data" / "userdata1.parquet")
         arrow_table_obj = pyarrow.parquet.read_table(parquet_filename)
         connection = duckdb.connect(":memory:")
@@ -33,11 +25,8 @@ def test_arrow_unregister1(self, duckdb_cursor):
         connection.execute("DROP VIEW IF EXISTS arrow_table;")
 
     def test_arrow_unregister2(self, duckdb_cursor):
-        if not can_run:
-            return
-        fd, db = tempfile.mkstemp()
-        os.close(fd)
-        os.remove(db)
+        with tempfile.NamedTemporaryFile() as tmp:
+            db = tmp.name
 
         connection = duckdb.connect(db)
         parquet_filename = str(Path(__file__).parent / "data" / "userdata1.parquet")

tests/fast/pandas/test_pandas_unregister.py

@@ -24,7 +24,7 @@ def test_pandas_unregister1(self, duckdb_cursor, pandas):
 
     @pytest.mark.parametrize("pandas", [NumpyPandas(), ArrowPandas()])
     def test_pandas_unregister2(self, duckdb_cursor, pandas):
-        with tempfile.NamedTemporaryFile(delete=False) as tmp:
+        with tempfile.NamedTemporaryFile() as tmp:
             db = tmp.name
 
         connection = duckdb.connect(db)

tests/fast/relational_api/test_rapi_description.py

@@ -1,3 +1,4 @@
+import duckdb
 import pytest
 
 

tests/fast/spark/test_spark_filter.py

@@ -99,7 +99,7 @@ def test_dataframe_filter(self, spark):
             assert item.state != "OH"
             assert item.state != "NY"
 
-        df2 = df.filter(not df.state.isin(li))
+        df2 = df.filter(df.state.isin(li) == False)  # noqa: E712
         res2 = df2.collect()
         assert res2 == res
 

tests/fast/udf/test_remove_function.py

@@ -57,7 +57,8 @@ def func(x: str) -> str:
 
         with pytest.raises(duckdb.BinderException, match="No function matches the given name"):
             con.sql("select func(42)")
-        con.sql("select func('test'::VARCHAR)")
+
+        rel2 = con.sql("select func('test'::VARCHAR)")
         con.remove_function("func")
 
         def also_func(x: int) -> int: