Ruff F841: fixes and noqa for unused variables

Author: evertlammerts

duckdb/experimental/spark/sql/column.py

@@ -12,7 +12,7 @@
 __all__ = ["Column"]
 
 
-def _get_expr(x: "Column" | str) -> Expression:
+def _get_expr(x: Union["Column", str]) -> Expression:
     return x.expr if isinstance(x, Column) else ConstantExpression(x)
 
 

scripts/get_cpp_methods.py

@@ -62,8 +62,6 @@ def get_methods(class_name: str) -> dict[str, ConnectionMethod]:
         ),
         "DuckDBPyRelation": os.path.join(scripts_folder, "..", "src", "include", "duckdb_python", "pyrelation.hpp"),
     }
-    # Create a dictionary to store method names and prototypes
-    methods_dict = {}
 
     path = CLASSES[class_name]
 

tests/coverage/test_pandas_categorical_coverage.py

@@ -23,7 +23,7 @@ def check_create_table(category, pandas):
 
     category.append("bla")
 
-    df_in_diff = pandas.DataFrame(
+    df_in_diff = pandas.DataFrame(  # noqa: F841
         {
             "k": pandas.Categorical(category, ordered=True),
         }

tests/extensions/json/test_read_json.py

@@ -122,4 +122,4 @@ def test_read_json_options(self, duckdb_cursor, option):
                 rel = duckdb_cursor.read_json(TestFile("example.json"), **keyword_arguments)
         else:
             rel = duckdb_cursor.read_json(TestFile("example.json"), **keyword_arguments)
-            res = rel.fetchall()
+            rel.fetchall()

tests/fast/api/test_3324.py

@@ -5,25 +5,25 @@
 
 class Test3324:
     def test_3324(self, duckdb_cursor):
-        create_output = duckdb_cursor.execute(
+        duckdb_cursor.execute(
             """
-        create or replace table my_table as 
-        select 'test1' as column1, 1 as column2, 'quack' as column3 
+        create or replace table my_table as
+        select 'test1' as column1, 1 as column2, 'quack' as column3
         union all
-        select 'test2' as column1, 2 as column2, 'quacks' as column3 
+        select 'test2' as column1, 2 as column2, 'quacks' as column3
         union all
-        select 'test3' as column1, 3 as column2, 'quacking' as column3 
+        select 'test3' as column1, 3 as column2, 'quacking' as column3
         """
         ).fetch_df()
-        prepare_output = duckdb_cursor.execute(
+        duckdb_cursor.execute(
             """
-            prepare v1 as 
-                select 
+            prepare v1 as
+                select
                     column1
                     , column2
-                    , column3 
+                    , column3
                 from my_table
-                where 
+                where
                     column1 = $1"""
         ).fetch_df()
 

tests/fast/api/test_config.py

@@ -1,5 +1,4 @@
-# simple DB API testcase
-
+# ruff: noqa: F841
 import os
 import re
 
@@ -57,15 +56,15 @@ def test_extension_setting(self):
     def test_unrecognized_option(self, duckdb_cursor):
         success = True
         try:
-            con_regular = duckdb.connect(":memory:", config={"thisoptionisprobablynotthere": "42"})
+            duckdb.connect(":memory:", config={"thisoptionisprobablynotthere": "42"})
         except:
             success = False
         assert success == False
 
     def test_incorrect_parameter(self, duckdb_cursor):
         success = True
         try:
-            con_regular = duckdb.connect(":memory:", config={"default_null_order": "42"})
+            duckdb.connect(":memory:", config={"default_null_order": "42"})
         except:
             success = False
         assert success == False

tests/fast/api/test_cursor.py

@@ -52,7 +52,7 @@ def test_cursor_temp_schema_closed(self):
         cursor.close()
         with pytest.raises(duckdb.CatalogException):
             # This table does not exist in this cursor
-            res = other_cursor.execute("select * from tbl").fetchall()
+            other_cursor.execute("select * from tbl").fetchall()
 
     def test_cursor_temp_schema_open(self):
         con = duckdb.connect(":memory:")
@@ -63,7 +63,7 @@ def test_cursor_temp_schema_open(self):
         # cursor.close()
         with pytest.raises(duckdb.CatalogException):
             # This table does not exist in this cursor
-            res = other_cursor.execute("select * from tbl").fetchall()
+            other_cursor.execute("select * from tbl").fetchall()
 
     def test_cursor_temp_schema_both(self):
         con = duckdb.connect(":memory:")
@@ -99,7 +99,7 @@ def test_cursor_closed(self):
         con = duckdb.connect(":memory:")
         con.close()
         with pytest.raises(duckdb.ConnectionException):
-            cursor = con.cursor()
+            con.cursor()
 
     def test_cursor_used_after_connection_closed(self):
         con = duckdb.connect(":memory:")

tests/fast/api/test_dbapi00.py

@@ -20,8 +20,6 @@ def test_fetchmany_default(self, duckdb_cursor, integers):
         truth_value = len(duckdb_cursor.execute("select * from integers").fetchall())
 
         duckdb_cursor.execute("Select * from integers")
-        # by default 'size' is 1
-        arraysize = 1
         list_of_results = []
         while True:
             res = duckdb_cursor.fetchmany()

tests/fast/api/test_dbapi_fetch.py

@@ -39,7 +39,7 @@ def test_multiple_fetch_df(self, duckdb_cursor):
 
     def test_multiple_fetch_arrow(self, duckdb_cursor):
         pd = pytest.importorskip("pandas")
-        arrow = pytest.importorskip("pyarrow")
+        pytest.importorskip("pyarrow")
         con = duckdb.connect()
         c = con.execute("SELECT 42::BIGINT AS a")
         table = c.fetch_arrow_table()

tests/fast/api/test_duckdb_connection.py

@@ -51,15 +51,15 @@ def test_default_connection_from_connect(self):
             con = duckdb.connect(":default:", read_only=True)
 
     def test_arrow(self):
-        pyarrow = pytest.importorskip("pyarrow")
+        pytest.importorskip("pyarrow")
         duckdb.execute("select [1,2,3]")
-        result = duckdb.fetch_arrow_table()
+        duckdb.fetch_arrow_table()
 
     def test_begin_commit(self):
         duckdb.begin()
         duckdb.execute("create table tbl as select 1")
         duckdb.commit()
-        res = duckdb.table("tbl")
+        duckdb.table("tbl")
         duckdb.execute("drop table tbl")
 
     def test_begin_rollback(self):
@@ -68,7 +68,7 @@ def test_begin_rollback(self):
         duckdb.rollback()
         with pytest.raises(duckdb.CatalogException):
             # Table does not exist
-            res = duckdb.table("tbl")
+            duckdb.table("tbl")
 
     def test_cursor(self):
         duckdb.execute("create table tbl as select 3")
@@ -98,7 +98,7 @@ def use_cursors():
     def test_df(self):
         ref = [([1, 2, 3],)]
         duckdb.execute("select [1,2,3]")
-        res_df = duckdb.fetch_df()
+        res_df = duckdb.fetch_df()  # noqa: F841
         res = duckdb.query("select * from res_df").fetchall()
         assert res == ref
 
@@ -148,10 +148,10 @@ def test_pystatement(self):
             duckdb.InvalidInputException,
             match="Please provide either a DuckDBPyStatement or a string representing the query",
         ):
-            rel = duckdb.query(statements)
+            duckdb.query(statements)
 
         with pytest.raises(duckdb.BinderException, match="This type of statement can't be prepared!"):
-            rel = duckdb.query(statements[0])
+            duckdb.query(statements[0])
 
         assert duckdb.query(statements[1]).fetchall() == [(21,)]
         assert duckdb.execute(statements[1]).fetchall() == [(21,)]
@@ -179,7 +179,7 @@ def test_pystatement(self):
 
     def test_fetch_arrow_table(self):
         # Needed for 'fetch_arrow_table'
-        pyarrow = pytest.importorskip("pyarrow")
+        pytest.importorskip("pyarrow")
 
         duckdb.execute("Create Table test (a integer)")
 
@@ -205,7 +205,7 @@ def test_fetch_arrow_table(self):
     def test_fetch_df(self):
         ref = [([1, 2, 3],)]
         duckdb.execute("select [1,2,3]")
-        res_df = duckdb.fetch_df()
+        res_df = duckdb.fetch_df()  # noqa: F841
         res = duckdb.query("select * from res_df").fetchall()
         assert res == ref
 
@@ -222,7 +222,7 @@ def test_fetch_df_chunk(self):
 
     def test_fetch_record_batch(self):
         # Needed for 'fetch_arrow_table'
-        pyarrow = pytest.importorskip("pyarrow")
+        pytest.importorskip("pyarrow")
 
         duckdb.execute("CREATE table t as select range a from range(3000);")
         duckdb.execute("SELECT a FROM t")
@@ -236,7 +236,7 @@ def test_fetchall(self):
     def test_fetchdf(self):
         ref = [([1, 2, 3],)]
         duckdb.execute("select [1,2,3]")
-        res_df = duckdb.fetchdf()
+        res_df = duckdb.fetchdf()  # noqa: F841
         res = duckdb.query("select * from res_df").fetchall()
         assert res == ref
 
@@ -363,7 +363,7 @@ def test_wrap_shadowing(self):
         pd = NumpyPandas()
         import duckdb
 
-        df = pd.DataFrame({"a": [1, 2, 3]})
+        df = pd.DataFrame({"a": [1, 2, 3]})  # noqa: F841
         res = duckdb.sql("from df").fetchall()
         assert res == [(1,), (2,), (3,)]