tests

Author: evertlammerts

duckdb/polars_io.py

@@ -179,7 +179,7 @@ def _pl_tree_to_sql(tree: _ExpressionTree) -> str:
             assert isinstance(decimal_value, list), (
                 f"A {dtype} should be a two or three member list but got {type(decimal_value)}"
             )
-            assert 2 >= len(decimal_value) <= 3, (
+            assert 2 <= len(decimal_value) <= 3, (
                 f"A {dtype} should be a two or three member list but got {len(decimal_value)} member list"
             )
             return str(Decimal(decimal_value[0]) / Decimal(10 ** decimal_value[-1]))

tests/fast/arrow/test_polars.py

@@ -632,27 +632,24 @@ def test_invalid_expr_json(self):
         with pytest.raises(AssertionError, match="The col name of a Column should be a str but got"):
             _pl_tree_to_sql(json.loads(bad_type_expr))
 
-    def test_old_dec(self):
-        bad_key_expr = """
-        {
-            "BinaryExpr": {
-                "left": { "Column": "foo" },
-                "middle": "Gt",
-                "right": { "Literal": { "Int": 5 } }
-            }
-        }
+    def test_decimal_scale(self):
+        scalar_decimal_no_scale = """
+          { "Scalar": {
+            "Decimal": [
+              1,
+              0
+            ]
+          } }
         """
-        with pytest.raises(KeyError, match="'op'"):
-            _pl_tree_to_sql(json.loads(bad_key_expr))
-
-        bad_type_expr = """
-        {
-            "BinaryExpr": {
-                "left": { "Column": [ "foo" ]  },
-                "op": "Gt",
-                "right": { "Literal": { "Int": 5 } }
-            }
-        }
+        assert _pl_tree_to_sql(json.loads(scalar_decimal_no_scale)) == "1"
+
+        scalar_decimal_scale = """
+          { "Scalar": {
+            "Decimal": [
+              1,
+              38,
+              0
+            ]
+          } }
         """
-        with pytest.raises(AssertionError, match="The col name of a Column should be a str but got"):
-            _pl_tree_to_sql(json.loads(bad_type_expr))
+        assert _pl_tree_to_sql(json.loads(scalar_decimal_scale)) == "1"