Skip to content

Commit 332e653

Browse files
authored
Assume one-time donation if no frequency selected (#443)
1 parent fe3f644 commit 332e653

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

packages/donate-button-v4/src/components/widget/components/PaymentProcess/DefaultFlow/index.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@ import {
1717
import {useConfigContext} from 'src/components/widget/hooks/useConfigContext';
1818
import {useSubmitDonation} from 'src/components/widget/hooks/useSubmitDonation';
1919
import {useWidgetContext} from 'src/components/widget/hooks/useWidgetContext';
20-
import {OneTimeFrequencyMethods} from 'src/components/widget/types/PaymentMethod';
2120
import {getSubmitButtonText} from 'src/helpers/getSubmitButtonText';
2221

2322
export const DefaultFlow = () => {
2423
const {frequency: fixedFrequency, amount: fixedAmount} = useConfigContext();
2524
const {
26-
frequency,
2725
donationAmount,
2826
selectedPaymentMethod,
2927
paymentRequestAvailable,
@@ -48,13 +46,7 @@ export const DefaultFlow = () => {
4846
<PublicTestimony />
4947
<ErrorMessage message={submitError} />
5048
<SubmitButton
51-
disabled={
52-
(!frequency &&
53-
!fixedFrequency &&
54-
!OneTimeFrequencyMethods.includes(selectedPaymentMethod)) ||
55-
!donationAmount ||
56-
Number.isNaN(donationAmount)
57-
}
49+
disabled={!donationAmount || Number.isNaN(donationAmount)}
5850
>
5951
{getSubmitButtonText({
6052
method: selectedPaymentMethod,

packages/donate-button-v4/src/helpers/constructDonateUrl.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ export function constructDonateUrl({
143143
amount,
144144
...rest
145145
}: DonateUrlParams) {
146+
// If frequency is "" or undefined, default to one-time
147+
frequency ||= DonationFrequency.OneTime;
146148
const baseUrl = getBaseUrl(rest);
147149
const params = getBaseParams(rest);
148150

0 commit comments

Comments
 (0)