Offset bugfix that always resulted in an offset of 1 (#29)

* Added Table write interface for XYZ fields, includes conversion.

* Added conversion of other fields as well.

* Fixed offset bug.

* Also update test.

* Up version.

Author: evetion

.gitignore

@@ -4,3 +4,4 @@
 deps/deps.jl
 deps/usr
 *.DS_Store
+*.laz

Project.toml

@@ -1,7 +1,7 @@
 name = "LazIO"
 uuid = "c3605908-9f0f-11e8-0a72-0d361c15a277"
 authors = ["Maarten Pronk <git@evetion.nl>"]
-version = "0.3.0"
+version = "0.3.1"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

src/table.jl

@@ -17,6 +17,7 @@ function determine_offset(min_value, max_value, scale; threshold=10^7)
     # Try to convert back and forth and check overflow
     (muladd(round(Int32, (min_value - s) / scale), scale, s) > 0) == (min_value > 0) || error("Can't fit offset in this scale, try to coarsen it.")
     (muladd(round(Int32, (max_value - s) / scale), scale, s) > 0) == (max_value > 0) || error("Can't fit offset in this scale, try to coarsen it.")
+    s
 end
 
 """Correctly set fields that require conversion or packing."""

test/testio.jl

@@ -88,7 +88,7 @@ end
     ds = LazIO.open(manual_fn)
 
     @test length(ds) == 3
-    @test first(ds).X == 1099901
+    @test first(ds).X == 1100001
     @test muladd(first(ds).X, ds.header.x_scale_factor, ds.header.x_offset) ≈ 11000.01
     @test LasIO.classification(first(ds)) == LazIO.classes.ground
 end