fix: made custom url crate optional in order to pass cargo publish

Author: evilsocket

Cargo.toml

@@ -116,6 +116,7 @@ default = [
     "socks5",
 ]
 http = ["dep:url", "dep:reqwest", "dep:base64", "dep:ntlmclient"]
+http_relative_paths = []
 dns = ["dep:trust-dns-resolver"]
 ssh = ["dep:async-ssh2-tokio"]
 sql = ["dep:sqlx"]

Dockerfile

@@ -4,7 +4,7 @@ RUN apt-get update && apt-get install -y libsmbclient-dev libssl-dev ca-certific
 
 WORKDIR /app
 ADD . /app
-RUN cargo build --release
+RUN cargo build --release --features http_relative_paths
 
 FROM debian:bullseye
 RUN apt-get update && apt-get install -y libsmbclient libssl-dev ca-certificates

src/plugins/http/mod.rs

@@ -380,11 +380,25 @@ impl HTTP {
             )
         };
 
+        // HACK: since crates.io removes the patch.crates-io sections from the Cargo file:
+        //
+        //  https://stackoverflow.com/questions/69235287/can-i-publish-a-crate-that-uses-a-patch
+        //  https://github.com/rust-lang/cargo/issues/10440
+        //
+        // using our version of the URL crate won't compile with "cargo publish". Therefore
+        // we need to wrap this in an optional feature that's not included by default.
+
+        #[cfg(feature = "http_relative_paths")]
         let url = Url::options()
             .leave_relative(true)
             .parse(&url_raw)
             .map_err(|e| format!("could not parse url '{}': {:?}", url_raw, e))?;
 
+        #[cfg(not(feature = "http_relative_paths"))]
+        let url = Url::options()
+            .parse(&url_raw)
+            .map_err(|e| format!("could not parse url '{}': {:?}", url_raw, e))?;
+
         // build base request object
         let request = self
             .client