pop-ups: better unique rule names

When answering a pop-up we generate the rule name based on the
properties of the connection.
When sending the rule to the daemon, the daemon verifies that the name
is unique and save it. If it's not, it generates a unique name.

However, if you responded to a pop-up and later modified any property of
the rule without changing the name, if the same connection tried to be
established again, you were prompted to allow/deny it, generating the
same name for the rule.
This could cause some confusion, because when sending the new rule to
the daemon the rule name was regenerated to be unique, but on the GUI
it was not updated, and even more, the old-personalized rule was
replaced with the new one.

Author: gustavo-iniguez-goya

ui/opensnitch/dialogs/prompt.py

@@ -16,6 +16,8 @@
 from opensnitch.desktop_parser import LinuxDesktopParser
 from opensnitch.config import Config
 from opensnitch.version import version
+from opensnitch.actions import Actions
+from opensnitch.rules import Rules
 
 from opensnitch import ui_pb2
 
@@ -55,6 +57,8 @@ def __init__(self, parent=None, appicon=None):
         QtWidgets.QDialog.__init__(self, parent, QtCore.Qt.WindowStaysOnTopHint)
         # Other interesting flags: QtCore.Qt.Tool | QtCore.Qt.BypassWindowManagerHint
         self._cfg = Config.get()
+        self._rules = Rules.instance()
+
         self.setupUi(self)
         self.setWindowIcon(appicon)
         self.installEventFilter(self)
@@ -649,7 +653,7 @@ def _send_rule(self):
                 self._rule.operator.type = Config.RULE_TYPE_LIST
                 self._rule.operator.operand = Config.RULE_TYPE_LIST
 
-            self._rule.name = rule_temp_name
+            self._rule.name = self._rules.new_unique_name(rule_temp_name, self._peer, "")
 
             self.hide()
             if self._ischeckAdvanceded:

ui/opensnitch/rules.py

@@ -101,6 +101,19 @@ def delete(self, name, addr, callback):
     def delete_by_field(self, field, values):
         return self._db.delete_rules_by_field(field, values)
 
+    def new_unique_name(self, rule_name, node_addr, prefix):
+        """generate a new name, if the supplied one already exists
+        """
+        if self._db.get_rule(rule_name, node_addr).next() == False:
+            return rule_name
+
+        for idx in range(0, 100):
+            new_rule_name = "{0}-{1}".format(rule_name, idx)
+            if self._db.get_rule(new_rule_name, node_addr).next() == False:
+                return new_rule_name
+
+        return rule_name
+
     def update_time(self, time, name, addr):
         """Updates the time of a rule, whenever a new connection matched a
         rule.