[bugfix] Fix order of arguments when performing an XML Diff

Author: adamretter

exist-core/pom.xml

@@ -1243,6 +1243,7 @@
                                 <include>src/test/resources-filtered/org/exist/xquery/functions/transform/transform-from-pkg-test.conf.xml</include>
                                 <include>src/main/java/org/exist/xquery/functions/transform/Transform.java</include>
                                 <include>src/test/java/org/exist/xquery/functions/transform/TransformFromPkgTest.java</include>
+                                <include>src/test/java/org/exist/xquery/functions/transform/TransformTest.java</include>
                                 <include>src/main/java/org/exist/xquery/functions/util/BuiltinFunctions.java</include>
                                 <include>src/main/java/org/exist/xquery/functions/util/DescribeFunction.java</include>
                                 <include>src/main/java/org/exist/xquery/functions/util/FunctionFunction.java</include>
@@ -1905,6 +1906,7 @@
                                 <exclude>src/test/resources-filtered/org/exist/xquery/functions/transform/transform-from-pkg-test.conf.xml</exclude>
                                 <exclude>src/main/java/org/exist/xquery/functions/transform/Transform.java</exclude>
                                 <exclude>src/test/java/org/exist/xquery/functions/transform/TransformFromPkgTest.java</exclude>
+                                <exclude>src/test/java/org/exist/xquery/functions/transform/TransformTest.java</exclude>
                                 <exclude>src/main/java/org/exist/xquery/functions/util/BuiltinFunctions.java</exclude>
                                 <exclude>src/main/java/org/exist/xquery/functions/util/DescribeFunction.java</exclude>
                                 <exclude>src/main/java/org/exist/xquery/functions/util/Eval.java</exclude>

exist-core/src/test/java/org/exist/dom/persistent/PersistentDomTest.java

@@ -430,8 +430,8 @@ private void assertXml(final String expected, final Node actual) {
         final Source srcExpected = Input.fromString(expected).build();
         final Source srcActual = Input.fromNode(actual).build();
 
-        final Diff diff = DiffBuilder.compare(srcActual)
-                .withTest(srcExpected)
+        final Diff diff = DiffBuilder.compare(srcExpected)
+                .withTest(srcActual)
                 .checkForIdentical()
                 .build();
 

exist-core/src/test/java/org/exist/xquery/functions/transform/TransformTest.java

@@ -1,4 +1,28 @@
 /*
+ * Elemental
+ * Copyright (C) 2024, Evolved Binary Ltd
+ *
+ * [email protected]
+ * https://www.evolvedbinary.com | https://www.elemental.xyz
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; version 2.1.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * NOTE: Parts of this file contain code from 'The eXist-db Authors'.
+ *       The original license header is included below.
+ *
+ * =====================================================================
+ *
  * eXist-db Open Source Native XML Database
  * Copyright (C) 2001 The eXist-db Authors
  *
@@ -253,8 +277,8 @@ public void xslDocument() throws EXistException, PermissionDeniedException, XPat
             final Source expected = Input.fromString("<elem1/>").build();
             final Source actual = Input.fromDocument(sequence.itemAt(0).toJavaObject(Document.class)).build();
 
-            final Diff diff = DiffBuilder.compare(actual)
-                    .withTest(expected)
+            final Diff diff = DiffBuilder.compare(expected)
+                    .withTest(actual)
                     .checkForSimilar()
                     .build();