[bugfix] Fix an issue with dependencies

Author: adamretter

exist-start/pom.xml

@@ -71,13 +71,8 @@
 
     <dependencies>
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.hamcrest</groupId>
-            <artifactId>hamcrest</artifactId>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-api</artifactId>
             <scope>test</scope>
         </dependency>
     </dependencies>
@@ -117,6 +112,7 @@
                             <includes>
                                 <include>pom.xml</include>
                                 <include>src/main/java/org/exist/start/CompatibleJavaVersionCheck.java</include>
+                                <include>src/test/java/org/exist/start/CompatibleJavaVersionCheckTest.java</include>
                             </includes>
                         </licenseSet>
 
@@ -130,6 +126,7 @@
                                 <exclude>Mortbay-APACHE-2-license.template.txt</exclude>
                                 <exclude>src/main/java/org/exist/start/Classpath.java</exclude>
                                 <exclude>src/main/java/org/exist/start/CompatibleJavaVersionCheck.java</exclude>
+                                <exclude>src/test/java/org/exist/start/CompatibleJavaVersionCheckTest.java</exclude>
                                 <exclude>src/main/java/org/exist/start/Main.java</exclude>
                                 <exclude>src/main/java/org/exist/start/Version.java</exclude>
                             </excludes>
@@ -179,24 +176,6 @@ The original license statement is also included below.]]></preamble>
 
                 </configuration>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-dependency-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <id>analyze</id>
-                        <goals>
-                            <goal>analyze-only</goal>
-                        </goals>
-                        <configuration>
-                            <failOnWarning>true</failOnWarning>
-                            <ignoredUnusedDeclaredDependencies>
-                                <ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest:jar</ignoredUnusedDeclaredDependency>
-                            </ignoredUnusedDeclaredDependencies>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
         </plugins>
     </build>
 

exist-start/src/test/java/org/exist/start/CompatibleJavaVersionCheckTest.java

@@ -1,4 +1,28 @@
 /*
+ * Elemental
+ * Copyright (C) 2024, Evolved Binary Ltd
+ *
+ * [email protected]
+ * https://www.evolvedbinary.com | https://www.elemental.xyz
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; version 2.1.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * NOTE: Parts of this file contain code from 'The eXist-db Authors'.
+ *       The original license header is included below.
+ *
+ * =====================================================================
+ *
  * eXist-db Open Source Native XML Database
  * Copyright (C) 2001 The eXist-db Authors
  *
@@ -21,11 +45,11 @@
  */
 package org.exist.start;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.util.Optional;
 
-import static org.junit.Assert.*;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class CompatibleJavaVersionCheckTest {
 
@@ -172,34 +196,46 @@ public void checkJava11() throws StartException {
         CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("11.0.11"));
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava12() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("12.0.1"));
+    @Test
+    public void checkJava12() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("12.0.1"))
+        );
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava12_BellSoft() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("12.0.2-BellSoft"));
+    @Test
+    public void checkJava12_BellSoft() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("12.0.2-BellSoft"))
+        );
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava13() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("13.0.2"));
+    @Test
+    public void checkJava13() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("13.0.2"))
+        );
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava14() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("14.0.2"));
+    @Test
+    public void checkJava14() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("14.0.2"))
+        );
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava15_0_0() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("15.0.0"));
+    @Test
+    public void checkJava15_0_0() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("15.0.0"))
+        );
     }
 
-    @Test(expected = StartException.class)
-    public void checkJava15_0_1() throws StartException {
-        CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("15.0.1"));
+    @Test
+    public void checkJava15_0_1() {
+        assertThrows(StartException.class, () ->
+            CompatibleJavaVersionCheck.checkForCompatibleJavaVersion(Optional.of("15.0.1"))
+        );
     }
 
     @Test