[temp] Disable eager serialization of XQuery results over XML:RPC as the result format is incompatible with eXist-db 6.x.x

This could be enabled later in Elemental for improved serialization over XML-RPC and performance, but doing so would compromise the current 100% XML:RPC API compatibility with eXist-db 6.x.x.

Author: adamretter

exist-core/src/main/java/org/exist/xmlrpc/RpcConnection.java

@@ -2028,7 +2028,10 @@ private Map<String, Object> queryResultToTypedRpcResponse(final long startTime,
             result.put("docUri", "temp_xquery/" + item.hashCode());
             result.put("nodeId", String.valueOf(ni.getNodeNumber()));
             result.put("xdmSerializationOptions", xdmSerializationOptions);
-            result.put("value", item);  // NOTE(AR) In-memory Nodes are transient and so need to be sent directly in the result
+
+            // TODO(AR) enable this later in Elemental for improved serialization over XML-RPC and performance (it also means that we could then cleanup the XML:DB Remote API by removing its uses of XQJ Marshaller and org.exist.xquery.value.*)
+            // NOTE(AR) In-memory Nodes can alternatively be returned directly as part of the result, however doing so changes the XML:RPC result format in a manner that would be incompatible with eXist-db 6.x.x
+            //            result.put("value", item);
 
         } else {
             LOG.error("Omitting from results, unsure how to process: {}", item.getClass());