WIP2

Author: evoskuil

include/bitcoin/database/file/utilities.hpp

@@ -72,8 +72,9 @@ BCD_API bool copy_directory(const path& from, const path& to) NOEXCEPT;
 BCD_API code copy_directory_ex(const path& from, const path& to) NOEXCEPT;
 
 /// File descriptor functions (for memory mapping).
-BCD_API int open(const path& filename) NOEXCEPT;
-BCD_API code open_ex(int& file_descriptor, const path& filename) NOEXCEPT;
+BCD_API int open(const path& filename, bool random=false) NOEXCEPT;
+BCD_API code open_ex(int& file_descriptor, const path& filename,
+    bool random=false) NOEXCEPT;
 BCD_API bool close(int file_descriptor) NOEXCEPT;
 BCD_API code close_ex(int file_descriptor) NOEXCEPT;
 BCD_API bool size(size_t& out, int file_descriptor) NOEXCEPT;

include/bitcoin/database/memory/map.hpp

@@ -43,7 +43,7 @@ class BCD_API map
     DELETE_COPY_MOVE(map);
 
     map(const std::filesystem::path& filename, size_t minimum=1,
-        size_t expansion=0, bool random=true) NOEXCEPT;
+        size_t expansion=0, bool random=false) NOEXCEPT;
 
     /// Destruct for debug assertion only.
     virtual ~map() NOEXCEPT;

src/file/utilities.cpp

@@ -242,11 +242,8 @@ code copy_directory_ex(const path& from, const path& to) NOEXCEPT
 
 // File descriptor functions required for memory mapping.
 
-int open(const path& filename) NOEXCEPT
+int open(const path& filename, bool random) NOEXCEPT
 {
-    // TODO: provide as parameter for random vs. sequential accesss.
-    const auto random{ true };
-
     const auto path = system::to_extended_path(filename);
     int file_descriptor{};
 
@@ -294,10 +291,10 @@ int open(const path& filename) NOEXCEPT
     return file_descriptor;
 }
 
-code open_ex(int& file_descriptor, const path& filename) NOEXCEPT
+code open_ex(int& file_descriptor, const path& filename, bool random) NOEXCEPT
 {
     system::error::clear_errno();
-    file_descriptor = open(filename);
+    file_descriptor = open(filename, random);
     return system::error::get_errno();
 }