Merge pull request libbitcoin#970 from evoskuil/master

Simplify/optimize peer standard deviation calc.

Author: evoskuil

src/chasers/chaser_check.cpp

@@ -269,7 +269,8 @@ void chaser_check::do_update(object_key channel, uint64_t speed,
     }
 
     // Integer to floating point.
-    speeds_[channel] = to_floating(speed);
+    const auto fast = to_floating(speed);
+    speeds_[channel] = fast;
 
     // Three elements are required to measure deviation, don't drop below.
     const auto count = speeds_.size();
@@ -279,34 +280,31 @@ void chaser_check::do_update(object_key channel, uint64_t speed,
         return;
     }
 
-    const auto rate = std::accumulate(speeds_.begin(), speeds_.end(), 0.0,
-        [](double sum, const auto& element) NOEXCEPT
-        {
-            return sum + element.second;
-        });
+    double sum = 0.0;
+    double sum_squares = 0.0;
+    for (const auto& element : speeds_)
+    {
+        sum += element.second;
+        sum_squares += std::pow(element.second, two);
+    }
 
-    const auto mean = rate / count;
-    if (speed >= mean)
+    const auto mean = sum / count;
+    if (fast >= mean)
     {
         handler(error::success);
         return;
     }
 
-    const auto variance = std::accumulate(speeds_.begin(), speeds_.end(), 0.0,
-        [mean](double sum, const auto& element) NOEXCEPT
-        {
-            return sum + std::pow(element.second - mean, two);
-        }) / (sub1(count));
-
+    const auto variance = (sum_squares - (sum * sum) / count) / sub1(count);
     const auto sdev = std::sqrt(variance);
-    const auto slow = (mean - speed) > (allowed_deviation_ * sdev);
+    const auto slow = (mean - fast) > (allowed_deviation_ * sdev);
 
     // Only speed < mean channels are logged.
     LOGV("Below average channel (" << count << ") rate ("
-        << to_kilobits_per_second(rate) << ") mean ("
+        << to_kilobits_per_second(sum)  << ") mean ("
         << to_kilobits_per_second(mean) << ") sdev ("
         << to_kilobits_per_second(sdev) << ") Kbps [" << (slow ? "*" : "")
-        << to_kilobits_per_second(to_floating(speed)) << "].");
+        << to_kilobits_per_second(fast) << "].");
 
     if (slow)
     {