refactor: use a more modern writing style (#2534)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

Optimize code using a more modern writing style. Official support from
Go, for more details visit
https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->

Signed-off-by: queryfast <[email protected]>

Author: queryfast

block/sync_test.go

@@ -843,7 +843,7 @@ func TestSyncLoop_MultipleHeadersArriveFirst_ThenData(t *testing.T) {
 			txs[i] = append(txs[i], tx)
 		}
 
-		expectedAppHashes[i] = []byte(fmt.Sprintf("app_hash_h%d", i+1))
+		expectedAppHashes[i] = fmt.Appendf(nil, "app_hash_h%d", i+1)
 		var err error
 		expectedStates[i], err = prevState.NextState(headers[i].Header, expectedAppHashes[i])
 		require.NoError(err)

pkg/store/store_test.go

@@ -272,7 +272,6 @@ func TestHeightErrors(t *testing.T) {
 	_ = cases[1].mock.Put(context.Background(), ds.NewKey(getHeightKey()), badHeightBytes)
 
 	for _, tc := range cases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			s := New(tc.mock)