Skip to content

Commit 2ccc6e6

Browse files
authored
test: omit unnecessary reassignment (#2703)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> The new version of Go (after Go 1.22) has been optimized, and variables do not need to be reassigned. Our project use Go 1.24: ```shell Directory: apps/evm/single, Go version: 1.24.6 Directory: apps/grpc/single, Go version: 1.24.6 Directory: apps/testapp, Go version: 1.24.6 Directory: core, Go version: 1.24.1 Directory: da, Go version: 1.24.1 Directory: execution/evm, Go version: 1.24.6 Directory: execution/evm/test, Go version: 1.24.6 Directory: execution/grpc, Go version: 1.24.2 Directory: sequencers/single, Go version: 1.24.2 Directory: test/docker-e2e, Go version: 1.24.6 Directory: test/e2e, Go version: 1.24.6 ``` For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore Signed-off-by: juejinyuxitu <[email protected]>
1 parent aa4bada commit 2ccc6e6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

block/internal/submitting/submitter_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ func TestSubmitter_IsHeightDAIncluded(t *testing.T) {
5757
}
5858

5959
for name, spec := range specs {
60-
name := name
61-
spec := spec
6260
t.Run(name, func(t *testing.T) {
6361
included, err := s.IsHeightDAIncluded(spec.height, spec.header, spec.data)
6462
if spec.expErr {

0 commit comments

Comments
 (0)