refactor(pkg/config)!: move da start height to genesis (#2727)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

UX improvement to move da height from user config to developer config.
The flow is as follow:

The developer once starting is sequencer is able to query its node to
get the da start height
They should add it in the genesis they share with the others node
operators.
Nodes will fetch directly from the correct DA height. 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->

Author: julienrbrt

apps/evm/single/README.md

@@ -15,26 +15,28 @@ This directory contains the implementation of a single EVM sequencer using Ev-no
 
 2. Build the sequencer:
 
-    ```bash
-    go build -o evm-single .
-    ```
+   ```bash
+   go build -o evm-single .
+   ```
 
 3. Initialize the sequencer:
 
-    ```bash
-    ./evm-single init --rollkit.node.aggregator=true --rollkit.signer.passphrase secret
-    ```
+   ```bash
+   ./evm-single init --rollkit.node.aggregator=true --rollkit.signer.passphrase secret
+   ```
 
 4. Start the sequencer:
 
-    ```bash
-    ./evm-single start \
-      --evm.jwt-secret $(cat <path_to>/execution/evm/docker/jwttoken/jwt.hex) \
-      --evm.genesis-hash 0x2b8bbb1ea1e04f9c9809b4b278a8687806edc061a356c7dbc491930d8e922503 \
-      --rollkit.node.block_time 1s \
-      --rollkit.node.aggregator=true \
-      --rollkit.signer.passphrase secret
-    ```
+   ```bash
+   ./evm-single start \
+     --evm.jwt-secret $(cat <path_to>/execution/evm/docker/jwttoken/jwt.hex) \
+     --evm.genesis-hash 0x2b8bbb1ea1e04f9c9809b4b278a8687806edc061a356c7dbc491930d8e922503 \
+     --rollkit.node.block_time 1s \
+     --rollkit.node.aggregator=true \
+     --rollkit.signer.passphrase secret
+   ```
+
+Share your `genesis.json` with other node operators. Add `da_start_height` field corresponding to the first DA included block of the chain (can be queried on the sequencer node).
 
 Note: Replace `<path_to>` with the actual path to the rollkit repository. If you'd ever like to restart a fresh node, make sure to remove the originally created sequencer node directory using:
 
@@ -58,41 +60,43 @@ The sequencer can be configured using various command-line flags. The most impor
 
 2. Initialize the full node:
 
-    ```bash
-    ./evm-single init --home ~/.evm-single-full-node
-    ```
+   ```bash
+   ./evm-single init --home ~/.evm-single-full-node
+   ```
 
 3. Copy the genesis file from the sequencer node:
 
-    ```bash
-    cp ~/.evm-single/config/genesis.json ~/.evm-single-full-node/config/genesis.json
-    ```
+   ```bash
+   cp ~/.evm-single/config/genesis.json ~/.evm-single-full-node/config/genesis.json
+   ```
+
+   Verify the `da_start_height` value in the genesis file is set. If not, ask the chain developer to share it.
 
 4. Identify the sequencer node's P2P address from its logs. It will look similar to:
 
-    ```sh
-    1:55PM INF listening on address=/ip4/127.0.0.1/tcp/7676/p2p/12D3KooWJ1J5W7vpHuyktcvc71iuduRgb9pguY9wKMNVVPwweWPk module=main
-    ```
+   ```sh
+   1:55PM INF listening on address=/ip4/127.0.0.1/tcp/7676/p2p/12D3KooWJ1J5W7vpHuyktcvc71iuduRgb9pguY9wKMNVVPwweWPk module=main
+   ```
 
-    Create an environment variable with the P2P address:
+   Create an environment variable with the P2P address:
 
-    ```bash
-    export P2P_ID="12D3KooWJbD9TQoMSSSUyfhHMmgVY3LqCjxYFz8wQ92Qa6DAqtmh"
-    ```
+   ```bash
+   export P2P_ID="12D3KooWJbD9TQoMSSSUyfhHMmgVY3LqCjxYFz8wQ92Qa6DAqtmh"
+   ```
 
 5. Start the full node:
 
-    ```bash
-    ./evm-single start \
-       --home ~/.evm-single-full-node \
-       --evm.jwt-secret $(cat <path_to>/execution/evm/docker/jwttoken/jwt.hex) \
-       --evm.genesis-hash 0x2b8bbb1ea1e04f9c9809b4b278a8687806edc061a356c7dbc491930d8e922503 \
-       --rollkit.rpc.address=127.0.0.1:46657 \
-       --rollkit.p2p.listen_address=/ip4/127.0.0.1/tcp/7677 \
-       --rollkit.p2p.peers=/ip4/127.0.0.1/tcp/7676/p2p/$P2P_ID \
-       --evm.engine-url http://localhost:8561 \
-       --evm.eth-url http://localhost:8555
-    ```
+   ```bash
+   ./evm-single start \
+      --home ~/.evm-single-full-node \
+      --evm.jwt-secret $(cat <path_to>/execution/evm/docker/jwttoken/jwt.hex) \
+      --evm.genesis-hash 0x2b8bbb1ea1e04f9c9809b4b278a8687806edc061a356c7dbc491930d8e922503 \
+      --rollkit.rpc.address=127.0.0.1:46657 \
+      --rollkit.p2p.listen_address=/ip4/127.0.0.1/tcp/7677 \
+      --rollkit.p2p.peers=/ip4/127.0.0.1/tcp/7676/p2p/$P2P_ID \
+      --evm.engine-url http://localhost:8561 \
+      --evm.eth-url http://localhost:8555
+   ```
 
 If you'd ever like to restart a fresh node, make sure to remove the originally created full node directory using:
 

apps/evm/single/cmd/run.go

@@ -67,6 +67,10 @@ var RunCmd = &cobra.Command{
 			return fmt.Errorf("failed to load genesis: %w", err)
 		}
 
+		if genesis.DAStartHeight == 0 && !nodeConfig.Node.Aggregator {
+			logger.Warn().Msg("da_start_height is not set in genesis.json, ask your chain developer")
+		}
+
 		singleMetrics, err := single.DefaultMetricsProvider(nodeConfig.Instrumentation.IsPrometheusEnabled())(genesis.ChainID)
 		if err != nil {
 			return err

apps/grpc/single/cmd/run.go

@@ -69,6 +69,10 @@ The execution client must implement the Evolve execution gRPC interface.`,
 			return err
 		}
 
+		if genesis.DAStartHeight == 0 && !nodeConfig.Node.Aggregator {
+			logger.Warn().Msg("da_start_height is not set in genesis.json, ask your chain developer")
+		}
+
 		// Create metrics provider
 		singleMetrics, err := single.DefaultMetricsProvider(nodeConfig.Instrumentation.IsPrometheusEnabled())(genesis.ChainID)
 		if err != nil {

apps/testapp/cmd/run.go

@@ -88,6 +88,10 @@ var RunCmd = &cobra.Command{
 			return fmt.Errorf("failed to load genesis: %w", err)
 		}
 
+		if genesis.DAStartHeight == 0 && !nodeConfig.Node.Aggregator {
+			logger.Warn().Msg("da_start_height is not set in genesis.json, ask your chain developer")
+		}
+
 		sequencer, err := single.NewSequencer(
 			ctx,
 			logger,

block/internal/syncing/syncer.go

@@ -190,7 +190,7 @@ func (s *Syncer) initializeState() error {
 	s.SetLastState(state)
 
 	// Set DA height
-	daHeight := max(state.DAHeight, s.config.DA.StartHeight)
+	daHeight := max(state.DAHeight, s.genesis.DAStartHeight)
 	s.SetDAHeight(daHeight)
 
 	s.logger.Info().

block/internal/syncing/syncer_backoff_test.go

@@ -318,13 +318,13 @@ func setupTestSyncer(t *testing.T, daBlockTime time.Duration) *Syncer {
 
 	cfg := config.DefaultConfig()
 	cfg.DA.BlockTime.Duration = daBlockTime
-	cfg.DA.StartHeight = 100
 
 	gen := genesis.Genesis{
 		ChainID:         "test-chain",
 		InitialHeight:   1,
 		StartTime:       time.Now().Add(-time.Hour), // Start in past
 		ProposerAddress: addr,
+		DAStartHeight:   100,
 	}
 
 	syncer := NewSyncer(

block/internal/syncing/syncer_benchmark_test.go

@@ -87,8 +87,7 @@ func newBenchFixture(b *testing.B, totalHeights uint64, shuffledTx bool, daDelay
 	cfg := config.DefaultConfig()
 	// keep P2P ticker dormant unless we manually inject P2P events
 	cfg.Node.BlockTime = config.DurationWrapper{Duration: 1}
-	cfg.DA.StartHeight = daHeightOffset
-	gen := genesis.Genesis{ChainID: "bchain", InitialHeight: 1, StartTime: time.Now().Add(-time.Second), ProposerAddress: addr}
+	gen := genesis.Genesis{ChainID: "bchain", InitialHeight: 1, StartTime: time.Now().Add(-time.Second), ProposerAddress: addr, DAStartHeight: daHeightOffset}
 
 	mockExec := testmocks.NewMockExecutor(b)
 	// if execDelay > 0, sleep on ExecuteTxs to simulate slow consumer

block/internal/syncing/syncer_test.go

@@ -320,8 +320,7 @@ func TestSyncLoopPersistState(t *testing.T) {
 
 	addr, pub, signer := buildSyncTestSigner(t)
 	cfg := config.DefaultConfig()
-	cfg.DA.StartHeight = myDAHeightOffset
-	gen := genesis.Genesis{ChainID: "tchain", InitialHeight: 1, StartTime: time.Now().Add(-time.Second), ProposerAddress: addr}
+	gen := genesis.Genesis{ChainID: "tchain", InitialHeight: 1, StartTime: time.Now().Add(-time.Second), ProposerAddress: addr, DAStartHeight: myDAHeightOffset}
 
 	dummyExec := execution.NewDummyExecutor()
 

docs/guides/create-genesis.md

@@ -116,6 +116,15 @@ For example, start the simple ignite chain with the following command:
 gmd start --evnode.node.aggregator
 ```
 
+## Share the genesis file
+
+Once the sequencer is running, share the genesis file with your peers. You can find the genesis file at `~/.${CHAIN_ID}/config/genesis.json`.
+Before doing so, add a `da_start_height` field to the genesis file, that corresponds to the height at which the first height was included on the DA layer. This height can be fetched directly from the [sequencer RPC](https://github.com/evstack/ev-node/blob/v1.0.0-beta.5/proto/evnode/v1/state_rpc.proto).
+
+```sh
+jq '.da_start_height = 1' ~/.$CHAIN_ID/config/genesis.json > temp.json && mv temp.json ~/.$CHAIN_ID/config/genesis.json
+```
+
 ## Summary
 
 By following these steps, you will set up the genesis for your chain, initialize the validator, add a genesis account, and start the chain. This guide provides a basic framework for configuring and starting your chain using the gm-world binary. Make sure you initialized your chain correctly, and use the `gmd` command for all operations.

docs/guides/da/celestia-da.md

@@ -135,7 +135,6 @@ gmd start \
     --evnode.da.auth_token $AUTH_TOKEN \
     --evnode.da.header_namespace $DA_NAMESPACE \
     --evnode.da.data_namespace $DA_NAMESPACE \
-    --evnode.da.start_height $DA_BLOCK_HEIGHT \
     --evnode.da.address $DA_ADDRESS
 ```