pass maxbytes down to jsonrpc

Author: tac0turtle

apps/evm/single/cmd/run.go

@@ -51,7 +51,7 @@ var RunCmd = &cobra.Command{
 
 		logger.Info().Str("headerNamespace", headerNamespace.HexString()).Str("dataNamespace", dataNamespace.HexString()).Msg("namespaces")
 
-		daJrpc, err := jsonrpc.NewClient(context.Background(), logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier)
+		daJrpc, err := jsonrpc.NewClient(context.Background(), logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier, rollcmd.DefaultMaxBlobSize)
 		if err != nil {
 			return err
 		}

apps/grpc/single/cmd/run.go

@@ -52,7 +52,7 @@ The execution client must implement the Evolve execution gRPC interface.`,
 		logger.Info().Str("headerNamespace", headerNamespace.HexString()).Str("dataNamespace", dataNamespace.HexString()).Msg("namespaces")
 
 		// Create DA client
-		daJrpc, err := jsonrpc.NewClient(cmd.Context(), logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier)
+		daJrpc, err := jsonrpc.NewClient(cmd.Context(), logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier, rollcmd.DefaultMaxBlobSize)
 		if err != nil {
 			return err
 		}

apps/testapp/cmd/run.go

@@ -51,7 +51,7 @@ var RunCmd = &cobra.Command{
 
 		logger.Info().Str("headerNamespace", headerNamespace.HexString()).Str("dataNamespace", dataNamespace.HexString()).Msg("namespaces")
 
-		daJrpc, err := jsonrpc.NewClient(ctx, logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier)
+		daJrpc, err := jsonrpc.NewClient(ctx, logger, nodeConfig.DA.Address, nodeConfig.DA.AuthToken, nodeConfig.DA.GasPrice, nodeConfig.DA.GasMultiplier, rollcmd.DefaultMaxBlobSize)
 		if err != nil {
 			return err
 		}

da/jsonrpc/client.go

@@ -13,11 +13,6 @@ import (
 	"github.com/evstack/ev-node/core/da"
 )
 
-const (
-	// DefaultMaxBlobSize is the default maximum blob size in bytes.
-	DefaultMaxBlobSize = 1.5 * 1024 * 1024 // 1.5MB
-)
-
 //go:generate mockgen -destination=mocks/api.go -package=mocks . Module
 type Module interface {
 	da.DA
@@ -227,16 +222,16 @@ func (c *Client) Close() {
 
 // NewClient creates a new Client with one connection per namespace with the
 // given token as the authorization token.
-func NewClient(ctx context.Context, logger zerolog.Logger, addr, token string, gasPrice, gasMultiplier float64) (*Client, error) {
+func NewClient(ctx context.Context, logger zerolog.Logger, addr, token string, gasPrice, gasMultiplier float64, maxBlobSize uint64) (*Client, error) {
 	authHeader := http.Header{"Authorization": []string{fmt.Sprintf("Bearer %s", token)}}
-	return newClient(ctx, logger, addr, authHeader, gasPrice, gasMultiplier)
+	return newClient(ctx, logger, addr, authHeader, gasPrice, gasMultiplier, maxBlobSize)
 }
 
-func newClient(ctx context.Context, logger zerolog.Logger, addr string, authHeader http.Header, gasPrice, gasMultiplier float64) (*Client, error) {
+func newClient(ctx context.Context, logger zerolog.Logger, addr string, authHeader http.Header, gasPrice, gasMultiplier float64, maxBlobSize uint64) (*Client, error) {
 	var multiCloser multiClientCloser
 	var client Client
 	client.DA.Logger = logger
-	client.DA.MaxBlobSize = uint64(DefaultMaxBlobSize)
+	client.DA.MaxBlobSize = maxBlobSize
 	client.DA.gasPrice = gasPrice
 	client.DA.gasMultiplier = gasMultiplier
 

da/jsonrpc/proxy_test.go

@@ -29,6 +29,8 @@ const (
 	ClientURL = "http://localhost:3450"
 
 	testMaxBlobSize = 100
+
+	DefaultMaxBlobSize = 1.5 * 1024 * 1024 // 1.5MB
 )
 
 // testNamespace is a 15-byte namespace that will be hex encoded to 30 chars and truncated to 29
@@ -55,7 +57,7 @@ func TestProxy(t *testing.T) {
 		}
 	}()
 
-	client, err := proxy.NewClient(context.Background(), logger, ClientURL, "74657374", 0, 1)
+	client, err := proxy.NewClient(context.Background(), logger, ClientURL, "74657374", 0, 1, DefaultMaxBlobSize)
 	require.NoError(t, err)
 
 	t.Run("Basic DA test", func(t *testing.T) {

pkg/cmd/run_node.go

@@ -26,6 +26,8 @@ import (
 	"github.com/evstack/ev-node/pkg/signer/file"
 )
 
+const DefaultMaxBlobSize = 1.5 * 1024 * 1024 // 1.5MB
+
 // ParseConfig is an helpers that loads the node configuration and validates it.
 func ParseConfig(cmd *cobra.Command) (rollconf.Config, error) {
 	nodeConfig, err := rollconf.Load(cmd)