-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
Description
In a lot of places, possible errors will just be given to the Check function, which logs the error and happily continues on. This can result in runtime errors. Some instances are:
Line 89 in 8f7528c
| Check(err) |
Here it is just assumed that opening the database connection will be successful. It will log an error, should one happen, but it will blindly run into the call at line 92.
Same thing on
Line 182 in 8f7528c
| Check(err) |
I think those errors could be handled more gracefully.
In addition, I'd recommend renaming the Check function into something like LogError. This way, it is obvious what the function actually does.