Skip to content

Use http opts configured per http client for pod identity #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use http opts configured per http client for pod identity #1175

wants to merge 1 commit into from
+2 −12

Conversation

Szetty
Copy link

@Szetty Szetty commented Oct 15, 2025

ExAws.PodIdentity is not working if Req (ExAws.Request.Req) is configured as http_client:

iex(1)> ExAws.PodIdentity.security_credentials(%{http_client: ExAws.Request.Req})
** (ArgumentError) unknown option :recv_timeout. Did you mean :receive_timeout?
    (req 0.5.15) lib/req/request.ex:1184: Req.Request.validate_options/2
    (req 0.5.15) lib/req.ex:549: Req.merge/2
    (req 0.5.15) lib/req.ex:1093: Req.request/2
    (ex_aws 2.6.0) lib/ex_aws/request/req.ex:24: ExAws.Request.Req.request/5
    (ex_aws 2.6.0) lib/ex_aws/pod_identity.ex:64: ExAws.PodIdentity.fetch_credentials/2
    (ex_aws 2.6.0) lib/ex_aws/pod_identity.ex:20: ExAws.PodIdentity.security_credentials/1

@bernardd
Copy link
Contributor

Thanks @Szetty. Would this change not preclude you from being able to override the HTTP ops for pod_identity operations, though?

@Szetty
Copy link
Author

Szetty commented Oct 17, 2025

Thanks @Szetty. Would this change not preclude you from being able to override the HTTP ops for pod_identity operations, though?

You would be able to override the HTTP opts as you would normally do for ex_aws, but you could not have different opts for pod identity calls than the common opts. Do you think this is necessary ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Szetty @bernardd