🥅 app: handle localized native auth errors

Author: dieguezguille

.changeset/twelve-points-sniff.md

@@ -0,0 +1,5 @@
+---
+"@exactly/mobile": patch
+---
+
+🥅 handle localized native auth errors by matching expo codes

src/components/add-funds/Bridge.tsx

@@ -57,7 +57,6 @@ import View from "../shared/View";
 import TokenInput from "../swaps/TokenInput";
 
 import type { Chain, Token } from "@lifi/sdk";
-import type { TFunction } from "i18next";
 
 export default function Bridge() {
   const router = useRouter();
@@ -375,41 +374,41 @@ export default function Bridge() {
         await switchChain(senderConfig, { chainId: source.chain });
       }
       setBridgeStatus(t("Submitting bridge transaction..."));
-      let id: string | undefined;
       try {
-        const result = await sendCallsTx({
-          chainId: source.chain,
-          calls: [
-            ...(approval ? [{ to: getAddress(source.address), data: approval }] : []),
-            { to: from.to, data: from.data, value: from.value },
-          ],
-        });
-        id = result.id;
-      } catch (error) {
-        if (isExaSender) throw error;
-        if (classifyError(error).authKnown) throw error;
-        reportError(error, {
-          level: "warning",
-          extra: error instanceof Error ? { cause: error.cause } : undefined,
-        });
-        await switchChain(senderConfig, { chainId: source.chain });
+        let id: string | undefined;
         try {
+          const result = await sendCallsTx({
+            chainId: source.chain,
+            calls: [
+              ...(approval ? [{ to: getAddress(source.address), data: approval }] : []),
+              { to: from.to, data: from.data, value: from.value },
+            ],
+          });
+          id = result.id;
+        } catch (error) {
+          if (isExaSender) throw error;
+          if (classifyError(error).authKnown) throw error;
+          reportError(error, {
+            level: "warning",
+            extra: error instanceof Error ? { cause: error.cause } : undefined,
+          });
+          await switchChain(senderConfig, { chainId: source.chain });
           if (approval) {
             const hash = await sendTx({ chainId: source.chain, to: getAddress(source.address), data: approval });
             await waitForTransactionReceipt(senderConfig, { hash, chainId: source.chain });
           }
           const hash = await sendTx({ chainId: source.chain, to: from.to, data: from.data, value: from.value });
           await waitForTransactionReceipt(senderConfig, { hash, chainId: source.chain });
-        } finally {
-          await switchChain(senderConfig, { chainId: chain.id }).catch(reportError);
+          setBridgeStatus(t("Bridge transaction submitted"));
+          return;
         }
+        if (!id) throw new Error("missing sendCalls id");
+        const { status } = await waitForCallsStatus(senderConfig, { id });
+        if (status === "failure") throw new Error("failed to submit bridge transaction");
         setBridgeStatus(t("Bridge transaction submitted"));
-        return;
+      } finally {
+        if (!isExaSender) await switchChain(senderConfig, { chainId: chain.id }).catch(reportError);
       }
-      if (!id) throw new Error("missing sendCalls id");
-      const { status } = await waitForCallsStatus(senderConfig, { id });
-      if (status === "failure") throw new Error("failed to submit bridge transaction");
-      setBridgeStatus(t("Bridge transaction submitted"));
     },
     onSuccess: async () => {
       toast.show(t("Bridge transaction submitted"), {
@@ -419,8 +418,17 @@ export default function Bridge() {
       });
       await queryClient.invalidateQueries({ queryKey: ["bridge", "sources"] });
     },
-    onError: (error: unknown) => {
-      handleError(error, toast, t);
+    onError(error) {
+      if (classifyError(error).authKnown) {
+        setBridgePreview(undefined);
+        resetBridgeMutation();
+        return;
+      }
+      toast.show(t("Bridge failed. Please try again."), {
+        native: true,
+        duration: 1000,
+        burntOptions: { haptic: "error", preset: "error" },
+      });
     },
     onSettled: () => {
       setBridgeStatus(undefined);
@@ -464,8 +472,17 @@ export default function Bridge() {
       });
       await queryClient.invalidateQueries({ queryKey: ["bridge", "sources"] });
     },
-    onError: (error: unknown) => {
-      handleError(error, toast, t, true);
+    onError(error) {
+      if (classifyError(error).authKnown) {
+        setBridgePreview(undefined);
+        resetTransferMutation();
+        return;
+      }
+      toast.show(t("Transfer failed. Please try again."), {
+        native: true,
+        duration: 1000,
+        burntOptions: { haptic: "error", preset: "error" },
+      });
     },
     onSettled: () => {
       setBridgeStatus(undefined);
@@ -1041,12 +1058,3 @@ export default function Bridge() {
     </SafeView>
   );
 }
-
-function handleError(error: unknown, toast: ReturnType<typeof useToastController>, t: TFunction, isTransfer?: boolean) {
-  if (!reportError(error).authKnown)
-    toast.show(isTransfer ? t("Transfer failed. Please try again.") : t("Bridge failed. Please try again."), {
-      native: true,
-      duration: 1000,
-      burntOptions: { haptic: "error", preset: "error" },
-    });
-}

src/utils/reportError.ts

@@ -44,16 +44,20 @@ export default function reportError(error: unknown, hint?: Parameters<typeof cap
   return classification;
 }
 
-const passkeyCancelledMessages = new Set([
-  "The operation couldn’t be completed. (com.apple.AuthenticationServices.AuthorizationError error 1001.)",
-  "The operation couldn’t be completed. (com.apple.AuthenticationServices.AuthorizationError error 1004.)",
-  "The operation couldn’t be completed. Device must be unlocked to perform request.",
-  "UserCancelled",
-]);
-const passkeyKnownMessages = new Set([
-  ...passkeyCancelledMessages,
-  "The operation couldn’t be completed. Stolen Device Protection is enabled and biometry is required.",
-]);
+const passkeyCancelledCodes = new Set(["ERR_USER_CANCELLED", "ERR_PASSKEY_REQUEST_FAILED"]);
+const passkeyCancelledPatterns = [
+  /com\.apple\.AuthenticationServices\.AuthorizationError\D+\b1001\b/i,
+  /com\.apple\.AuthenticationServices\.AuthorizationError\D+\b1004\b/i,
+  /^UserCancelled$/,
+];
+const passkeyKnownCodes = new Set([...passkeyCancelledCodes, "ERR_PENDING_PASSKEY_REQUEST"]);
+const passkeyKnownPatterns = [
+  ...passkeyCancelledPatterns,
+  /com\.apple\.AuthenticationServices\.AuthorizationError/i,
+  /Biometrics must be enabled/,
+  /Device must be unlocked/,
+  /There is already a pending passkey request/,
+];
 const authPrefixes = ["androidx.credentials.exceptions.domerrors.NotAllowedError"];
 const networkTypes = [
   ["ConnectionLost", /network connection was lost/i],
@@ -109,13 +113,14 @@ function parseError(error: unknown) {
 function classify({ code, message, name, reason, revert, status }: ParsedError) {
   const passkeyNotAllowed =
     name === "NotAllowedError" || (message !== undefined && authPrefixes.some((prefix) => message.startsWith(prefix)));
-  const passkeyCancelled = message !== undefined && passkeyCancelledMessages.has(message);
+  const passkeyCancelled =
+    (code !== undefined && passkeyCancelledCodes.has(code)) ||
+    (message !== undefined && passkeyCancelledPatterns.some((pattern) => pattern.test(message)));
   const passkeyKnown =
-    message !== undefined &&
-    (passkeyKnownMessages.has(message) ||
-      message.includes("Biometrics must be enabled") ||
-      message.includes("There is already a pending passkey request") ||
-      authPrefixes.some((prefix) => message.startsWith(prefix)));
+    (code !== undefined && passkeyKnownCodes.has(code)) ||
+    (message !== undefined &&
+      (passkeyKnownPatterns.some((pattern) => pattern.test(message)) ||
+        authPrefixes.some((prefix) => message.startsWith(prefix))));
   const passkeyWarning = passkeyKnown && !passkeyCancelled && !passkeyNotAllowed;
   const biometric = code === "ERR_BIOMETRIC";
   const walletRejected = status === "4001" || status === "5000";