Skip to content

Commit 42be7f0

Browse files
committed
Change bank/transfer/id route to use transferId instead of endToEndId
1 parent 301a20e commit 42be7f0

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

server/src/main/java/com/exactpro/blockchain/api/bank/BankHandler.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ public Mono<ServerResponse> getAllTransfers(ServerRequest request) {
3939
}
4040

4141
public Mono<ServerResponse> getTransfer(ServerRequest request) {
42-
String endToEndId = request.pathVariable("endToEndId");
43-
return ServerResponse.ok().body(transferRepository.getByEndToEndId(endToEndId), Transfer.class);
42+
int transferId = Integer.parseInt(request.pathVariable("transferId"));
43+
return ServerResponse.ok().body(transferRepository.getByTransferId(transferId), Transfer.class);
4444
}
4545

4646
public Mono<ServerResponse> getMessages(ServerRequest request) {
47-
String endToEndId = request.pathVariable("endToEndId");
48-
return ServerResponse.ok().body(messageRepository.findByEndToEndId(endToEndId), Transfer.class);
47+
int transferId = Integer.parseInt(request.pathVariable("transferId"));
48+
return ServerResponse.ok().body(messageRepository.findByTransferId(transferId), Transfer.class);
4949
}
5050

5151
public Mono<ServerResponse> getAllIbans(ServerRequest request) {

server/src/main/java/com/exactpro/blockchain/api/bank/BankRouter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ public class BankRouter {
1818
@Bean
1919
public @NonNull RouterFunction<ServerResponse> bankRoutes(@NonNull BankHandler bankHandler) {
2020
return route(GET(contentPath + "/api/bank/transfer"), bankHandler::getAllTransfers)
21-
.andRoute(GET(contentPath + "/api/bank/transfer/{endToEndId}"), bankHandler::getTransfer)
22-
.andRoute(GET(contentPath + "/api/bank/transfer/{endToEndId}/message"), bankHandler::getMessages)
21+
.andRoute(GET(contentPath + "/api/bank/transfer/{transferId}"), bankHandler::getTransfer)
22+
.andRoute(GET(contentPath + "/api/bank/transfer/{transferId}/message"), bankHandler::getMessages)
2323
.andRoute(GET(contentPath + "/api/bank/iban"), bankHandler::getAllIbans);
2424
}
2525
}

server/src/main/java/com/exactpro/blockchain/repository/MessageRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
import reactor.core.publisher.Flux;
88

99
public interface MessageRepository extends ReactiveCrudRepository<Message, String> {
10-
@Query("SELECT m.* FROM Message m INNER JOIN Transfer t ON m.transferId = t.transferId WHERE t.endToEndId = :endToEndId")
11-
Flux<Message> findByEndToEndId(@Param("endToEndId") String currencyCode);
10+
@Query("SELECT m.* FROM Message m INNER JOIN Transfer t ON m.transferId = t.transferId WHERE t.transferId = :transferId")
11+
Flux<Message> findByTransferId(@Param("transferId") int transferId);
1212
}

server/src/main/java/com/exactpro/blockchain/repository/TransferRepository.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@ public interface TransferRepository extends ReactiveCrudRepository<Transfer, Int
1313

1414
@NonNull Flux<Transfer> findByClientId(int clientId);
1515

16-
@NonNull Flux<Transfer> findByEndToEndId(String endToEndId);
17-
18-
default @NonNull Mono<Transfer> getByEndToEndId(String endToEndId) {
16+
default @NonNull Mono<Transfer> getByTransferId(int transferId) {
1917
return
20-
findByEndToEndId(endToEndId)
18+
findByTransferId(transferId)
2119
.single()
2220
.onErrorMap(
2321
NoSuchElementException.class,
24-
error -> new Exception(String.format("Transfer with EndToEndId '%s' doesn't exist", endToEndId), error)
22+
error -> new Exception(String.format("Transfer with transferId '%d' doesn't exist", transferId), error)
2523
);
2624
}
2725
}

0 commit comments

Comments
 (0)