chore: Clean up code

Author: exadmin

src/main/java/com/github/exadmin/cyberferret/async/RunnableCheckOnlineDictionary.java

@@ -24,7 +24,7 @@ public RunnableCheckOnlineDictionary(boolean isCLIMode) {
     }
 
     @Override
-    protected void _run() throws Exception {
+    protected void _run() {
         logInfo("Checking if new online dictionary exists");
 
         String prefix = "";

src/main/java/com/github/exadmin/cyberferret/async/RunnableScanner.java

@@ -28,9 +28,7 @@ public class RunnableScanner extends ARunnable {
     private Map<String, Pattern> sigMap = null;
     private Map<String, String> allowedSignaturesMap = null;
     private Map<String, List<String>> excludeExtMap = null;
-    private FxCallback fxCallback = (type, message) -> {
-        logInfo(message);
-    };
+    private FxCallback fxCallback = (type, message) -> logInfo(message);
     private boolean isAnySignatureFound = false;
     private List<Path> stagedFiles;
 

src/main/java/com/github/exadmin/cyberferret/async/RunnableSigsLoader.java

@@ -1,8 +1,5 @@
 package com.github.exadmin.cyberferret.async;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.*;
@@ -46,7 +43,7 @@ public boolean isReady() {
     }
 
     @Override
-    public void _run() throws Exception {
+    public void _run() {
         isReady.set(false);
 
         if (inputStream == null) throw new IllegalStateException("InputStream was not set before running action");

src/main/java/com/github/exadmin/cyberferret/fxui/SceneBuilder.java

@@ -87,8 +87,6 @@ protected Tab createAnalyzerTab(TabPane tabPane) {
         TitledPane tpConsole = createLogsPane();
 
         VBox vBox = new VBox();
-        // Pane wrapper = new StackPane(vBox);
-        // tab.setContent(wrapper);
         tab.setContent(vBox);
 
         Accordion accordion = new Accordion();
@@ -465,8 +463,6 @@ private HBox buildOnlineSignatureLoader(Stage primaryStage) {
         Button btnCheckUpdates = new Button("Download");
         Button btnDecrypt = new Button("Decrypt");
         Button btnApply = new Button("Load decrypted");
-        // Label lbSalt = new Label("Salt");
-        // TextField tfSalt = new PasswordField();
 
         HBox hBox = new HBox();
         hBox.setSpacing(8);
@@ -477,8 +473,6 @@ private HBox buildOnlineSignatureLoader(Stage primaryStage) {
 
         hBox.getChildren().add(lbPassw);
         hBox.getChildren().add(tfPassword);
-        // hBox.getChildren().add(lbSalt);
-        // hBox.getChildren().add(tfSalt);
         hBox.getChildren().add(new Separator(Orientation.VERTICAL));
 
         hBox.getChildren().add(btnDecrypt);
@@ -495,9 +489,6 @@ private HBox buildOnlineSignatureLoader(Stage primaryStage) {
         tfPassword.textProperty().addListener((bean, oldValue, newValue) -> PASSWORD.setValue(newValue));
         tfPassword.textProperty().setValue(PASSWORD.getValue());
 
-        // tfSalt.textProperty().addListener((bean, oldValue, newValue) -> SALT.setValue(newValue));
-        // tfSalt.textProperty().setValue(SALT.getValue());
-
         btnCheckUpdates.setOnAction((event) -> {
             ARunnable runnable = new RunnableCheckOnlineDictionary(false);
             runnable.setBeforeStart(() -> btnCheckUpdates.setDisable(true));
@@ -521,7 +512,7 @@ private HBox buildOnlineSignatureLoader(Stage primaryStage) {
                     String encryptedBody = FileUtils.readFile(DICTIONARY_FILE_PATH_ENCRYPTED);
                     String decryptedBody = PasswordBasedEncryption.decrypt(encryptedBody, tfPassword.getText());
 
-                    if (decryptedBody != null && !decryptedBody.isEmpty()) {
+                    if (!decryptedBody.isEmpty()) {
                         FileUtils.saveToFile(decryptedBody, FxConstants.DICTIONARY_FILE_PATH_DECRYPTED);
                         log.info("New decrypted dictionary cache-file was successfully created at {}", fileDecrypted);
                     }

src/main/java/com/github/exadmin/cyberferret/logging/HandyLogging.java

@@ -13,7 +13,7 @@ public class HandyLogging {
 
     protected volatile Logger logger;
     protected boolean printToConsole = false;
-    protected int loggingLevel = LEVEL_INFO;
+    protected final int loggingLevel = LEVEL_INFO;
 
     public void setPrintToConsole(boolean printToConsole) {
         this.printToConsole = printToConsole;

src/main/java/com/github/exadmin/cyberferret/utils/ConsoleUtils.java

@@ -59,8 +59,7 @@ public static String format(String msg, Object... binds) {
         if (bindIndex < binds.length) {
             // probably rest binds are exception-instances
             for (int i = bindIndex; i < binds.length; i++) {
-                if (binds[i] instanceof Throwable) {
-                    Throwable throwable = (Throwable) binds[i];
+                if (binds[i] instanceof Throwable throwable) {
                     throwable.printStackTrace();
                     return result.toString();
                 }