Skip to content

Commit 1d2496d

Browse files
committed
add generic image to params and release ci
Signed-off-by: Humair Khan <[email protected]>
1 parent 4733d63 commit 1d2496d

File tree

5 files changed

+62
-4
lines changed

5 files changed

+62
-4
lines changed

.github/scripts/release_prep/create_branches.sh

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,21 @@ git clone \
1818
--branch=master \
1919
https://${GH_USER_NAME}:${GH_TOKEN}@github.com/${DSP_REPOSITORY_FULL} \
2020
${DSP_DIR}
21-
cd ${DSP_DIR}
21+
pushd ${DSP_DIR}
2222
git checkout -B ${MINOR_RELEASE_BRANCH}
2323
git push origin ${MINOR_RELEASE_BRANCH}
2424
echo "::notice:: Created DSP ${MINOR_RELEASE_BRANCH} branch"
25+
popd
26+
27+
echo "Current branches in ${DSP_PIPELINES_REPOSITORY_FULL}"
28+
DSP_PIPELINES_DIR=$(dirname ${WORKING_DIR})/ilab-on-ocp
29+
git clone \
30+
--depth=1 \
31+
--branch=master \
32+
https://${GH_USER_NAME}:${GH_TOKEN}@github.com/${DSP_PIPELINES_REPOSITORY_FULL} \
33+
${DSP_PIPELINES_DIR}
34+
pushd ${DSP_PIPELINES_DIR}
35+
git checkout -B ${MINOR_RELEASE_BRANCH}
36+
git push origin ${MINOR_RELEASE_BRANCH}
37+
echo "::notice:: Created DSP Pipelines ${MINOR_RELEASE_BRANCH} branch"
38+
popd

.github/workflows/build-tags.yml

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ on:
1313
default: 'v1.0.x'
1414
description: 'Source branch to build DSP from'
1515
required: true
16+
src_pipelines_branch:
17+
type: string
18+
default: 'v1.0.x'
19+
description: 'Source branch to build DSP Pipelines Generic Image from'
20+
required: true
1621
target_tag:
1722
type: string
1823
default: 'vx.y.z'
@@ -28,6 +33,11 @@ on:
2833
default: 'opendatahub-io/data-science-pipelines'
2934
description: 'DSP org/repo'
3035
required: true
36+
pipelines_org_repo:
37+
type: string
38+
default: 'opendatahub-io/ilab-on-ocp'
39+
description: 'DSP Pipelines org/repo'
40+
required: true
3141
overwrite_imgs:
3242
type: string
3343
default: 'true'
@@ -45,6 +55,11 @@ on:
4555
default: 'v1.0.x'
4656
description: 'Source branch to build DSP from'
4757
required: true
58+
src_pipelines_branch:
59+
type: string
60+
default: 'v1.0.x'
61+
description: 'Source branch to build DSP Pipelines Generic Image from'
62+
required: true
4863
target_tag:
4964
default: 'vx.y.z'
5065
description: 'Target Image Tag'
@@ -57,6 +72,11 @@ on:
5772
default: 'opendatahub-io/data-science-pipelines'
5873
description: 'DSP org/repo'
5974
required: true
75+
pipelines_org_repo:
76+
type: string
77+
default: 'opendatahub-io/ilab-on-ocp'
78+
description: 'DSP Pipelines org/repo'
79+
required: true
6080
overwrite_imgs:
6181
type: string
6282
default: 'false'
@@ -70,8 +90,10 @@ env:
7090
IMAGE_REPO_SWF: ds-pipelines-scheduledworkflow
7191
IMAGE_REPO_LAUNCHER: ds-pipelines-launcher
7292
IMAGE_REPO_DRIVER: ds-pipelines-driver
93+
IMAGE_REPO_PIELINES_RUNTIME_GENERIC: ds-pipelines-runtime-generic
7394
SOURCE_DSPO_BRANCH: ${{ inputs.src_dspo_branch }}
7495
SOURCE_DSP_BRANCH: ${{ inputs.src_dsp_branch }}
96+
SOURCE_DSP_PIPELINES_BRANCH: ${{ inputs.src_pipelines_branch }}
7597
QUAY_ORG: ${{ inputs.quay_org }}
7698
QUAY_ID: ${{ secrets.QUAY_ID }}
7799
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
@@ -189,3 +211,19 @@ jobs:
189211
DOCKERFILE: backend/Dockerfile.launcher
190212
GH_REPO: ${{ inputs.dsp_org_repo }}
191213
OVERWRITE: ${{ env.OVERWRITE_IMAGES }}
214+
215+
RUNTIME-GENERIC-build:
216+
runs-on: ubuntu-latest
217+
permissions:
218+
contents: read
219+
steps:
220+
- uses: actions/checkout@v3
221+
- uses: ./.github/actions/build
222+
name: Build Image
223+
env:
224+
SOURCE_BRANCH: ${{ env.SOURCE_DSP_PIPELINES_BRANCH }}
225+
with:
226+
IMAGE_REPO: ${{ env.IMAGE_REPO_PIELINES_RUNTIME_GENERIC }}
227+
DOCKERFILE: Dockerfile
228+
GH_REPO: ${{ inputs.pipelines_org_repo }}
229+
OVERWRITE: ${{ env.OVERWRITE_IMAGES }}

.github/workflows/release_prep.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ env:
4141
DSPO_REPOSITORY_FULL: ${{ inputs.gh_org }}/data-science-pipelines-operator
4242
DSP_REPOSITORY: data-science-pipelines
4343
DSP_REPOSITORY_FULL: ${{ inputs.gh_org }}/data-science-pipelines
44+
DSP_PIPELINES_REPOSITORY_FULL: ${{ inputs.gh_org }}/ilab-on-ocp
4445
PREVIOUS_RELEASE_TAG: ${{ inputs.previous_release_tag }}
4546
OVERWRITE_IMAGES: ${{ inputs.overwrite_imgs }}
4647
CONFIG_TEMPLATE: "./.github/scripts/release_prep/templates/config.yaml"
@@ -86,6 +87,7 @@ jobs:
8687
MINOR_RELEASE_BRANCH: ${{ env.MINOR_RELEASE_BRANCH }}
8788
DSPO_REPOSITORY_FULL: ${{ env.DSPO_REPOSITORY_FULL }}
8889
DSP_REPOSITORY_FULL: ${{ env.DSP_REPOSITORY_FULL }}
90+
DSP_PIPELINES_REPOSITORY_FULL: ${{ env.DSP_PIPELINES_REPOSITORY_FULL }}
8991
WORKING_DIR: ${{ github.workspace }}
9092
run: ./.github/scripts/release_prep/create_branches.sh
9193

@@ -100,7 +102,8 @@ jobs:
100102
MINOR_RELEASE_BRANCH: ${{ env.MINOR_RELEASE_BRANCH }}
101103
MINOR_RELEASE_TAG: ${{ env.MINOR_RELEASE_TAG }}
102104
QUAY_ORG: ${{ env.QUAY_ORG }}
103-
DSPO_GH_ORG: ${{ env.DSP_REPOSITORY_FULL }}
105+
DSP_GH_ORG_REPO: ${{ env.DSP_REPOSITORY_FULL }}
106+
DSP_PIPELINES_GH_ORG_REPO: ${{ env.DSP_PIPELINES_REPOSITORY_FULL }}
104107
OVERWRITE_IMAGES: ${{ env.OVERWRITE_IMAGES }}
105108
steps:
106109
- run: echo "Storing env vars for re-usable workflow."
@@ -113,9 +116,11 @@ jobs:
113116
with:
114117
src_dspo_branch: ${{ needs.get-env-vars.outputs.MINOR_RELEASE_BRANCH }}
115118
src_dsp_branch: ${{ needs.get-env-vars.outputs.MINOR_RELEASE_BRANCH }}
119+
src_pipelines_branch: ${{ needs.get-env-vars.outputs.MINOR_RELEASE_BRANCH }}
116120
target_tag: ${{ needs.get-env-vars.outputs.MINOR_RELEASE_TAG }}
117121
quay_org: ${{ needs.get-env-vars.outputs.QUAY_ORG }}
118-
dsp_org_repo: ${{ needs.get-env-vars.outputs.DSPO_GH_ORG }}
122+
dsp_org_repo: ${{ needs.get-env-vars.outputs.DSP_GH_ORG_REPO }}
123+
pipelines_org_repo: ${{ needs.get-env-vars.outputs.DSP_PIPELINES_GH_ORG_REPO }}
119124
overwrite_imgs: ${{ needs.get-env-vars.outputs.OVERWRITE_IMAGES }}
120125
secrets: inherit
121126

config/base/params.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ IMAGES_ARGO_WORKFLOWCONTROLLER=quay.io/opendatahub/ds-pipelines-argo-workflowcon
77
IMAGES_LAUNCHER=quay.io/opendatahub/ds-pipelines-launcher:latest
88
IMAGES_DRIVER=quay.io/opendatahub/ds-pipelines-driver:latest
99
IMAGES_MLMDGRPC=quay.io/opendatahub/mlmd-grpc-server:latest
10+
IMAGES_PIPELINESRUNTIMEGENERIC=hukhan/ds-pipelines-runtime-generic:latest
1011
IMAGES_MLMDENVOY=registry.redhat.io/openshift-service-mesh/proxyv2-rhel8@sha256:b30d60cd458133430d4c92bf84911e03cecd02f60e88a58d1c6c003543cf833a
1112
IMAGES_MARIADB=registry.redhat.io/rhel8/mariadb-103@sha256:f0ee0d27bb784e289f7d88cc8ee0e085ca70e88a5d126562105542f259a1ac01
1213
IMAGES_OAUTHPROXY=registry.redhat.io/openshift4/ose-oauth-proxy@sha256:8ce44de8c683f198bf24ba36cd17e89708153d11f5b42c0a27e77f8fdb233551
13-
IMAGES_PIPELINESRUNTIMEGENERIC=TBD
1414
ZAP_LOG_LEVEL=info
1515
MAX_CONCURRENT_RECONCILES=10
1616
DSPO_HEALTHCHECK_DATABASE_CONNECTIONTIMEOUT=15s

scripts/release/params.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"IMAGES_SCHEDULEDWORKFLOW": "ds-pipelines-scheduledworkflow",
1313
"IMAGES_LAUNCHER": "ds-pipelines-launcher",
1414
"IMAGES_DRIVER": "ds-pipelines-driver",
15+
"IMAGES_PIPELINESRUNTIMEGENERIC": "ds-pipelines-runtime-generic",
1516
}
1617

1718
TAGGED_REPOS = {

0 commit comments

Comments
 (0)