Merge pull request opendatahub-io#243 from HumairAK/fix_actions

Fix actions

Author: HumairAK

.github/actions/build/action.yaml

@@ -1,5 +1,5 @@
-name: "Set up KinD"
-description: "Step to start and configure KinD cluster"
+name: "Create a podman build"
+description: "This workflow can be used to create a podman build and push to quay.io from source branches."
 inputs:
   IMAGE_REPO:
     description: "Quay image repo name."
@@ -37,14 +37,14 @@ runs:
     # Case 4: >1 tags were created, but the most recent one was never deleted (same as case 3, but the latest tag does not have "end_ts".
     - name: Check if Image already exists
       shell: bash
-      if: ${{ inputs.OVERWRITE }} == "false"
+      if: inputs.OVERWRITE == 'false'
       env:
         IMAGE: quay.io/${{ env.QUAY_ORG }}/${{ inputs.IMAGE_REPO }}:${{ env.TARGET_IMAGE_TAG }}
       run: |
+        echo ${{ inputs.OVERWRITE }}
+
         tags=$(curl --request GET 'https://quay.io/api/v1/repository/${{ env.QUAY_ORG }}/${{ inputs.IMAGE_REPO }}/tag/?specificTag=${{ env.TARGET_IMAGE_TAG }}')
-        echo $tags | yq .tags - | yq 'sort_by(.start_ts) | reverse' - -P | yq .[0].end_ts -
         latest_tag_has_end_ts=$(echo $tags | yq .tags - | yq 'sort_by(.start_ts) | reverse' - -P | yq .[0].end_ts -)
-        echo $latest_tag_has_end_ts
         notempty=$(echo ${tags} | yq .tags - | yq any)
 
         # Image only exists if there is a tag that does not have "end_ts" (i.e. it is still present).

.github/workflows/build-main.yml

@@ -0,0 +1,46 @@
+name: Build images for Main branch
+on:
+  push:
+    branches:
+      - main
+concurrency:
+  group: ${{ github.workflow }}
+  cancel-in-progress: true
+env:
+  IMAGE_REPO_DSPO: data-science-pipelines-operator
+  QUAY_ORG: opendatahub
+  QUAY_ID: ${{ secrets.QUAY_ID }}
+  QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
+  SOURCE_BRANCH: main
+jobs:
+  build-image:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Generate Tag
+        shell: bash
+        id: tags
+        run: |
+          commit_sha=${{ github.event.after }}
+          tag=main-${commit_sha:0:7}
+          echo "tag=${tag}" >> $GITHUB_OUTPUT
+      - name: Build Image
+        uses: ./.github/actions/build
+        env:
+          IMG: quay.io/${{ env.QUAY_ORG }}/${{ env.IMAGE_REPO_DSPO }}:${{ steps.tags.outputs.tag }}
+          TARGET_IMAGE_TAG: ${{ steps.tags.outputs.tag }}
+        with:
+          OVERWRITE: true
+          IMAGE_REPO: ${{ env.IMAGE_REPO_DSPO }}
+          DOCKERFILE: Dockerfile
+          GH_REPO: ${{ github.repository }}
+      - name: Tag latest
+        shell: bash
+        env:
+          IMG: quay.io/${{ env.QUAY_ORG }}/${{ env.IMAGE_REPO_DSPO }}
+          NEWEST_TAG: ${{ steps.tags.outputs.tag }}
+        run: |
+          podman tag ${IMG}:${NEWEST_TAG} ${IMG}:latest
+          podman push ${IMG}:latest
+          podman tag ${IMG}:${NEWEST_TAG} ${IMG}:main
+          podman push ${IMG}:main

.github/workflows/build-prs.yml

@@ -0,0 +1,96 @@
+name: Build images for PRs
+on:
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - closed
+      - synchronize
+permissions:
+  pull-requests: read
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+env:
+  IMAGE_REPO_DSPO: data-science-pipelines-operator
+  SOURCE_BRANCH: ${{ github.event.pull_request.head.sha }}
+  QUAY_ORG: opendatahub
+  QUAY_ID: ${{ secrets.QUAY_ID }}
+  QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
+  TARGET_IMAGE_TAG: pr-${{ github.event.pull_request.number }}
+  GH_USER_EMAIL: [email protected]
+  GH_USER_NAME: dsp-developers
+jobs:
+  build-pr-image:
+    if: github.event.pull_request.state == 'open'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Build Image
+        uses: ./.github/actions/build
+        with:
+          OVERWRITE: true
+          IMAGE_REPO: ${{ env.IMAGE_REPO_DSPO }}
+          DOCKERFILE: Dockerfile
+          GH_REPO: ${{ github.repository }}
+      - name: Send comment
+        shell: bash
+        env:
+          GH_TOKEN: ${{ secrets.ACCESS_TOKEN }}
+          IMG: quay.io/${{ env.QUAY_ORG }}/${{ env.IMAGE_REPO_DSPO }}:${{ env.TARGET_IMAGE_TAG }}
+        run: |
+          git config user.email "${{ env.GH_USER_EMAIL }}"
+          git config user.name "${{ env.GH_USER_NAME }}"
+
+          action=${{ github.event.action }}
+
+          if [[ "$action" == "synchronize" ]]; then
+            echo "Change to PR detected. A new PR build was completed." >> /tmp/body-file.txt
+          fi
+
+          if [[ "$action" == "reopened" ]]; then
+            echo "PR was re-opened." >> /tmp/body-file.txt
+          fi
+
+          cat <<"EOF" >> /tmp/body-file.txt
+            A new image has been built to help with testing out this PR: `${{ env.IMG }}`
+          EOF
+
+          if [[ "$action" == "opened" || "$action" == "reopened" ]]; then
+          cat <<"EOF" >> /tmp/body-file.txt
+          An OCP cluster where you are logged in as cluster admin is required.
+
+          To use this image run the following:
+
+          ```bash
+          cd $(mktemp -d)
+          git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
+          cd data-science-pipelines-operator/
+          git fetch origin pull/${{ github.event.pull_request.number }}/head
+          git checkout -b pullrequest ${{ env.SOURCE_BRANCH }}
+          make deploy IMG="${{ env.IMG }}"
+          ```
+
+          More instructions [here](https://github.com/opendatahub-io/data-science-pipelines-operator#deploy-dsp-instance) on how to deploy and test a Data Science Pipelines Application.
+
+          EOF
+          fi
+
+          gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/body-file.txt
+
+  clean-pr-images:
+    if: github.event.pull_request.state == 'closed'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Delete PR image
+        shell: bash
+        run: |
+          tag=$(curl --request GET 'https://quay.io/api/v1/repository/${{ env.QUAY_ORG }}/${{ env.IMAGE_REPO_DSPO }}/tag/?specificTag=${{ env.TARGET_IMAGE_TAG }}')
+          exists=$(echo ${tag} | yq .tags - | yq any)
+          IMAGE=quay.io/${{ env.QUAY_ORG }}/${{ env.IMAGE_REPO_DSPO }}:${{ env.TARGET_IMAGE_TAG }}
+          if [[ "$exists" == "true" ]]; then
+            echo "PR Closed deleting image...${{ env.IMAGE }}."
+            skopeo delete --creds ${{ env.QUAY_ID }}:${{ env.QUAY_TOKEN }} docker://${IMAGE}
+          else
+            echo "Deletion of image ${IMAGE} skipped because image already does not exist."
+          fi

.github/workflows/tag-and-build.yml renamed to .github/workflows/build-tags.yml

@@ -44,6 +44,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_DSPO }}
           DOCKERFILE: Dockerfile
@@ -56,6 +57,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_SERVER }}
           DOCKERFILE: backend/Dockerfile
@@ -68,6 +70,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_UI }}
           DOCKERFILE: frontend/Dockerfile
@@ -80,6 +83,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_CACHE }}
           DOCKERFILE: backend/Dockerfile.cacheserver
@@ -92,6 +96,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_PA }}
           DOCKERFILE: backend/Dockerfile.persistenceagent
@@ -104,6 +109,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_SWF }}
           DOCKERFILE: backend/Dockerfile.scheduledworkflow
@@ -116,6 +122,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_VC }}
           DOCKERFILE: backend/Dockerfile.viewercontroller
@@ -128,6 +135,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_ARTIFACT }}
           DOCKERFILE: backend/artifact_manager/Dockerfile
@@ -140,6 +148,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_WRITER }}
           DOCKERFILE: backend/metadata_writer/Dockerfile
@@ -152,6 +161,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_ENVOY }}
           DOCKERFILE: third-party/metadata_envoy/Dockerfile
@@ -164,6 +174,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/build
+        name: Build Image
         with:
           IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_GRPC }}
           DOCKERFILE: third-party/ml-metadata/Dockerfile

.github/workflows/image-check.yaml

@@ -1,13 +1,6 @@
 name: Image-check
 on:
-  push:
-    branches:
-      - '**'
-    tags-ignore:
-      - 'v*'
   pull_request:
-  workflow_dispatch:
-
 jobs:
   test:
     runs-on: ubuntu-latest

.github/workflows/pr-merged-image-delete.yml

@@ -1,13 +1,6 @@
 name: Pre-commit
 on:
-  push:
-    branches:
-      - '**'
-    tags-ignore:
-      - 'v*'
   pull_request:
-  workflow_dispatch:
-
 jobs:
   precommit:
     runs-on: ubuntu-latest
@@ -22,12 +15,10 @@ jobs:
         - /cache
     steps:
       - uses: actions/checkout@v2
-
       - name: Activate cache
         uses: actions/cache@v2
         with:
           path: /cache
           key: ${{ runner.os }}-cache-${{ hashFiles('**/go.sum', '.pre-commit-config.yaml') }}
-
       - name: Run pre-commit checks
         run: pre-commit run --all-files