Skip to content

Commit 8651473

Browse files
Merge pull request opendatahub-io#245 from DharmitD/mariadb-sa
Add non-default SAs to MariaDB and Minio
2 parents 03666a0 + e046635 commit 8651473

File tree

6 files changed

+13
-2
lines changed

6 files changed

+13
-2
lines changed

config/internal/mariadb/deployment.yaml.tmpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ spec:
2626
component: data-science-pipelines
2727
dspa: {{.Name}}
2828
spec:
29+
serviceAccountName: ds-pipelines-mariadb-sa-{{.Name}}
2930
containers:
3031
- name: mariadb
3132
image: {{.MariaDB.Image}}

config/internal/mariadb/sa.yaml.tmpl renamed to config/internal/mariadb/mariadb-sa.yaml.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v1
22
kind: ServiceAccount
33
metadata:
4-
name: mariadb-{{.Name}}
4+
name: ds-pipelines-mariadb-sa-{{.Name}}
55
namespace: {{.Namespace}}
66
labels:
77
app: mariadb-{{.Name}}

config/internal/minio/deployment.yaml.tmpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ spec:
2222
component: data-science-pipelines
2323
dspa: {{.Name}}
2424
spec:
25+
serviceAccountName: ds-pipelines-minio-sa-{{.Name}}
2526
containers:
2627
- args:
2728
- server
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: v1
2+
kind: ServiceAccount
3+
metadata:
4+
name: ds-pipelines-minio-sa-{{.Name}}
5+
namespace: {{.Namespace}}
6+
labels:
7+
app: minio-{{.Name}}
8+
component: data-science-pipelines

controllers/database.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ const dbSecret = "mariadb/secret.yaml.tmpl"
3131
var dbTemplates = []string{
3232
"mariadb/deployment.yaml.tmpl",
3333
"mariadb/pvc.yaml.tmpl",
34-
"mariadb/sa.yaml.tmpl",
3534
"mariadb/service.yaml.tmpl",
35+
"mariadb/mariadb-sa.yaml.tmpl",
3636
dbSecret,
3737
}
3838

controllers/storage.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ var storageTemplates = []string{
3434
"minio/deployment.yaml.tmpl",
3535
"minio/pvc.yaml.tmpl",
3636
"minio/service.yaml.tmpl",
37+
"minio/minio-sa.yaml.tmpl",
3738
storageSecret,
3839
}
3940

0 commit comments

Comments
 (0)