Correct testing data typos, and redundant check.

Signed-off-by: Humair Khan <[email protected]>

Author: HumairAK

controllers/testdata/declarative/case_3/expected/not_created/sample-config.yaml.tmpl

@@ -4,6 +4,6 @@ metadata:
     name: sample-config-testdsp3
     namespace: default
     labels:
-        app: ds-pipeline-testdsp2
+        app: ds-pipeline-testdsp3
         component: data-science-pipelines
 data: {}

controllers/testdata/declarative/case_3/expected/not_created/sample-pipeline.yaml.tmpl

@@ -4,6 +4,6 @@ metadata:
     name: sample-pipeline-testdsp3
     namespace: default
     labels:
-        app: ds-pipeline-testdsp2
+        app: ds-pipeline-testdsp3
         component: data-science-pipelines
 data: {}

controllers/testutil/equalities.go

@@ -98,7 +98,7 @@ func deploymentsAreEqual(expected, actual *unstructured.Unstructured) (bool, err
 	}
 
 	if !reflect.DeepEqual(expectedDep.Spec.Template.ObjectMeta, actualDep.Spec.Template.ObjectMeta) {
-		return false, notEqualMsg("selector")
+		return false, notEqualMsg("spec template")
 	}
 
 	if !reflect.DeepEqual(expectedDep.Spec.Template.Spec.Volumes, actualDep.Spec.Template.Spec.Volumes) {
@@ -123,9 +123,6 @@ func deploymentsAreEqual(expected, actual *unstructured.Unstructured) (bool, err
 			}
 		}
 
-		if !reflect.DeepEqual(expectedContainer.Env, actualContainer.Env) {
-			return false, notEqualMsg("Container Env")
-		}
 		if !reflect.DeepEqual(expectedContainer.Ports, actualContainer.Ports) {
 			return false, notEqualMsg("Container Ports")
 		}