Skip to content

Commit c50abad

Browse files
committed
update readme and add useful test feedback
Signed-off-by: Humair Khan <[email protected]>
1 parent 3d7b95b commit c50abad

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,7 @@ Images:
578578
ApiServer: quay.io/opendatahub/ds-pipelines-api-server:latest
579579
Artifact: quay.io/opendatahub/ds-pipelines-artifact-manager:latest
580580
OAuthProxy: registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0
581-
PersistentAgent: quay.io/opendatahub/ds-pipelines-persistenceagent:latest
581+
PersistenceAgent: quay.io/opendatahub/ds-pipelines-persistenceagent:latest
582582
ScheduledWorkflow: quay.io/opendatahub/ds-pipelines-scheduledworkflow:latest
583583
Cache: registry.access.redhat.com/ubi8/ubi-minimal
584584
MoveResultsImage: registry.access.redhat.com/ubi8/ubi-micro

controllers/testdata/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Each case requires a configmap, we can add one like this:
8383
Images:
8484
ApiServer: api-server:test4
8585
Artifact: artifact-manager:test4
86-
PersistentAgent: persistenceagent:test4
86+
PersistenceAgent: persistenceagent:test4
8787
ScheduledWorkflow: scheduledworkflow:test4
8888
Cache: ubi-minimal:test4
8989
MoveResultsImage: busybox:test4

tests/dspa_v2_test.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,22 @@ func (suite *IntegrationTestSuite) TestDSPADeployment() {
5959
}
6060
err := suite.Clientmgr.k8sClient.List(suite.Ctx, podList, listOpts...)
6161
require.NoError(t, err)
62-
assert.Equal(t, podCount, len(podList.Items))
62+
actualPodCount := len(podList.Items)
63+
assert.Equal(t, podCount, actualPodCount)
64+
65+
// Print out pod statuses for troubleshooting
66+
if podCount != actualPodCount {
67+
t.Log(fmt.Sprintf("expected %d pods to successfully deploy, got %d instead. Pods in the namespace:", podCount, actualPodCount))
68+
totalPodList := &corev1.PodList{}
69+
listOpts1 := []client.ListOption{
70+
client.InNamespace(suite.DSPANamespace),
71+
}
72+
err1 := suite.Clientmgr.k8sClient.List(suite.Ctx, totalPodList, listOpts1...)
73+
require.NoError(t, err1)
74+
for _, pod := range totalPodList.Items {
75+
t.Log(fmt.Sprintf("Pod Name: %s, Status: %s", pod.Name, pod.Status.Phase))
76+
}
77+
}
6378
})
6479
for _, deployment := range deployments {
6580
t.Run(fmt.Sprintf("should have a ready %s deployment", deployment), func(t *testing.T) {

0 commit comments

Comments
 (0)