Skip to content

Commit dd4a8ba

Browse files
committed
Add missing step names for gh actions.
Signed-off-by: Humair Khan <[email protected]>
1 parent af90121 commit dd4a8ba

File tree

4 files changed

+29
-19
lines changed

4 files changed

+29
-19
lines changed

.github/actions/build/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ runs:
4242
IMAGE: quay.io/${{ env.QUAY_ORG }}/${{ inputs.IMAGE_REPO }}:${{ env.TARGET_IMAGE_TAG }}
4343
run: |
4444
echo ${{ inputs.OVERWRITE }}
45-
45+
4646
tags=$(curl --request GET 'https://quay.io/api/v1/repository/${{ env.QUAY_ORG }}/${{ inputs.IMAGE_REPO }}/tag/?specificTag=${{ env.TARGET_IMAGE_TAG }}')
4747
latest_tag_has_end_ts=$(echo $tags | yq .tags - | yq 'sort_by(.start_ts) | reverse' - -P | yq .[0].end_ts -)
4848
notempty=$(echo ${tags} | yq .tags - | yq any)

.github/workflows/build-prs.yml

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,41 +24,42 @@ jobs:
2424
runs-on: ubuntu-latest
2525
steps:
2626
- uses: actions/checkout@v3
27-
- uses: ./.github/actions/build
27+
- name: Build Image
28+
uses: ./.github/actions/build
2829
with:
2930
OVERWRITE: true
3031
IMAGE_REPO: ${{ env.IMAGE_REPO_DSPO }}
3132
DOCKERFILE: Dockerfile
3233
GH_REPO: ${{ github.repository }}
33-
- name: Post build
34+
- name: Send comment
3435
shell: bash
3536
env:
3637
GH_TOKEN: ${{ secrets.ACCESS_TOKEN }}
3738
IMG: quay.io/${{ env.QUAY_ORG }}/data-science-pipelines-operator:${{ env.TARGET_IMAGE_TAG }}
3839
run: |
3940
git config user.email "[email protected]"
4041
git config user.name "dsp-developers"
41-
42+
4243
action=${{ github.event.action }}
43-
44-
if [[ "$action" == "synchronize" ]]; then
44+
45+
if [[ "$action" == "synchronize" ]]; then
4546
echo "Change to PR detected. A new PR build was completed." >> /tmp/body-file.txt
4647
fi
47-
48-
if [[ "$action" == "reopened" ]]; then
48+
49+
if [[ "$action" == "reopened" ]]; then
4950
echo "PR was re-opened." >> /tmp/body-file.txt
5051
fi
51-
52+
5253
cat <<"EOF" >> /tmp/body-file.txt
5354
A new image has been built to help with testing out this PR: `${{ env.IMG }}`
5455
EOF
55-
56-
if [[ "$action" == "opened" || "$action" == "reopened" ]]; then
56+
57+
if [[ "$action" == "opened" || "$action" == "reopened" ]]; then
5758
cat <<"EOF" >> /tmp/body-file.txt
58-
An OCP cluster where you are logged in as cluster admin is required.
59-
59+
An OCP cluster where you are logged in as cluster admin is required.
60+
6061
To use this image run the following:
61-
62+
6263
```bash
6364
cd $(mktemp -d)
6465
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
@@ -67,9 +68,9 @@ jobs:
6768
git checkout -b pullrequest ${{ env.SOURCE_BRANCH }}
6869
make deploy IMG="${{ env.IMG }}"
6970
```
70-
71+
7172
More instructions [here](https://github.com/opendatahub-io/data-science-pipelines-operator#deploy-dsp-instance) on how to deploy and test a Data Science Pipelines Application.
72-
73+
7374
EOF
7475
fi
7576
@@ -90,4 +91,4 @@ jobs:
9091
skopeo delete --creds ${{ env.QUAY_ID }}:${{ env.QUAY_TOKEN }} docker://${IMAGE}
9192
else
9293
echo "Deletion of image ${IMAGE} skipped because image already does not exist."
93-
fi
94+
fi

.github/workflows/build-tags.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
steps:
4545
- uses: actions/checkout@v3
4646
- uses: ./.github/actions/build
47+
name: Build Image
4748
with:
4849
IMAGE_REPO: ${{ env.IMAGE_REPO_DSPO }}
4950
DOCKERFILE: Dockerfile
@@ -56,6 +57,7 @@ jobs:
5657
steps:
5758
- uses: actions/checkout@v3
5859
- uses: ./.github/actions/build
60+
name: Build Image
5961
with:
6062
IMAGE_REPO: ${{ env.IMAGE_REPO_SERVER }}
6163
DOCKERFILE: backend/Dockerfile
@@ -68,6 +70,7 @@ jobs:
6870
steps:
6971
- uses: actions/checkout@v3
7072
- uses: ./.github/actions/build
73+
name: Build Image
7174
with:
7275
IMAGE_REPO: ${{ env.IMAGE_REPO_UI }}
7376
DOCKERFILE: frontend/Dockerfile
@@ -80,6 +83,7 @@ jobs:
8083
steps:
8184
- uses: actions/checkout@v3
8285
- uses: ./.github/actions/build
86+
name: Build Image
8387
with:
8488
IMAGE_REPO: ${{ env.IMAGE_REPO_CACHE }}
8589
DOCKERFILE: backend/Dockerfile.cacheserver
@@ -92,6 +96,7 @@ jobs:
9296
steps:
9397
- uses: actions/checkout@v3
9498
- uses: ./.github/actions/build
99+
name: Build Image
95100
with:
96101
IMAGE_REPO: ${{ env.IMAGE_REPO_PA }}
97102
DOCKERFILE: backend/Dockerfile.persistenceagent
@@ -104,6 +109,7 @@ jobs:
104109
steps:
105110
- uses: actions/checkout@v3
106111
- uses: ./.github/actions/build
112+
name: Build Image
107113
with:
108114
IMAGE_REPO: ${{ env.IMAGE_REPO_SWF }}
109115
DOCKERFILE: backend/Dockerfile.scheduledworkflow
@@ -116,6 +122,7 @@ jobs:
116122
steps:
117123
- uses: actions/checkout@v3
118124
- uses: ./.github/actions/build
125+
name: Build Image
119126
with:
120127
IMAGE_REPO: ${{ env.IMAGE_REPO_VC }}
121128
DOCKERFILE: backend/Dockerfile.viewercontroller
@@ -128,6 +135,7 @@ jobs:
128135
steps:
129136
- uses: actions/checkout@v3
130137
- uses: ./.github/actions/build
138+
name: Build Image
131139
with:
132140
IMAGE_REPO: ${{ env.IMAGE_REPO_ARTIFACT }}
133141
DOCKERFILE: backend/artifact_manager/Dockerfile
@@ -140,6 +148,7 @@ jobs:
140148
steps:
141149
- uses: actions/checkout@v3
142150
- uses: ./.github/actions/build
151+
name: Build Image
143152
with:
144153
IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_WRITER }}
145154
DOCKERFILE: backend/metadata_writer/Dockerfile
@@ -152,6 +161,7 @@ jobs:
152161
steps:
153162
- uses: actions/checkout@v3
154163
- uses: ./.github/actions/build
164+
name: Build Image
155165
with:
156166
IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_ENVOY }}
157167
DOCKERFILE: third-party/metadata_envoy/Dockerfile
@@ -164,6 +174,7 @@ jobs:
164174
steps:
165175
- uses: actions/checkout@v3
166176
- uses: ./.github/actions/build
177+
name: Build Image
167178
with:
168179
IMAGE_REPO: ${{ env.IMAGE_REPO_MLMD_GRPC }}
169180
DOCKERFILE: third-party/ml-metadata/Dockerfile

.github/workflows/precommit.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ jobs:
1515
- /cache
1616
steps:
1717
- uses: actions/checkout@v2
18-
1918
- name: Activate cache
2019
uses: actions/cache@v2
2120
with:
2221
path: /cache
2322
key: ${{ runner.os }}-cache-${{ hashFiles('**/go.sum', '.pre-commit-config.yaml') }}
24-
2523
- name: Run pre-commit checks
2624
run: pre-commit run --all-files

0 commit comments

Comments
 (0)