Skip to content

Commit e92f93e

Browse files
committed
Improve testutil Comparision logging
1 parent 1dba568 commit e92f93e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

controllers/testutil/equalities.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ package testutil
1818

1919
import (
2020
"fmt"
21+
"reflect"
22+
2123
appsv1 "k8s.io/api/apps/v1"
2224
v1 "k8s.io/api/core/v1"
2325
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2426
"k8s.io/client-go/kubernetes/scheme"
25-
"reflect"
2627
)
2728

2829
// CompareResourceProcs maps object kind's to their associated comparison procedures.
@@ -119,7 +120,7 @@ func deploymentsAreEqual(expected, actual *unstructured.Unstructured) (bool, err
119120
for i, expectedEnv := range expectedContainer.Env {
120121
actualEnv := actualContainer.Env[i]
121122
if !reflect.DeepEqual(expectedEnv, actualEnv) {
122-
return false, notEqualMsg(fmt.Sprintf("Container Env [expected: %s, actual: %s]", expectedEnv.Name, actualEnv.Name))
123+
return false, notEqualMsg(fmt.Sprintf("Container Env [expected: %s=%s, actual: %s=%s]", expectedEnv.Name, expectedEnv.Value, actualEnv.Name, actualEnv.Value))
123124
}
124125
}
125126

@@ -139,7 +140,7 @@ func deploymentsAreEqual(expected, actual *unstructured.Unstructured) (bool, err
139140
return false, notEqualMsg("Container Name")
140141
}
141142
if expectedContainer.Image != actualContainer.Image {
142-
return false, notEqualMsg("Container Image")
143+
return false, notEqualMsg(fmt.Sprintf("Container Image [expected: %s, actual: %s]", expectedContainer.Image, actualContainer.Image))
143144
}
144145
}
145146

0 commit comments

Comments
 (0)