Skip to content

Commit f0d4527

Browse files
committed
Add dspa namespace to publish metric logs.
Signed-off-by: Humair Khan <[email protected]>
1 parent fe12ad9 commit f0d4527

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

controllers/dspipeline_controller.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -318,36 +318,37 @@ func (r *DSPAReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
318318
func (r *DSPAReconciler) PublishMetrics(dspa *dspav1alpha1.DataSciencePipelinesApplication,
319319
apiServerReady, persistenceAgentReady, scheduledWorkflowReady,
320320
crReady metav1.Condition) {
321-
r.Log.Info("Publishing Ready Metrics")
321+
log := r.Log.WithValues("namespace", dspa.Namespace).WithValues("dspa_name", dspa.Name)
322+
log.Info("Publishing Ready Metrics")
322323
if apiServerReady.Status == metav1.ConditionTrue {
323-
r.Log.Info("APIServer Ready")
324+
log.Info("APIServer Ready")
324325
APIServerReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(1)
325326
} else {
326-
r.Log.Info("APIServer Not Ready")
327+
log.Info("APIServer Not Ready")
327328
APIServerReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(0)
328329
}
329330

330331
if persistenceAgentReady.Status == metav1.ConditionTrue {
331-
r.Log.Info("PersistanceAgent Ready")
332+
log.Info("PersistanceAgent Ready")
332333
PersistenceAgentReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(1)
333334
} else {
334-
r.Log.Info("PersistanceAgent Not Ready")
335+
log.Info("PersistanceAgent Not Ready")
335336
PersistenceAgentReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(0)
336337
}
337338

338339
if scheduledWorkflowReady.Status == metav1.ConditionTrue {
339-
r.Log.Info("ScheduledWorkflow Ready")
340+
log.Info("ScheduledWorkflow Ready")
340341
ScheduledWorkflowReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(1)
341342
} else {
342-
r.Log.Info("ScheduledWorkflow Not Ready")
343+
log.Info("ScheduledWorkflow Not Ready")
343344
ScheduledWorkflowReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(0)
344345
}
345346

346347
if crReady.Status == metav1.ConditionTrue {
347-
r.Log.Info("CR Fully Ready")
348+
log.Info("CR Fully Ready")
348349
CrReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(1)
349350
} else {
350-
r.Log.Info("CR Not Ready")
351+
log.Info("CR Not Ready")
351352
CrReadyMetric.WithLabelValues(dspa.Name, dspa.Namespace).Set(0)
352353
}
353354
}

0 commit comments

Comments
 (0)