feat(backend): specify the image for result step (kubeflow#1104)

Allow users to specify the image for `step-move-all-results-to-tekton-home`
step. Add an env variable for the custom image: `MOVERESULTS_IMAGE`
in the api server.

Signed-off-by: Yihong Wang <[email protected]>

Signed-off-by: Yihong Wang <[email protected]>

Author: yhwang

backend/src/apiserver/common/config.go

@@ -45,6 +45,7 @@ const (
 	InjectDefaultScript                     string = "INJECT_DEFAULT_SCRIPT"
 	ApplyTektonCustomResource               string = "APPLY_TEKTON_CUSTOM_RESOURCE"
 	TerminateStatus                         string = "TERMINATE_STATUS"
+	MoveResultsImage                        string = "MOVERESULTS_IMAGE"
 	Path4InternalResults                    string = "PATH_FOR_INTERNAL_RESULTS"
 	ObjectStoreAccessKey                    string = "OBJECTSTORECONFIG_ACCESSKEY"
 	ObjectStoreSecretKey                    string = "OBJECTSTORECONFIG_SECRETKEY"
@@ -144,6 +145,10 @@ func GetArtifactImage() string {
 	return GetStringConfigWithDefault(ArtifactImage, DefaultArtifactImage)
 }
 
+func GetMoveResultsImage() string {
+	return GetStringConfigWithDefault(MoveResultsImage, DefaultMoveResultImage)
+}
+
 func GetCopyStepTemplate() *workflowapi.Step {
 	var tpl workflowapi.Step
 	if err := viper.UnmarshalKey(ArtifactCopyStepTemplate, &tpl); err != nil {

backend/src/apiserver/common/const.go

@@ -73,6 +73,7 @@ const (
 	DefaultArtifactEndpoint       string = "minio-service.kubeflow:9000"
 	DefaultArtifactEndpointScheme string = "http://"
 	DefaultArtifactImage          string = "minio/mc"
+	DefaultMoveResultImage        string = "busybox"
 )
 
 const (

backend/src/apiserver/template/tekton_template.go

@@ -308,7 +308,7 @@ func (t *Tekton) injectArchivalStep(workflow util.Workflow, artifactItemsJSON ma
 					// move all results to /tekton/home/tep-results to avoid result duplication in copy-artifacts step
 					// TODO: disable eof strip, since no results under /tekton/results after this step
 					moveResults := workflowapi.Step{
-						Image:   "busybox",
+						Image:   common.GetMoveResultsImage(),
 						Name:    "move-all-results-to-tekton-home",
 						Command: []string{"sh", "-c"},
 						Args: []string{fmt.Sprintf("if [ -d /tekton/results ]; then mkdir -p %s; mv /tekton/results/* %s/ || true; fi\n",

manifests/kustomize/base/pipeline/apiserver-deployment.yaml

@@ -110,6 +110,11 @@ spec:
             configMapKeyRef:
               name: kfp-tekton-config
               key: artifact_image
+        - name: MOVERESULTS_IMAGE
+          valueFrom:
+            configMapKeyRef:
+              name: kfp-tekton-config
+              key: moveresults_image
         - name: INJECT_DEFAULT_SCRIPT
           valueFrom:
             configMapKeyRef:

manifests/kustomize/base/pipeline/kfp-pipeline-config.yaml

@@ -8,6 +8,7 @@ data:
   artifact_endpoint_scheme: "http://"
   artifact_image: "minio/mc:RELEASE.2020-11-25T23-04-07Z"
   archive_logs: "true"
+  moveresults_image: "busybox:1.34.1"
   track_artifacts: "true"
   strip_eof: "true"
   inject_default_script: "true"