chore(PipelineLoop): upgrade to tekton v0.41.0 (kubeflow#1072)

* upgrade to tekton v0.40.0

* fix tests

Author: ScrapCodes

.github/workflows/kfp-tekton-unittests.yml

@@ -30,6 +30,10 @@ jobs:
   validate-testdata:
     runs-on: ubuntu-latest
     steps:
+      - name: Install Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.19.x
       - uses: actions/checkout@v2
       - name: Set up Python 3.7
         uses: actions/setup-python@v2

tekton-catalog/pipeline-loops/go.mod

@@ -4,17 +4,18 @@ go 1.13
 
 require (
 	github.com/cenkalti/backoff/v4 v4.1.3
-	github.com/google/go-cmp v0.5.8
+	github.com/google/go-cmp v0.5.9
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/kubeflow/kfp-tekton/tekton-catalog/cache v0.0.0
 	github.com/kubeflow/kfp-tekton/tekton-catalog/objectstore v0.0.0
-	github.com/tektoncd/pipeline v0.38.4
-	go.uber.org/zap v1.21.0
+	github.com/tektoncd/pipeline v0.41.0
+	go.uber.org/zap v1.23.0
 	gomodules.xyz/jsonpatch/v2 v2.2.0
-	k8s.io/api v0.23.5
-	k8s.io/apimachinery v0.23.5
-	k8s.io/client-go v0.23.5
-	knative.dev/pkg v0.0.0-20220329144915-0a1ec2e0d46c
+	k8s.io/api v0.25.3
+	k8s.io/apimachinery v0.25.3
+	k8s.io/client-go v0.25.3
+	k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed
+	knative.dev/pkg v0.0.0-20221011175852-714b7630a836
 )
 
 replace (

tekton-catalog/pipeline-loops/pkg/apis/pipelineloop/v1alpha1/pipelineloop_types.go

@@ -17,6 +17,7 @@ limitations under the License.
 package v1alpha1
 
 import (
+	"github.com/tektoncd/pipeline/pkg/apis/pipeline/pod"
 	v1beta1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -74,7 +75,7 @@ type PipelineLoopSpec struct {
 
 	// PodTemplate holds pod specific configuration
 	// +optional
-	PodTemplate *v1beta1.PodTemplate `json:"podTemplate,omitempty"`
+	PodTemplate *pod.PodTemplate `json:"podTemplate,omitempty"`
 
 	// +optional
 	ServiceAccountName string `json:"serviceAccountName,omitempty"`

tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/controller.go

@@ -41,9 +41,10 @@ import (
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
 	metaV1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/util/clock"
+
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 	kubeclient "knative.dev/pkg/client/injection/kube/client"
 	"knative.dev/pkg/configmap"
 	"knative.dev/pkg/controller"

tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/pipelinelooprun.go

@@ -29,7 +29,8 @@ import (
 	"time"
 
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/util/clock"
+	"k8s.io/utils/clock"
+
 	duckv1 "knative.dev/pkg/apis/duck/v1"
 
 	"github.com/hashicorp/go-multierror"

tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/pipelinelooprun_test.go

@@ -33,6 +33,7 @@ import (
 	fakeclient "github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/pkg/client/injection/client/fake"
 	fakepipelineloopinformer "github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/pkg/client/injection/informers/pipelineloop/v1alpha1/pipelineloop/fake"
 	"github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/test"
+	"github.com/tektoncd/pipeline/pkg/apis/pipeline/pod"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
 	ttesting "github.com/tektoncd/pipeline/pkg/reconciler/testing"
@@ -331,7 +332,7 @@ var newPipelineLoop = &pipelineloopv1alpha1.PipelineLoop{
 		PipelineRef:        &v1beta1.PipelineRef{Name: "a-pipeline"},
 		IterateParam:       "current-item",
 		ServiceAccountName: "default",
-		PodTemplate: &v1beta1.PodTemplate{
+		PodTemplate: &pod.PodTemplate{
 			HostAliases: []corev1.HostAlias{{
 				IP:        "0.0.0.0",
 				Hostnames: []string{"localhost"},
@@ -341,7 +342,7 @@ var newPipelineLoop = &pipelineloopv1alpha1.PipelineLoop{
 		TaskRunSpecs: []v1beta1.PipelineTaskRunSpec{{
 			PipelineTaskName:       "test-task",
 			TaskServiceAccountName: "test",
-			TaskPodTemplate: &v1beta1.PodTemplate{
+			TaskPodTemplate: &pod.PodTemplate{
 				HostAliases: []corev1.HostAlias{{
 					IP:        "0.0.0.0",
 					Hostnames: []string{"localhost"},
@@ -584,7 +585,7 @@ var runNewPipelineLoopWithPodTemplateAndSA = &v1alpha1.Run{
 			Value: v1beta1.ArrayOrString{Type: v1beta1.ParamTypeArray, ArrayVal: []string{"item1", "item2"}},
 		}},
 		ServiceAccountName: "pipeline-runner",
-		PodTemplate: &v1beta1.PodTemplate{
+		PodTemplate: &pod.PodTemplate{
 			HostAliases: []corev1.HostAlias{{
 				IP:        "0.0.0.0",
 				Hostnames: []string{"localhost"},
@@ -1591,7 +1592,7 @@ var expectedPipelineRunWithPodTemplateAndSA = &v1beta1.PipelineRun{
 			Value: v1beta1.ArrayOrString{Type: v1beta1.ParamTypeString, StringVal: "item1"},
 		}},
 		ServiceAccountName: "pipeline-runner",
-		PodTemplate: &v1beta1.PodTemplate{
+		PodTemplate: &pod.PodTemplate{
 			HostAliases: []corev1.HostAlias{{
 				IP:        "0.0.0.0",
 				Hostnames: []string{"localhost"},
@@ -1634,7 +1635,7 @@ var expectedPipelineRunWithPodTemplate = &v1beta1.PipelineRun{
 			Value: v1beta1.ArrayOrString{Type: v1beta1.ParamTypeString, StringVal: "item1"},
 		}},
 		ServiceAccountName: "default",
-		PodTemplate: &v1beta1.PodTemplate{
+		PodTemplate: &pod.PodTemplate{
 			HostAliases: []corev1.HostAlias{{
 				IP:        "0.0.0.0",
 				Hostnames: []string{"localhost"},
@@ -1644,7 +1645,7 @@ var expectedPipelineRunWithPodTemplate = &v1beta1.PipelineRun{
 		TaskRunSpecs: []v1beta1.PipelineTaskRunSpec{{
 			PipelineTaskName:       "test-task",
 			TaskServiceAccountName: "test",
-			TaskPodTemplate: &v1beta1.PodTemplate{
+			TaskPodTemplate: &pod.PodTemplate{
 				HostAliases: []corev1.HostAlias{{
 					IP:        "0.0.0.0",
 					Hostnames: []string{"localhost"},