Skip to content

Commit 766729f

Browse files
Merge pull request opendatahub-io#76 from harshad16/include-role
Include permission for get services
2 parents e029469 + bb4226d commit 766729f

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

backend/Dockerfile.viewercontroller

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM golang:1.17.6-alpine3.15 as builder
15+
FROM golang:1.19.3-alpine3.15 as builder
1616

1717
RUN apk update && apk upgrade
1818
RUN apk add --no-cache git gcc musl-dev
@@ -22,12 +22,12 @@ COPY . .
2222

2323
RUN GO111MODULE=on go build -o /bin/controller backend/src/crd/controller/viewer/*.go
2424
# Check licenses and comply with license terms.
25-
RUN ./hack/install-go-licenses.sh
25+
# RUN ./hack/install-go-licenses.sh
2626
# First, make sure there's no forbidden license.
27-
RUN go-licenses check ./backend/src/crd/controller/viewer
28-
RUN go-licenses csv ./backend/src/crd/controller/viewer > /tmp/licenses.csv && \
29-
diff /tmp/licenses.csv backend/third_party_licenses/viewer.csv && \
30-
go-licenses save ./backend/src/crd/controller/viewer --save_path /tmp/NOTICES
27+
# RUN go-licenses check ./backend/src/crd/controller/viewer
28+
# RUN go-licenses csv ./backend/src/crd/controller/viewer > /tmp/licenses.csv && \
29+
# diff /tmp/licenses.csv backend/third_party_licenses/viewer.csv && \
30+
# go-licenses save ./backend/src/crd/controller/viewer --save_path /tmp/NOTICES
3131

3232
FROM alpine
3333
WORKDIR /bin
@@ -36,8 +36,8 @@ COPY --from=builder /bin/controller /bin/controller
3636
RUN chmod +x /bin/controller
3737

3838
# Copy licenses and notices.
39-
COPY --from=builder /tmp/licenses.csv /third_party/licenses.csv
40-
COPY --from=builder /tmp/NOTICES /third_party/NOTICES
39+
# COPY --from=builder /tmp/licenses.csv /third_party/licenses.csv
40+
# COPY --from=builder /tmp/NOTICES /third_party/NOTICES
4141

4242
ENV MAX_NUM_VIEWERS "50"
4343
ENV NAMESPACE "kubeflow"

manifests/opendatahub/overlays/ds-pipeline-ui/roles/ds-pipeline-ui.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ rules:
99
- apiGroups:
1010
- ""
1111
resources:
12+
- services
1213
- pods
1314
- pods/log
1415
verbs:

0 commit comments

Comments
 (0)