Skip to content

Commit 9b9b932

Browse files
authored
chore(sdk): Remove unnecessary code (kubeflow#1062)
1 parent 7e8d5ad commit 9b9b932

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed

sdk/python/kfp_tekton/compiler/compiler.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1956,34 +1956,3 @@ def _find_items(obj, search_key, current_path="", results_dict=dict()) -> dict:
19561956

19571957
if non_k8s_annotations:
19581958
raise RuntimeError(error_msg_tmplt % ("annotations", json.dumps(non_k8s_annotations, sort_keys=False, indent=2)))
1959-
1960-
# TODO: Tekton pipeline parameter validation
1961-
# workflow = workflow.copy()
1962-
# # Working around Argo lint issue
1963-
# for argument in workflow['spec'].get('arguments', {}).get('parameters', []):
1964-
# if 'value' not in argument:
1965-
# argument['value'] = ''
1966-
# yaml_text = dump_yaml(workflow)
1967-
# if '{{pipelineparam' in yaml_text:
1968-
# raise RuntimeError(
1969-
# '''Internal compiler error: Found unresolved PipelineParam.
1970-
# Please create a new issue at https://github.com/kubeflow/kfp-tekton/issues
1971-
# attaching the pipeline code and the pipeline package.'''
1972-
# )
1973-
1974-
# TODO: Tekton lint, if a tool exists for it
1975-
# # Running Argo lint if available
1976-
# import shutil
1977-
# import subprocess
1978-
# argo_path = shutil.which('argo')
1979-
# if argo_path:
1980-
# result = subprocess.run([argo_path, 'lint', '/dev/stdin'], input=yaml_text.encode('utf-8'),
1981-
# stdout=subprocess.PIPE, stderr=subprocess.PIPE)
1982-
# if result.returncode:
1983-
# raise RuntimeError(
1984-
# '''Internal compiler error: Compiler has produced Argo-incompatible workflow.
1985-
# Please create a new issue at https://github.com/kubeflow/kfp-tekton/issues
1986-
# attaching the pipeline code and the pipeline package.
1987-
# Error: {}'''.format(result.stderr.decode('utf-8'))
1988-
# )
1989-
pass

sdk/python/kfp_tekton/tekton.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ def CEL_ConditionOp(condition_statement):
179179
DEFAULT_CONDITION_OUTPUT_KEYWORD)
180180
ConditionOp_template = components.load_component_from_text(ConditionOp_yaml)
181181
ConditionOp = ConditionOp_template(condition_statement)
182-
ConditionOp.add_pod_annotation("valid_container", "false")
183182
return ConditionOp
184183

185184

0 commit comments

Comments
 (0)