Merge pull request opendatahub-io#61 from DharmitD/mysql-dump

feat(backend): Adding a cron job for MariaDB backup

Author: openshift-merge-robot

manifests/opendatahub/overlays/metadata-store-mariadb/cronjobs/mariadb-backup.yaml

@@ -0,0 +1,49 @@
+apiVersion: batch/v1
+kind: CronJob
+metadata:
+  labels:
+    application-crd-id: data-science-pipelines
+  name: mariadb-backup
+spec:
+  schedule: "0 0 * * *"
+  concurrencyPolicy: "Replace"
+  startingDeadlineSeconds: 200
+  suspend: false
+  successfulJobsHistoryLimit: 3
+  failedJobsHistoryLimit: 1
+  jobTemplate:
+    spec:
+      template:
+        metadata:
+          labels:
+            parent: "mariadb-backup"
+        spec:
+          containers:
+            - name: mariadb-backup
+              image: mysql
+              command:
+                - /bin/sh
+                - '-c'
+                - >
+                  mysqldump -h mysql -u $MYSQL_USER --password=$MYSQL_PASSWORD
+                  --all-databases > mariadb-backup.sql
+              env:
+                - name: MYSQL_USER
+                  valueFrom:
+                    secretKeyRef:
+                      name: $(database_secret)
+                      key: username
+                - name: MYSQL_PASSWORD
+                  valueFrom:
+                    secretKeyRef:
+                      name: $(database_secret)
+                      key: password
+                - name: MYSQL_DATABASE
+                  valueFrom:
+                    configMapKeyRef:
+                      key: pipelineDb
+                      name: $(pipeline_install_configuration)
+                - name: MYSQL_ALLOW_EMPTY_PASSWORD
+                  value: "true"
+          serviceAccountName: mysql
+          restartPolicy: Never

manifests/opendatahub/overlays/metadata-store-mariadb/kustomization.yaml

@@ -18,9 +18,15 @@ resources:
   # Services
   - ./services/mysql.yaml
 
+  # CronJobs
+  - ./cronjobs/mariadb-backup.yaml
+
 generatorOptions:
   disableNameSuffixHash: true
 
+configurations:
+  - params.yaml
+
 images:
   - name: mysql
     newName: registry.redhat.io/rhel8/mariadb-103

manifests/opendatahub/overlays/metadata-store-mariadb/params.yaml

@@ -0,0 +1,6 @@
+---
+varReference:
+  - path: spec/jobTemplate/spec/template/spec/containers[]/env[]/valueFrom/secretKeyRef/name
+    kind: CronJob
+  - path: spec/jobTemplate/spec/template/spec/containers[]/env[]/valueFrom/configMapKeyRef/name
+    kind: CronJob

tests/basictests/ds-pipelines.sh

@@ -12,12 +12,18 @@ os::test::junit::declare_suite_start "$MY_SCRIPT"
 function check_resources() {
     header "Testing Data Science Pipelines installation"
     os::cmd::expect_success "oc project ${ODHPROJECT}"
-    os::cmd::try_until_text "oc get crd pipelineruns.tekton.dev " "pipelineruns.tekton.dev" $odhdefaulttimeout $odhdefaultinterval
+    os::cmd::try_until_text "oc get crd pipelineruns.tekton.dev" "pipelineruns.tekton.dev" $odhdefaulttimeout $odhdefaultinterval
     os::cmd::try_until_text "oc get pods -l application-crd-id=data-science-pipelines --field-selector='status.phase!=Running,status.phase!=Completed' -o jsonpath='{$.items[*].metadata.name}' | wc -w" "0" $odhdefaulttimeout $odhdefaultinterval
     running_pods=$(oc get pods -l application-crd-id=data-science-pipelines --field-selector='status.phase=Running' -o jsonpath='{$.items[*].metadata.name}' | wc -w)
     os::cmd::expect_success "if [ "$running_pods" -gt "0" ]; then exit 0; else exit 1; fi"
 }
 
+function check_mariadb_backup() {
+    header "Check if MariaDB backup comes up correctly"
+    os::cmd::expect_success "oc get cronjob mariadb-backup"
+    os::cmd::expect_success "oc create job --from=cronjob/mariadb-backup mariadb-backup"
+}
+
 function check_ui_overlay() {
     header "Checking UI overlay Kfdef deploys the UI"
     os::cmd::try_until_text "oc get pods -l app=ds-pipeline-ui --field-selector='status.phase=Running' -o jsonpath='{$.items[*].metadata.name}' | wc -w" "1" $odhdefaulttimeout $odhdefaultinterval
@@ -85,6 +91,7 @@ function delete_pipeline() {
 }
 
 check_resources
+check_mariadb_backup
 check_ui_overlay
 create_pipeline
 list_pipelines