Update pipelinerun timeout format to timeouts (kubeflow#1031)

Author: Tomcli

sdk/python/kfp_tekton/compiler/compiler.py

@@ -54,8 +54,12 @@
 TEKTON_GLOBAL_DEFAULT_TIMEOUT = strtobool(env.get('TEKTON_GLOBAL_DEFAULT_TIMEOUT', 'false'))
 # DISABLE_CEL_CONDITION should be True until CEL is officially merged into Tekton main API.
 DISABLE_CEL_CONDITION = True
-# Default timeout is one year
+# Default tasks timeout is one year
 DEFAULT_TIMEOUT_MINUTES = "525600m"
+# Default whole pipeline timeout is two year
+DEFAULT_TIMEOUT_WITH_FINALLY_MINUTES = "1051200m"
+# Default finally extension is 5 minutes
+DEFAULT_FINALLY_SECONDS = 300
 
 
 def _get_super_condition_template():
@@ -1391,11 +1395,13 @@ def get_when_task(input_task_when, depended_conditions):
 
     # add workflow level timeout to pipeline run
     if not TEKTON_GLOBAL_DEFAULT_TIMEOUT or pipeline.conf.timeout:
+      pipeline_run['spec']['timeouts'] = {'pipeline': '0s', 'tasks': '0s'}
       if pipeline.conf.timeout > 0:
-        pipeline_run['spec']['timeout'] = '%ds' % pipeline.conf.timeout
+        pipeline_run['spec']['timeouts']['tasks'] = '%ds' % pipeline.conf.timeout
+        pipeline_run['spec']['timeouts']['pipeline'] = '%ds' % (pipeline.conf.timeout + DEFAULT_FINALLY_SECONDS)
       else:
-        pipeline_run['spec']['timeout'] = DEFAULT_TIMEOUT_MINUTES
-
+        pipeline_run['spec']['timeouts']['tasks'] = DEFAULT_TIMEOUT_MINUTES
+        pipeline_run['spec']['timeouts']['pipeline'] = DEFAULT_TIMEOUT_WITH_FINALLY_MINUTES
     # generate the Tekton podTemplate for image pull secret
     if len(pipeline.conf.image_pull_secrets) > 0:
       pipeline_run['spec']['podTemplate'] = pipeline_run['spec'].get('podTemplate', {})

sdk/python/tests/compiler/testdata/affinity.yaml

@@ -65,4 +65,6 @@ spec:
                 operator: In
                 values:
                 - linux
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/any_sequencer.yaml

@@ -213,4 +213,6 @@ spec:
         value: $(context.pipelineRun.name)
       - name: pipelineRun-namespace
         value: $(context.pipelineRun.namespace)
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/any_sequencer_looped.yaml

@@ -249,4 +249,6 @@ spec:
         metadata:
           labels:
             pipelines.kubeflow.org/cache_enabled: "true"
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/any_sequencer_looped_noninlined.yaml

@@ -182,4 +182,6 @@ spec:
       params:
       - name: param-loop-item
         value: $(params.param)
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/artifact_outputs.yaml

@@ -130,7 +130,9 @@ spec:
         workspace: artifact-out-pipeline
     workspaces:
     - name: artifact-out-pipeline
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m
   workspaces:
   - name: artifact-out-pipeline
     volumeClaimTemplate:

sdk/python/tests/compiler/testdata/artifact_passing_using_volume.yaml

@@ -350,7 +350,9 @@ spec:
       timeout: 525600m
     workspaces:
     - name: artifact-passing-pipeline
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m
   workspaces:
   - name: artifact-passing-pipeline
     persistentVolumeClaim:

sdk/python/tests/compiler/testdata/basic_no_decorator.yaml

@@ -134,4 +134,6 @@ spec:
     taskPodTemplate:
       nodeSelector:
         kubernetes.io/os: linux
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/big_data_multi_volumes_1.yaml

@@ -116,4 +116,6 @@ spec:
           - name: input-text
             mountPath: /tmp/inputs/input_text
       timeout: 525600m
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m

sdk/python/tests/compiler/testdata/big_data_multi_volumes_2.yaml

@@ -125,4 +125,6 @@ spec:
           - name: input-text-1
             mountPath: /tmp/inputs/input_text_1
       timeout: 525600m
-  timeout: 525600m
+  timeouts:
+    pipeline: 1051200m
+    tasks: 525600m