Skip to content

Commit af67923

Browse files
Merge pull request opendatahub-io#25 from kubeflow/master
[pull] master from kubeflow:master
2 parents 83c7224 + 37efcf0 commit af67923

File tree

154 files changed

+5181
-1462
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

154 files changed

+5181
-1462
lines changed

.kfp-rebase-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.8.1
1+
1.8.4

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# - The help target was derived from https://stackoverflow.com/a/35730328/5601796
1717

1818
VENV ?= .venv
19-
KFP_TEKTON_RELEASE ?= v1.3.0
19+
KFP_TEKTON_RELEASE ?= v1.3.1
2020
export VIRTUAL_ENV := $(abspath ${VENV})
2121
export PATH := ${VIRTUAL_ENV}/bin:${PATH}
2222
DOCKER_REGISTRY ?= aipipeline

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.3.0
1+
1.3.1

backend/src/cache/server/watcher.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"log"
87
"reflect"
98
"strconv"
109
"time"
@@ -47,12 +46,16 @@ func WatchPods(ctx context.Context, namespaceToWatch string, clientManager Clien
4746
}
4847

4948
for event := range watcher.ResultChan() {
50-
pod := reflect.ValueOf(event.Object).Interface().(*corev1.Pod)
49+
pod, ok := reflect.ValueOf(event.Object).Interface().(*corev1.Pod)
50+
if !ok {
51+
logger.Warnf("Not processing WatchPods as event Object is not a Pod, event type: %s", event.Type)
52+
continue
53+
}
54+
5155
if event.Type == watch.Error {
5256
logger.Errorf("Watcher error in loop: %v", event.Type)
5357
continue
5458
}
55-
log.Printf((*pod).GetName())
5659

5760
if !isPodCompletedAndSucceeded(pod) {
5861
logger.Warnf("Pod %s is not completed or not in successful status, skip the loop.", pod.ObjectMeta.Name)

guides/kfp_tekton_install.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ To install the standalone Kubeflow Pipelines with Tekton, run the following step
5353
-p '{"data":{"enable-custom-tasks": "true"}}'
5454
```
5555

56-
3. Install Kubeflow Pipelines with Tekton backend (`kfp-tekton`) `v1.3.0` [custom resource definitions](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/)(CRDs).
56+
3. Install Kubeflow Pipelines with Tekton backend (`kfp-tekton`) `v1.3.1` [custom resource definitions](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/)(CRDs).
5757
> Note: You can ignore the error `no matches for kind "Application" in version "app.k8s.io/v1beta1"` since it's a warning saying `application` CRD is not yet ready.
5858
```shell
59-
kubectl apply --selector kubeflow/crd-install=true -f install/v1.3.0/kfp-tekton.yaml
59+
kubectl apply --selector kubeflow/crd-install=true -f install/v1.3.1/kfp-tekton.yaml
6060
```
6161

62-
4. Install Kubeflow Pipelines with Tekton backend (`kfp-tekton`) `v1.3.0` deployment
62+
4. Install Kubeflow Pipelines with Tekton backend (`kfp-tekton`) `v1.3.1` deployment
6363
```shell
64-
kubectl apply -f install/v1.3.0/kfp-tekton.yaml
64+
kubectl apply -f install/v1.3.1/kfp-tekton.yaml
6565
```
6666

6767
5. Then, if you want to expose the Kubeflow Pipelines endpoint outside the cluster, run the following commands:

0 commit comments

Comments
 (0)