feat(sdk): add custom task param support in command spec (kubeflow#1061)

Author: Tomcli

sdk/python/kfp_tekton/compiler/compiler.py

@@ -1006,13 +1006,23 @@ def map_cel_vars(a):
           if i.get('image', '') in TEKTON_CUSTOM_TASK_IMAGES:
             custom_task_args = {}
             container_args = i.get('args', [])
+            custom_task_command = {}
+            container_command = i.get('command', [])
             for index, item in enumerate(container_args):
               if item.startswith('--'):
                 custom_task_args[item[2:]] = container_args[index + 1]
+            for index, item in enumerate(container_command):
+              if item.startswith('--'):
+                custom_task_command[item[2:]] = container_command[index + 1]
             non_param_keys = ['name', 'apiVersion', 'kind', 'taskSpec', 'taskRef']
             task_params = []
+            command_params = []
+            for key, value in custom_task_command.items():
+              task_params.append({'name': key, 'value': value})
+              # Parameters in command spec get higher priority
+              command_params.append(key)
             for key, value in custom_task_args.items():
-              if key not in non_param_keys:
+              if key not in non_param_keys and key not in command_params:
                 task_params.append({'name': key, 'value': value})
             task_orig_params = task_ref['params']
             task_ref = {

sdk/python/tests/compiler/testdata/custom_task_params.py

@@ -19,7 +19,6 @@
 custom_task_name = "some-custom-task"
 custom_task_api_version = "custom.tekton.dev/v1alpha1"
 custom_task_image = "some-image"
-custom_task_command = "cmd"
 custom_task_kind = "custom-task"
 
 
@@ -61,7 +60,7 @@ def custom_task(resource_label: str, foo: str, bar: Any, pi: float) -> dsl.Conta
     task = dsl.ContainerOp(
         name=custom_task_name,
         image=custom_task_image,
-        command=[custom_task_command],
+        command=["--name", foo],
         arguments=[
             "--apiVersion", custom_task_api_version,
             "--kind", custom_task_kind,

sdk/python/tests/compiler/testdata/custom_task_params_ref.yaml

@@ -52,6 +52,8 @@ spec:
     tasks:
     - name: some-custom-task
       params:
+      - name: name
+        value: $(params.foo)
       - name: foo
         value: $(params.foo)
       - name: bar

sdk/python/tests/compiler/testdata/custom_task_params_spec.yaml

@@ -52,6 +52,8 @@ spec:
     tasks:
     - name: some-custom-task
       params:
+      - name: name
+        value: $(params.foo)
       - name: foo
         value: $(params.foo)
       - name: bar