Skip to content

Commit dc82a8d

Browse files
committed
Remove Namespace CLI flag in persistenceagent
- Convert PersistenceAgent Role/RoleBinding to ClusterRole/ClusterRoleBinding - Remove namespace flag from persistenceagent
1 parent 3b2284b commit dc82a8d

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
apiVersion: rbac.authorization.k8s.io/v1
2-
kind: RoleBinding
2+
kind: ClusterRoleBinding
33
metadata:
44
labels:
55
application-crd-id: data-science-pipelines
6-
name: ds-pipeline-persistenceagent-binding
6+
name: ds-pipeline-persistenceagent-clusterrolebinding
77
roleRef:
88
apiGroup: rbac.authorization.k8s.io
9-
kind: Role
10-
name: ds-pipeline-persistenceagent-role
9+
kind: ClusterRole
10+
name: ds-pipeline-persistenceagent-clusterrole
1111
subjects:
1212
- kind: ServiceAccount
1313
name: ds-pipeline-persistenceagent

manifests/opendatahub/base/roles/ds-pipeline-persistenceagent-role.yaml renamed to manifests/opendatahub/base/clusterroles/ds-pipeline-persistenceagent-clusterrole.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
apiVersion: rbac.authorization.k8s.io/v1
2-
kind: Role
2+
kind: ClusterRole
33
metadata:
44
labels:
55
application-crd-id: data-science-pipelines
6-
name: ds-pipeline-persistenceagent-role
6+
name: ds-pipeline-persistenceagent-clusterrole
77
rules:
88
- apiGroups:
99
- argoproj.io

manifests/opendatahub/base/deployments/ds-pipeline-persistenceagent.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ spec:
3030
command:
3131
- persistence_agent
3232
- "--logtostderr=true"
33-
- "--namespace=$(namespace)"
3433
- "--ttlSecondsAfterWorkflowFinish=86400"
3534
- "--numWorker=2"
3635
- "--mlPipelineAPIServerName=ds-pipeline"

manifests/opendatahub/base/kustomization.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,23 @@ resources:
1515
- ./deployments/ds-pipeline.yaml
1616

1717
# Rolebindings
18-
- ./rolebindings/ds-pipeline-persistenceagent-binding.yaml
1918
- ./rolebindings/ds-pipeline-scheduledworkflow-binding.yaml
2019
- ./rolebindings/ds-pipeline-viewer-crd-binding.yaml
2120
- ./rolebindings/ds-pipeline.yaml
2221
- ./rolebindings/pipeline-runner-binding.yaml
2322

2423
# Roles
25-
- ./roles/ds-pipeline-persistenceagent-role.yaml
2624
- ./roles/ds-pipeline-scheduledworkflow-role.yaml
2725
- ./roles/ds-pipeline-viewer-controller-role.yaml
2826
- ./roles/ds-pipeline.yaml
2927
- ./roles/pipeline-runner.yaml
3028

29+
# ClusterRoleBindings
30+
- ./clusterrolebindings/ds-pipeline-persistenceagent-clusterrolebinding.yaml
31+
32+
# ClusterRoles
33+
- ./clusterroles/ds-pipeline-persistenceagent-clusterrole.yaml
34+
3135
# ServiceAccounts
3236
- ./serviceaccounts/ds-pipeline-container-builder.yaml
3337
- ./serviceaccounts/ds-pipeline-persistenceagent.yaml
@@ -88,6 +92,7 @@ vars:
8892
apiVersion: v1
8993
fieldref:
9094
fieldpath: data.ds_pipelines_ui_configuration
95+
9196
configurations:
9297
- params.yaml
9398

0 commit comments

Comments
 (0)