Merged
Conversation
michel2323
reviewed
Feb 21, 2025
|
|
||
| pos = colptrL[index] | ||
| offset = offsets[index] | ||
| mj = m[index] |
Member
There was a problem hiding this comment.
What may be faster is doing mj = maximum(m) outside the kernel and pass as Val(mj) and then if j<mj. Same for i. Just suggesting if this is too slow.
Member
Author
There was a problem hiding this comment.
The code is not working right now @michel2323 and I don't understand now. :(
michel2323
reviewed
Feb 21, 2025
| for s in 1:mj | ||
| for t in s:mj | ||
| acc = 0.0 | ||
| for i = 1:r |
Member
There was a problem hiding this comment.
Can't one move this inner loop to the outer loop?
Member
Author
There was a problem hiding this comment.
We can't because it's a dot product between samples[s] and samples[t].
amontoison
force-pushed
the
vecchia_mul_kernel
branch
from
293af00 to
c99e650
Compare
Member
Author
|
@michel2323 @CalebDerrickson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @michel2323 @CalebDerrickson