Improve Credit Pool tests

Author: JulianVennen

src/main/java/com/exaroton/api/billing/pools/CreditPoolMember.java

@@ -1,38 +1,28 @@
 package com.exaroton.api.billing.pools;
 
-import org.jetbrains.annotations.ApiStatus;
-
+@SuppressWarnings("unused")
 public class CreditPoolMember {
     /**
      * Unique ID of the account
      */
-    private final String account;
+    private String account;
     /**
      * Unique (but changeable) display name of the account.
      */
-    private final String name;
+    private String name;
     /**
      * The share of credits in the pool that belong to the account.
      * e.g. 0.5 means the account owns 50% of the credits in the pool.
      */
-    private final double share;
+    private double share;
     /**
      * The amount of credits in the pool that belong to the account.
      */
-    private final double credits;
+    private double credits;
     /**
      * Is the account the owner of the pool
      */
-    private final boolean isOwner;
-
-    @ApiStatus.Internal
-    public CreditPoolMember(String account, String name, double share, double credits, boolean isOwner) {
-        this.account = account;
-        this.name = name;
-        this.share = share;
-        this.credits = credits;
-        this.isOwner = isOwner;
-    }
+    private boolean isOwner;
 
     /**
      * @return unique ID of the account

src/test/java/CreditPoolsTest.java

@@ -38,6 +38,22 @@ public void testGetPool() throws IOException {
         checkTestPool(pool);
     }
 
+    @Test
+    public void testGetPoolCache() throws IOException {
+        CreditPool pool = client.getCreditPool(TEST_POOL_ID);
+
+        var future = pool.fetch(false);
+        Assertions.assertFalse(future.isDone());
+        Assertions.assertNull(future.getNow(null));
+
+        checkTestPool(pool.fetch().join());
+        checkTestPool(pool);
+
+        future = pool.fetch(false);
+        Assertions.assertTrue(future.isDone());
+        checkTestPool(future.getNow(null));
+    }
+
     @Test
     public void testGetPoolMembers() throws IOException {
         CreditPool pool = client.getCreditPool(TEST_POOL_ID);
@@ -48,6 +64,7 @@ public void testGetPoolMembers() throws IOException {
         Optional<CreditPoolMember> owner = members.stream().filter(CreditPoolMember::isOwner).findFirst();
         Assertions.assertTrue(owner.isPresent());
         Assertions.assertNotNull(owner.get().getAccount());
+        Assertions.assertNotNull(owner.get().getName());
         Assertions.assertTrue(owner.get().isOwner());
         Assertions.assertTrue(owner.get().getCredits() > 100, "Expected owner to have more than 100 credits, got " + owner.get().getCredits());
         Assertions.assertEquals(1, owner.get().getShare());