Merge pull request #39 from exasol-labs/ja.aggregate-error-fix

Unpack AggregateError inner errors in formatError for better diagnostics

Author: mkcorneli

src/connectionTypes.ts

@@ -11,6 +11,10 @@ export type TlsMode = 'off' | 'fingerprint' | 'full';
  * instead of Error instances.
  */
 export function formatError(error: unknown): string {
+    if (error instanceof AggregateError && error.errors?.length) {
+        const inner = error.errors.map(e => formatError(e)).join('; ');
+        return error.message ? `${error.message}: ${inner}` : inner;
+    }
     if (error instanceof Error) {
         // Some errors (e.g. from ws/Node.js net) have an empty message but a useful .code
         const code = (error as any).code;

src/extension.ts

@@ -15,6 +15,7 @@ import { SessionManager } from './sessionManager';
 import { ObjectActions } from './objectActions';
 import { ObjectSearchProvider } from './providers/objectSearchProvider';
 import { findStatementAtCursor, splitIntoStatements } from './utils';
+import { formatError } from './connectionTypes';
 
 // Create output channel for logging
 let outputChannel: vscode.OutputChannel;
@@ -616,7 +617,7 @@ async function executeQuery(
                         }
 
                     } catch (error) {
-                        const errorMsg = String(error);
+                        const errorMsg = formatError(error);
 
                         if (statements.length > 1) {
                             output.appendLine(`   ❌ Query ${queryNum} failed: ${errorMsg}`);
@@ -843,7 +844,7 @@ async function executeStatement(
             }
         );
     } catch (error) {
-        const errorMsg = String(error);
+        const errorMsg = formatError(error);
         output.appendLine(`❌ Query failed: ${errorMsg}`);
 
         // Show error in results panel

src/panels/connectionPanel.ts

@@ -1,5 +1,5 @@
 import * as vscode from 'vscode';
-import { ConnectionManager, ExasolConnection, FingerprintRequiredError, FingerprintMismatchError, normalizeFingerprint, extractFingerprintError, TlsMode } from '../connectionManager';
+import { ConnectionManager, ExasolConnection, FingerprintRequiredError, FingerprintMismatchError, normalizeFingerprint, extractFingerprintError, TlsMode, formatError } from '../connectionManager';
 
 export class ConnectionPanel {
     public static currentPanel: ConnectionPanel | undefined;
@@ -169,7 +169,7 @@ export class ConnectionPanel {
                 return;
             }
 
-            const errorMsg = String(error);
+            const errorMsg = formatError(error);
             this.outputChannel.appendLine(`❌ Connection test failed: ${errorMsg}`);
             this._panel.webview.postMessage({ command: 'error', error: errorMsg });
         }

src/test/unit/tlsValidation.test.ts

@@ -100,6 +100,22 @@ suite('formatError', () => {
     test('handles numbers', () => {
         assert.strictEqual(formatError(42), '42');
     });
+
+    test('unpacks AggregateError inner errors', () => {
+        const inner1 = new Error('connect ECONNREFUSED 10.0.0.1:8563');
+        const inner2 = new Error('connect ETIMEDOUT 10.0.0.2:8563');
+        const agg = new AggregateError([inner1, inner2], 'All connection attempts failed');
+        assert.strictEqual(
+            formatError(agg),
+            'All connection attempts failed: connect ECONNREFUSED 10.0.0.1:8563; connect ETIMEDOUT 10.0.0.2:8563'
+        );
+    });
+
+    test('unpacks AggregateError with no message', () => {
+        const inner = new Error('ECONNREFUSED');
+        const agg = new AggregateError([inner]);
+        assert.strictEqual(formatError(agg), 'ECONNREFUSED');
+    });
 });
 
 suite('FingerprintRequiredError', () => {