Remove defaults and instead use BaseConfig-inherited values

Author: ArBridgeman

exasol/toolbox/config.py

@@ -53,7 +53,7 @@ class BaseConfig(BaseModel):
 
     @computed_field  # type: ignore[misc]
     @property
-    def min_py_version(self) -> str:
+    def minimum_python_version(self) -> str:
         """
         Minimum Python version declared from the `python_versions` list
 

exasol/toolbox/nox/_artifacts.py

@@ -12,7 +12,7 @@
 import nox
 from nox import Session
 
-from exasol.toolbox.nox._shared import MINIMUM_PYTHON_VERSION
+from exasol.toolbox.nox._shared import check_for_config_attribute
 from noxconfig import (
     PROJECT_CONFIG,
     Config,
@@ -159,8 +159,8 @@ def copy_artifacts(session: Session) -> None:
 
 
 def _python_version_suffix() -> str:
-    versions = getattr(PROJECT_CONFIG, "python_versions", None)
-    pivot = versions[0] if versions else MINIMUM_PYTHON_VERSION
+    check_for_config_attribute(PROJECT_CONFIG, "minimum_python_version")
+    pivot = PROJECT_CONFIG.minimum_python_version
     return f"-python{pivot}"
 
 

exasol/toolbox/nox/_ci.py

@@ -4,6 +4,7 @@
 import nox
 from nox import Session
 
+from exasol.toolbox.nox._shared import check_for_config_attribute
 from noxconfig import (
     PROJECT_CONFIG,
     Config,
@@ -12,17 +13,6 @@
 _log = logging.getLogger(__name__)
 
 
-def check_for_config_attribute(config: Config, attribute: str):
-    if not hasattr(config, attribute):
-        raise AttributeError(
-            "in the noxconfig.py file, the class Config should inherit "
-            "from `exasol.toolbox.config.BaseConfig`. This is used to "
-            f"set the default `{attribute}`. If the allowed "
-            f"`{attribute} needs to differ in your project, you can "
-            "set it in the PROJECT_CONFIG statement."
-        )
-
-
 def _python_matrix(config: Config):
     check_for_config_attribute(config=config, attribute="python_versions")
     return {"python-version": config.python_versions}

exasol/toolbox/nox/_shared.py

@@ -15,12 +15,24 @@
 
 from nox import Session
 
-from noxconfig import PROJECT_CONFIG
+from noxconfig import (
+    PROJECT_CONFIG,
+    Config,
+)
 
 DEFAULT_PATH_FILTERS = {"dist", ".eggs", "venv", ".poetry"}
 DOCS_OUTPUT_DIR = ".html-documentation"
 
-MINIMUM_PYTHON_VERSION = "3.9"
+
+def check_for_config_attribute(config: Config, attribute: str):
+    if not hasattr(config, attribute):
+        raise AttributeError(
+            "in the noxconfig.py file, the class Config should inherit "
+            "from `exasol.toolbox.config.BaseConfig`. This is used to "
+            f"set the default `{attribute}`. If the allowed "
+            f"`{attribute} needs to differ in your project and is an "
+            "input parameter (not property), you can set it in the PROJECT_CONFIG statement."
+        )
 
 
 class Mode(Enum):

test/unit/config_test.py

@@ -59,4 +59,4 @@ def test_expansion_validation_fails_for_invalid_version():
 
 def test_min_py_version():
     conf = BaseConfig(python_versions=("5.5.5", "1.1.1", "9.9.9"))
-    assert conf.min_py_version == "1.1.1"
+    assert conf.minimum_python_version == "1.1.1"